Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-9.0

Modules to migrate

• partner_survey #16
• survey_percent_question - By @tarteo - #21
• survey_one_choice_per_column - By @tarteo - #20

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-14.0

Modules to migrate

Missing module? Check https://github.com/OCA/maintainer-tools/wiki/%5BFAQ%5D-Missing-modules-in-migration-issue-list

Is your feature request related to a problem?
It's not possible to define a ranked voting survey.

Describe the solution you'd like
Ranked voting system can be chosen for some questions.

Describe alternatives you've considered
Loomio

Module

Surveys (Odoo v16.0)

Describe the bug

When a user selects an answer that reveals more-than-one conditional questions where at least one is mandatory, followed by changing principal answer to hide conditional questions, the user is blocked from navigating to the next section.

Only one of the conditional questions must be marked as mandatory to prevent section navigation.

##Severity
Medium to Major
While this bug doesn't completely break survey module, it does break the ability to use multiple conditional questions -- where at least one is mandatory -- in response to a single principal question. This can be a serious problem for strategic information gathering.

To Reproduce

Odoo v16.0:

1. Create a new survey.
2. Configure presentation option to "One page per section".
3. On the questions tab, add two sections and title them Section 1 and Section 2 respectively.
4. Under the second section add a simple textfield question. This is necessary so that navigating from the first section doesn't go immediately to the end of the survey.
5. Under the first section, add three multiple choice questions. Name the first question "Principal" and the second and third questions "Conditional 1" and "Conditional 2".
6. The survey question table should look like this:
   
7. On Principal, add two answer choices with these values: "Show additional questions" and "Skip"
8. On Conditional 1 and Conditional 2, add a couple multiple choice answers for each of them. The answers can be anything you want.
9. Save the form. (Saving here is necessary so that the conditional options can be configured in the next step).
10. Configure both conditional questions to be Conditional to the Principal. Set the Triggering Answer to be "Show additional questions"
11. Make Conditional 1 mandatory. The other two questions should not be mandatory.
12. Save the form.

Test the Survey

1. Click Start Survey button.
2. You should see the Principal Question.
3. Select "Show additional questions"
4. You should see the conditional questions.
5. Change the principal answer to "Skip"
6. Click Continue button
7. Nothing should happen! Navigation is blocked!
8. Change the principal answer to "Show additional questions"
9. You should see that the first question has the red notice indicating an answer is required.

Follow up changes and Second Test

1. Close the Test and go back to the Survey admin UI.
2. Open the options for Conditional 2. Uncheck "Conditional".
3. Save survey and test it again.
4. Repeat the same test procedure from above but you should see that navigation works fine.

##Analysis
If there is more-than-one conditional question, the validation logic requires mandatory conditional questions to be answered.

##Additional Concerns
I haven't looked at the javascript code, because I'm completely new to Odoo framework and my time is quite constrained right now. However, I want to voice that the nature of this bug would lead a seasoned developer to question the efficacy of the underlying code. Its a very weird bug that, at least to my mind, suggests the entire validation logic might be a bit shakey -- I find it hard to imagine writing such a weird bug into my own javascript. This is a wildly speculative observation, but I think its worth mentioning. It would be bad if there are other strange bugs lurking with technical debt.

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-10.0

Modules to migrate

• partner_survey - By @grindtildeath - #22

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-15.0

Modules to migrate

Missing module? Check https://github.com/OCA/maintainer-tools/wiki/%5BFAQ%5D-Missing-modules-in-migration-issue-list

• survery_result_mail - By @chienandalu - #88
• survey_contact_generation - By @stefan-tecnativa - #81
• survey_crm_generation - By @stefan-tecnativa - #77
• survey_crm_sale_generation - By @stefan-tecnativa - #80
• survey_legal - By @chienandalu - #95
• survey_resource_booking - By @stefan-tecnativa - #75
• survey_xlsx - By @gurneyalex - #73

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-13.0

Modules to migrate

• partner_survey - By @skeller1 - #33
• survey_conditional_question - By @olgamarcocb - #45
• survey_resource_booking - By @victoralmau - #51

Missing module? Check https://github.com/OCA/maintainer-tools/wiki/%5BFAQ%5D-Missing-modules-in-migration-issue-list

Module

five star module

Describe the bug

five star module has reference to scss parameter declared in nps module

To Reproduce

Affected versions: 14.0

Steps to reproduce the behavior:

1. install five star type module and do not install not nps type module
2. visit a survey form
3. see error page

Expected behavior
I shall not see an error message

Additional context

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0

Modules to migrate

• partner_survey - By @chaule97 - #128
• survey_question_type_binary - By @m1k3lm - #129
• survey_question_type_five_star

Missing module? Check https://github.com/OCA/maintainer-tools/wiki/%5BFAQ%5D-Missing-modules-in-migration-issue-list

Below is the error message I am prompted with. Please note that the module did not install properly. So I had to uninstall it. I am on Odoo CE version 12 hosted on AWS.

Odoo Server Error
Traceback (most recent call last):
File "/opt/bitnami/apps/odoo/lib/odoo-12.0.post20190618-py3.7.egg/odoo/http.py", line 656, in _handle_exception
return super(JsonRequest, self)._handle_exception(exception)
File "/opt/bitnami/apps/odoo/lib/odoo-12.0.post20190618-py3.7.egg/odoo/http.py", line 314, in _handle_exception
raise pycompat.reraise(type(exception), exception, sys.exc_info()[2])
File "/opt/bitnami/apps/odoo/lib/odoo-12.0.post20190618-py3.7.egg/odoo/tools/pycompat.py", line 87, in reraise
raise value
File "/opt/bitnami/apps/odoo/lib/odoo-12.0.post20190618-py3.7.egg/odoo/http.py", line 698, in dispatch
result = self._call_function(**self.params)
File "/opt/bitnami/apps/odoo/lib/odoo-12.0.post20190618-py3.7.egg/odoo/http.py", line 346, in _call_function
return checked_call(self.db, *args, **kwargs)
File "/opt/bitnami/apps/odoo/lib/odoo-12.0.post20190618-py3.7.egg/odoo/service/model.py", line 97, in wrapper
return f(dbname, *args, **kwargs)
File "/opt/bitnami/apps/odoo/lib/odoo-12.0.post20190618-py3.7.egg/odoo/http.py", line 339, in checked_call
result = self.endpoint(*a, **kw)
File "/opt/bitnami/apps/odoo/lib/odoo-12.0.post20190618-py3.7.egg/odoo/http.py", line 941, in call
return self.method(*args, **kw)
File "/opt/bitnami/apps/odoo/lib/odoo-12.0.post20190618-py3.7.egg/odoo/http.py", line 519, in response_wrap
response = f(*args, **kw)
File "/opt/bitnami/apps/odoo/lib/odoo-12.0.post20190618-py3.7.egg/odoo/addons/web/controllers/main.py", line 962, in call_kw
return self._call_kw(model, method, args, kwargs)
File "/opt/bitnami/apps/odoo/lib/odoo-12.0.post20190618-py3.7.egg/odoo/addons/web/controllers/main.py", line 954, in _call_kw
return call_kw(request.env[model], method, args, kwargs)
File "/opt/bitnami/apps/odoo/lib/odoo-12.0.post20190618-py3.7.egg/odoo/api.py", line 745, in call_kw
return _call_kw_model(method, model, args, kwargs)
File "/opt/bitnami/apps/odoo/lib/odoo-12.0.post20190618-py3.7.egg/odoo/api.py", line 718, in _call_kw_model
result = method(recs, *args, **kwargs)
File "/opt/bitnami/apps/odoo/lib/odoo-12.0.post20190618-py3.7.egg/odoo/models.py", line 1376, in load_views
for [v_id, v_type] in views
File "/opt/bitnami/apps/odoo/lib/odoo-12.0.post20190618-py3.7.egg/odoo/models.py", line 1376, in
for [v_id, v_type] in views
File "/opt/bitnami/apps/odoo/lib/odoo-12.0.post20190618-py3.7.egg/odoo/addons/mail/models/mail_thread.py", line 410, in fields_view_get
res = super(MailThread, self).fields_view_get(view_id=view_id, view_type=view_type, toolbar=toolbar, submenu=submenu)
File "/opt/bitnami/apps/odoo/lib/odoo-12.0.post20190618-py3.7.egg/odoo/models.py", line 1462, in fields_view_get
xarch, xfields = View.postprocess_and_fields(self._name, etree.fromstring(result['arch']), view_id)
File "/opt/bitnami/apps/odoo/lib/odoo-12.0.post20190618-py3.7.egg/odoo/addons/base/models/ir_ui_view.py", line 1096, in postprocess_and_fields
self.raise_view_error(message, view_id)
File "/opt/bitnami/apps/odoo/lib/odoo-12.0.post20190618-py3.7.egg/odoo/addons/base/models/ir_ui_view.py", line 548, in raise_view_error
raise ValueError(message)
ValueError: Field survey_input_count does not exist

Error context:
View res.partner.form
[view_id: 113, xml_id: base.view_partner_form, model: res.partner, parent_id: n/a]

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-12.0

Modules to migrate

• partner_survey - By @ernestotejeda - #29

Before proposing to upload a new addon called: survey_user_input_expired that we already have developed, I would like to know if something similar exists.

This addon would replace the state of the survey responses to define a new state called: expired
In addition, using a cron that runs once a day, responses with expired status are auto-defined with respect to all those that have a deadline defined.

Thank you very much.

Module

Surveys (on odoo 16.0)

Describe the bug

If you delete a question from a survey, then all participation (completed survey submission / user_input) answers to that question get deleted.

##Steps to Reproduce
Super easy to reproduce. Submit completion of any survey (collect at least one participation/user_input). Then go to the survey and delete a question. Then go view the Survey Participation Result, and you'll see the question and answer are gone.

Expected behavior
If I attempt to delete a question on a survey with linked participations, I should get a ForeignKey constraint violation error.

##How to fix
Navigate to surveys > models > survey_user_input.py > SurveyUserInputLine(models.Model) class > question_id
(Currently line 619)
The line for question_id property says:
question_id = fields.Many2one('survey.question', string='Question', ondelete='cascade', required=True)
This looks like a bug to me. "ondelete='cascade' means that a deletion to the question will delete all answers. This should be ondelete='restrict' so that the database refuses to delete a question that has user-submitted survey answers.

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-11.0

Modules to migrate

• partner_survey

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0

Modules to migrate

Missing module? Check https://github.com/OCA/maintainer-tools/wiki/%5BFAQ%5D-Missing-modules-in-migration-issue-list

• partner_survey - By @matiasperalta1 - #87
• survey_question_type_binary - By @jguenat - #121
• survey_question_type_five_star - By @baimont - #58

module: partner_survey
version: 8.0.1.0.0

Steps to reproduce

• ...email survey to existing partner.
  partner clicks on link in email and answers survey.
  go to partner list view.
  under advanced search, the following options exist:
  • Survey number
  • Surveys
  • Surveys answers

Current behavior

• Survey number appears to be populated with the number of surveys a partner has been sent? This has some use as a filter.
• Surveys and Surveys answers appear to be expecting a date to be entered as the filter value or the following occurs:

Traceback (most recent call last):
File "C:\Program Files (x86)\Odoo 8.0-20150522\server.\openerp\http.py", line 536, in _handle_exception
File "C:\Program Files (x86)\Odoo 8.0-20150522\server.\openerp\http.py", line 573, in dispatch
File "C:\Program Files (x86)\Odoo 8.0-20150522\server.\openerp\http.py", line 309, in _call_function
File "C:\Program Files (x86)\Odoo 8.0-20150522\server.\openerp\service\model.py", line 113, in wrapper
File "C:\Program Files (x86)\Odoo 8.0-20150522\server.\openerp\http.py", line 306, in checked_call
File "C:\Program Files (x86)\Odoo 8.0-20150522\server.\openerp\http.py", line 802, in call
File "C:\Program Files (x86)\Odoo 8.0-20150522\server.\openerp\http.py", line 402, in response_wrap
File "C:\Program Files (x86)\Odoo 8.0-20150522\server\openerp\addons\web\controllers\main.py", line 877, in search_read
File "C:\Program Files (x86)\Odoo 8.0-20150522\server\openerp\addons\web\controllers\main.py", line 898, in do_search_read
File "C:\Program Files (x86)\Odoo 8.0-20150522\server.\openerp\http.py", line 907, in proxy
File "C:\Program Files (x86)\Odoo 8.0-20150522\server.\openerp\api.py", line 241, in wrapper
File "C:\Program Files (x86)\Odoo 8.0-20150522\server.\openerp\models.py", line 5129, in search_read
File "C:\Program Files (x86)\Odoo 8.0-20150522\server.\openerp\api.py", line 241, in wrapper
File "C:\Program Files (x86)\Odoo 8.0-20150522\server.\openerp\models.py", line 1642, in search
File "C:\Program Files (x86)\Odoo 8.0-20150522\server.\openerp\api.py", line 241, in wrapper
File "C:\Program Files (x86)\Odoo 8.0-20150522\server\openerp\addons\base\res\res_partner.py", line 656, in _search
File "C:\Program Files (x86)\Odoo 8.0-20150522\server.\openerp\api.py", line 241, in wrapper
File "C:\Program Files (x86)\Odoo 8.0-20150522\server.\openerp\models.py", line 4638, in _search
File "C:\Program Files (x86)\Odoo 8.0-20150522\server.\openerp\api.py", line 241, in wrapper
File "C:\Program Files (x86)\Odoo 8.0-20150522\server.\openerp\models.py", line 4461, in _where_calc
File "C:\Program Files (x86)\Odoo 8.0-20150522\server.\openerp\osv\expression.py", line 646, in init
File "C:\Program Files (x86)\Odoo 8.0-20150522\server.\openerp\osv\expression.py", line 930, in parse
File "C:\Program Files (x86)\Odoo 8.0-20150522\server.\openerp\api.py", line 241, in wrapper
File "C:\Program Files (x86)\Odoo 8.0-20150522\server.\openerp\api.py", line 336, in old_api
File "C:\Program Files (x86)\Odoo 8.0-20150522\server.\openerp\models.py", line 1723, in name_search
File "C:\Program Files (x86)\Odoo 8.0-20150522\server.\openerp\api.py", line 239, in wrapper
File "C:\Program Files (x86)\Odoo 8.0-20150522\server.\openerp\api.py", line 462, in new_api
File "C:\Program Files (x86)\Odoo 8.0-20150522\server.\openerp\models.py", line 1735, in _name_search
File "C:\Program Files (x86)\Odoo 8.0-20150522\server.\openerp\api.py", line 241, in wrapper
File "C:\Program Files (x86)\Odoo 8.0-20150522\server.\openerp\models.py", line 4656, in _search
File "C:\Program Files (x86)\Odoo 8.0-20150522\server.\openerp\sql_db.py", line 158, in wrapper
File "C:\Program Files (x86)\Odoo 8.0-20150522\server.\openerp\sql_db.py", line 234, in execute
DataError: date/time field value out of range: "15"
LINE 1: ...input" WHERE ("survey_user_input"."date_create" = '15') ORDE...
^
HINT: Perhaps you need a different "datestyle" setting.

Expected behavior
I expected to be able to 'filter partners according to their answers in surveys'?

I've invited a partner to fill in a Survey.
Results is in menu marketing under Surveys but does not show in partner form.

Roadmap

• add new type of answer by @bjoliveau

For example "percent" type : one respondent is asked how to spread his activity as a percentage from a preconfigured list pending precise values. Workaround : If no requirement for precise value, it can be configured ranges of values in a list of choices.

• allow adding comment on each item for multiple choice answer
• format "date time" type to set date and time or only date or only time
• allow subquestions. Very useful with conditional_questions to loop on a page or series of questions
• allow editing or inserting Odoo blocks in website survey inside of the question-answer group and not only around or after. For example, one respondent is asked to vote about pictures selection.
• offer choice to the survey's administrator to display information from an existing object (for example : res.partner)
• extend the existing notation to finely evaluate or profile by answering and generate actions (for example : generate sale order and sale order lines depending on respondent answers)