Allright guys letz discuss!

Who creates the first PR?

If i create a tax statement with values from 2019 and select "2019" in the field version i get a statement with line formats from the version 2018.

This would be correct if we would create a tax statement for account moves from 2018, however some lines do not match the right format for 2019:

Line 51: instead of "EDITABLE_DISPLAY" -> "TOTAL_DISPLAY"
Line 52: instead of "EDITABLE_DISPLAY" -> "GROUP_DISPLAY"
Line 53: remove from "TOTAL_DISPLAY"
Line 54: instead of "GROUP_DISPLAY" -> "TAX_DISPLAY"
Line 60: remove from "TAX_DISPLAY" & add to "TOTAL_DISPLAY"
Line 62: remove from "TOTAL_DISPLAY"
Line 63: instead of "GROUP_DISPLAY" -> TAX_DISPLAY"

I assume we also needs to have format settings for both versions ("2018" and "2019").

Furthermore as we now have "version" to create the report, we should change the follwoing string (line 65-67 in l10n_de_tax_statement.py):
tax_total = fields.Monetary(
compute='_compute_tax_total',
string='Verbl. Ust.-Vorauszahlung (66 - 67)'

to

tax_total = fields.Monetary(
    compute='_compute_tax_total',
    string='Verbl. Ust.-Vorauszahlung' 

And finally due to latest source code changes the translations needs an update
(i will do that for sure)

Hello,

is there a chance / schedule to have this module / app for Odoo 16 too?
We would be very glad to hear that.
(Guess there is another way to ask that instead here as an issue..., I'm sorry but did not found it)

Best
Matthias

module: datev_export
version: 14.0

Steps to reproduce

• ...

Current behavior

Expected behavior

Create 2 date ranges 1. 2018 and 2. 2019

Generate a balance sheet report for 2019.

You will find "0410 Geschäftsausstattung" wrong value, as it contains 2018 entries as well.

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-10.0

Modules to migrate

• l10n_de_country_states - By @chienandalu - #21
• l10n_de_location_nuts - By @chienandalu - #22
• l10n_de_steuernummer - By @pedrobaeza - #23

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-9.0

Modules to migrate

• l10n_de_country_states - By @rami-wafaie - #20

File import into a journal with a code written in capital and small letters leads to error message.
For example the code of a journal is "LuG" instead of "LUG"

Module
datev_import_csv_dtvf

Describe the bug

To Reproduce
Take the example file "datev_export.csv" and download it.
Install a german localisation with l10n_de_skr03 module installed.
Put the value "248675,12" in the line 93 of the example file included in the module.
define at least one analytic account with areference "4811".
Modify the journal Miscelleanous short code: MisC
Go to Accounting > Imort DATEV Format .csv
Upload the file
Select the journal Miscelleanous
Force the date: 31.12.2022
Put a reference "test"
Click on "Run import"

Expected behavior
Import should finish and open the account move.
It will work if you change the short code of your journal to "MISC"

The error message is:

List of journal codes that doesn't exist in Odoo:

• MisC line(s): 3,4,5 ....
  all lines are mentioned.

In my example the short code of the journal was "LuG" (mentioned in the error message)

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-14.0

Modules to migrate

Missing module? Check https://github.com/OCA/maintainer-tools/wiki/%5BFAQ%5D-Missing-modules-in-migration-issue-list

Module

All modules

Describe the bug

Pre-commit fails on flake8 with the following error.

Traceback (most recent call last):
  File "/home/runner/.cache/pre-commit/repoavke92vx/py_env-python3/bin/flake8", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/home/runner/.cache/pre-commit/repoavke92vx/py_env-python3/lib/python3.12/site-packages/flake8/main/cli.py", line 22, in main
    app.run(argv)
  File "/home/runner/.cache/pre-commit/repoavke92vx/py_env-python3/lib/python3.12/site-packages/flake8/main/application.py", line 363, in run
    self._run(argv)
  File "/home/runner/.cache/pre-commit/repoavke92vx/py_env-python3/lib/python3.12/site-packages/flake8/main/application.py", line 350, in _run
    self.initialize(argv)
  File "/home/runner/.cache/pre-commit/repoavke92vx/py_env-python3/lib/python3.12/site-packages/flake8/main/application.py", line 330, in initialize
    self.find_plugins(config_finder)
  File "/home/runner/.cache/pre-commit/repoavke92vx/py_env-python3/lib/python3.12/site-packages/flake8/main/application.py", line 153, in find_plugins
    self.check_plugins = plugin_manager.Checkers(local_plugins.extension)
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/.cache/pre-commit/repoavke92vx/py_env-python3/lib/python3.12/site-packages/flake8/plugins/manager.py", line 356, in __init__
    self.manager = PluginManager(
                   ^^^^^^^^^^^^^^
  File "/home/runner/.cache/pre-commit/repoavke92vx/py_env-python3/lib/python3.12/site-packages/flake8/plugins/manager.py", line 238, in __init__
    self._load_entrypoint_plugins()
  File "/home/runner/.cache/pre-commit/repoavke92vx/py_env-python3/lib/python3.12/site-packages/flake8/plugins/manager.py", line 254, in _load_entrypoint_plugins
    eps = importlib_metadata.entry_points().get(self.namespace, ())
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'EntryPoints' object has no attribute 'get'

To Reproduce

Affected versions: 15.0

Steps to reproduce the behavior:

1. Submit any pull request to the 15 branch.

Expected behavior
flake8 should not give this bug.

Additional context
Pre-commit seems to work with Python 3.12. I have had this give me problems in the past. Perhaps it should be working with 3.10 instead?

https://github.com/OCA/l10n-germany/blob/7.0/l10n_de_country_states/i18n/l10n_de_country_states.po should be
l10n_de_country_states.pot

module: l10n_de_tax_statement
version: 12.0

Steps to reproduce

• Read README.rst and rely on the description there

Current behavior
There is no "Invoicing" (was that the name of the higher-level app in Odoo 11?), only "Accounting".
Though the module says it is installed, I can't find the menu entries it's supposed to insert.

Expected behavior
Find new menu entry at Accounting -> Reporting > Germany > German Tax Statement (USt VA / Umsatzsteuervoranmeldung), where l10n_de_skr04_reports used to put its menu entry.

Edit: Okay, a few reloads later I did find the new entries at Accounting -> Reporting -> Taxes Balance -> Taxes Balance and Ust-Voranmeldung (which should be German Tax Statement when in English), and at Accounting -> Configuration > Accounting > German Tax Tags. I can now get data out of Taxes Balance that looks good, but Ust-Voranmeldung tosses everything into Code 21. This is no improvement to the l10n_de_reports Umsatzsteuervoranmeldung, which does exactly the same. Does this module here even improve anything or is it just duplicate content made obsolete by v12?

"Odoo Community Association (OCA)" add author to l10n_de_country_states

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-15.0

Modules to migrate

• l10n_de_country_states
• l10n_de_holidays
• l10n_de_location_nuts
• l10n_de_skr03_mis_reports
• l10n_de_skr04_mis_reports
• l10n_de_steuernummer
• l10n_de_toponyms

Missing module? Check https://github.com/OCA/maintainer-tools/wiki/%5BFAQ%5D-Missing-modules-in-migration-issue-list

I installed this plugin from the Apps menu and I tried to create an invoice with different taxes, but I got this error message:

Account Erlöse 19% USt does not authorize to have tax 7% Umsatzsteuer specified on the line. Change the tax used in this invoice or remove all taxes from the account

After uninstalling the module I was able to create invoices with taxes. I couldn't find where this error comes from.
I am using Odoo v12.

As I already wrote, the german company need two tax numders.
St.-Nr. eg. 21/815/08150 and Steuer-IdNr. eg. DE123456789
The module l10n_de_steuernummer dose not help in this case, because we need two fields for two kinds of the VAT in Germany.

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0

Modules to migrate

Missing module? Check https://github.com/OCA/maintainer-tools/wiki/%5BFAQ%5D-Missing-modules-in-migration-issue-list

File import with semicolon as field seperator leads to an error message

Module

datev_import_csv_dtvf

Describe the bug

Import of a file with filed separator "," works.
With separator ";" i get an error.

To Reproduce

Take the example file "datev_export.csv" and download it.
Install a german localisation with l10n_de_skr03 module installed.
Put the value "248675,12" in the line 93 of the example file included in the module.
define at least one analytic account with areference "4811".
Save it with field separator ";"
Go to Accounting > Imort DATEV Format .csv
Upload the file
Select the journal Miscelleanous
Force the date: 31.12.2022
Put a reference "test"
Click on "Run import"

Expected behavior
Import should finish and open the account move
The error message is:

File "/opt/odoo/build/odoo/odoo/api.py", line 448, in _call_kw_multi
result = method(recs, *args, **kwargs)
File "/opt/odoo/build/addons/datev_import_csv_dtvf/wizard/import_move.py", line 55, in run_import
pivot = self.genericcsv2pivot(fileobj)
File "/opt/odoo/build/addons/datev_import_csv_dtvf/wizard/import_move.py", line 176, in genericcsv2pivot
date_str = l["date"][0:2] + "/" + l["date"][-2:] + "/" + year_str
TypeError: 'NoneType' object is not subscriptable

module: l10n_de_country_states
version: 12.0

Steps to reproduce
Contacts-> States -> Search for "Baden"

Current behavior
Baden-Wurttemberg

Expected behavior
Baden-Württemberg or at leat Baden-Wuerttemberg

Is the core-addon ln10_de with the german accounting part of this initiative?

Would it make sense to add it here?

We have two issues:
1.) With a partial deduction of a down-payment (f.e. 80%) we get a DATEV Export XML exception.
2.) With a 100% deduction of a down-payment the export doesn't include this invoice.

Module

datev_export_xml

Describe the bug

I have created a document to describe the test case:
DATEV-Export-XML-down-payment_issue.odt

To Reproduce

Follow the steps described in the attached document.

Steps to reproduce the behavior:
Case a. - partially down-payment

1. Create a sale order
2. Create a down-payment invoice (80%)
3. Create a final invoice and deduct the down-payment
4. Create a DATEV export for Customer Invoices (same period as final invoice)

Case b. - 100% down payment deduction in final invoice

1. Create a sale order
2. Create a down-payment invoice (100%)
3. Create a final invoice and deduct the down-payment
4. Create a DATEV export for Customer Invoices (same period as final invoice)

Case a:) DATEV Export xml exception error
Case b.) Invoice is not included in the export

Expected behavior
Case a.) No datev exception error
Case b.) invoice should be in the export

Additional context
I have recorded a video:
https://drive.google.com/file/d/1dLa75E0y6f90avXNOB3HUa5PltX2CYHA/view

The topic "Nullrechnungen" is also a matter of discussion in the DATEV community.
https://www.datev-community.de/t5/Betriebliches-Rechnungswesen/quot-Nullrechnung-quot/td-p/51144#_=_

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-11.0

Modules to migrate

• l10n_de_country_states - By @rami-wafaie - #29
• l10n_de_location_nuts - By @rami-wafaie - #30
• l10n_de_steuernummer - By @rami-wafaie - #31

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-12.0

Modules to migrate

• l10n_de_country_states - By @Tardo - #46
• l10n_de_location_nuts - By @Tardo - #47
• l10n_de_steuernummer - By @tbaden - #48
• l10n_de_tax_statement
• 10n_de_tax_statement_zm

l10n_de_holidays
l10n_de_skr03_mis_reports : WIP: #57
l10n_de_skr04_mis_reports : #64
l10n_de_toponyms

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-13.0

Modules to migrate

• l10n_de_country_states
• l10n_de_location_nuts
• l10n_de_steuernummer
• l10n_de_tax_statement

Missing module? Check https://github.com/OCA/maintainer-tools/wiki/%5BFAQ%5D-Missing-modules-in-migration-issue-list

After Germany temporarily lowered the VAT from 19% / 7% to 16% / 5%, I noticed that the sign at column tax in line 35 is wrong. The same should probably also apply to line 36, since the taxes were not calculated by percentage in the "_finalize_lines_2019" method.

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0

Modules to migrate

• datev_import_csv_dtvf

Missing module? Check https://github.com/OCA/maintainer-tools/wiki/%5BFAQ%5D-Missing-modules-in-migration-issue-list