obsidian-community / obsidian-pandoc Goto Github PK
View Code? Open in Web Editor NEWThis project forked from oliverbalfour/obsidian-pandoc
Pandoc document export plugin for Obsidian (https://obsidian.md)
License: MIT License
This project forked from oliverbalfour/obsidian-pandoc
Pandoc document export plugin for Obsidian (https://obsidian.md)
License: MIT License
I think I found a quite bad bug, but I want other eyes on it to verify.
There is a setting in the plugin that allows the user to input their own custom path for pdflatex, in case it's not accessible on the user's PATH.
The code that spawns the pandoc process tries to use this path in the following way:
process.env
object:Line 149 in c8cf21a
env
object with that new path: Line 159 in c8cf21a
process.env
anyway: Line 161 in c8cf21a
So the custom pdflatex path is actually never used, and the only way this plugin can ever generate pdfs is if pdflatex actually is on the user's PATH.
I think the fix is simply to change line 161 to:
pandoc = spawn(input.pandoc || 'pandoc', args, { env: env });
Thoughts?
perhaps it's the unicode used..
![[๐ฉ - โ
Yoshi]]
renders as [[๐ฉ - โ Yoshi]]
The standard Export to PDF doesn't have this issue. But it seems like all of the Pandoc plugins fail at this. I was hoping to be able to export to Docx due to business needs.
When the plugin checks for features one of the checks is does is whether the target output type needs pdflatex to run. That check is exactly:
Lines 74 to 76 in c8cf21a
In other words, the plugin will not generate any pdfs unless pdflatex is also installed.
I suspect this is wrong and that many pdfs can be generated without pdflatex, but I don't know the details and might be wrong.
If I'm not wrong, I'm not sure how to fix it. We need a way to detect whether a particular file needs pdflatex to convert, but I don't know what that check would look like.
The fork here is a little confusing. I understand why it exists, but is this codebase now where the Community plugins UI is pulling from, or do I need to manually install this version?
I think if this switch is happening, it should probably fully happen, ie. the community plugins should point to this repo, the readme links should be updated to point here instead of at the old repo, etc.
If this is welcome I can probably do this myself and submit a PR, but I want to coordinate about it first.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.