observer999 / geocoordconversion Goto Github PK

This code introduces errors when coordinates are converted.

This code was converted from javascript originally (see project credits).
However, some of the expressions have not been converted correctly.

In javascript:
5/4 = 1.25

In C#:
5/4 = 1
since C# has two different operators for divide depending upon whether it is 
operating on integers or non-integers.

Where division on literal integers is performed in C#, the literals must be 
converted to doubles via cast or otherwise, e.g.
5d/4d = 1.25

What steps will reproduce the problem?
1. Convert as GPS longitude with only 4 places after the decimal
2. Add 0.00000001 to the above latitude and try again (works)
3. Exact figures I used are: Lat: 51.59405969 Lon: -2.9867

What is the expected output? What do you see instead?

I do not know what the expected output is. I do know that it is incorrect - see 
attached data file.

What version of the product are you using? On what operating system?

"1.0.1.0"

Please provide any additional information below.

It appears to be somewhere in the 'AlignSigFigs' method of class 
'GridReference'.

It is fairly rare (I had one instance when converting a GPS trace of 11000+ 
points) - most GPS co-ordinates have 6 or more digits after the decimal point.

I only noticed it when I created a 3d line-string, in Bentley Microstation, 
base on a GPS trace of a rail train journey. The train suddenly shifts sideways 
by 1.5 meters (i.e. jumped off the rails).

I have attached the data I was working on as tab separated text file.
Load this into Excel and examine rows 830 to 834 column D-East.

As a by and by why are you using the 'AlignSigFigs' function?

Regards

Nigel Hatchett

Software Consultant
Aristoline Limited

What steps will reproduce the problem?
1.Import the assembly into SQL Server

What is the expected output? What do you see instead?
Function should import in safe mode but SQL Server complains that static 
functions need to be set as readonly

Modified code attached.