oblivioncloudcontrol / xebia-email-signature Goto Github PK

View Code? Open in Web Editor NEW

0.0 0.0 4.0 1.66 MB

Xebia e-mail signature generator

Dockerfile 0.30% Python 50.20% Makefile 1.15% HTML 20.63% Jinja 11.41% CSS 6.24% JavaScript 10.07%

xebia-email-signature's People

Contributors

Watchers

Forkers

cloudcosmonaut xpiritbv myciek jorgegalindocruces jessehouwing

xebia-email-signature's Issues

2 call to action links have different font size

See below:

When sent from Nine for Android.

consider allowing other social accounts

With x being controversial nowadays, any chance we could allow other options?

Mastadon
stackoverflow
GitHub profile

Error while running the container

Get the following error when running the container via cli after I filled in all the fields:

Traceback (most recent call last):
  File "/usr/local/bin/xebia-signature-cli", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.9/site-packages/xebia_email_signature/signature.py", line 374, in main
    employee_details = add_formatted_phone(employee_details)
  File "/usr/local/lib/python3.9/site-packages/xebia_email_signature/signature.py", line 106, in add_formatted_phone
    result = {k: v for k, v in contact_details.items()}
AttributeError: 'NoneType' object has no attribute 'items'

I do not experience this issue when I run the container via the web client.

add proper phone url around phone number

My mail client turns sequences of numbers into phone links, but due to the space the whole number isn't converted.

Best way to solve this is to make the phone number a link be default using the call to handler.

<a href="callto:+31641813338">+316 41813338</a>

use an embedded image for the xebia logo

BTW, I like to base64 the images on the html, that way email clients don't block external images (as now the images are hosted). That would be an easy addition to the page.

(curl https://assets.oblcc.com/xebia/xebia.png | base64 | pbcopy to get the image in base64,
that you can then put in an html like so

<img width="155" height="55" id="Xebia" src="data:img/png;base64,BASE64_IMAGE_HERE" />

)
This of course makes your signature several KBs, so you can actually use the Xebia logo in SVG format

<img width="155" height="55" id="Xebia" src="data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZpZXdCb3g9IjAgMCA2MTIgMjAyLjQiPgogIDxnPgogICAgPGc+CiAgICAgIDxwYXRoIGQ9Ik0yOTYuNSw5Mi44SDIzOS40QTI4LjkxLDI4LjkxLDAsMCwxLDI2Nyw3MS40YzE1LjQsMCwyNS42LDcuNiwyOS41LDIxLjRtLTU3LjQsMTkuNmg4My44di01LjNjMC0xMy44LTMuMi0yNC45LTkuNy0zNC4zLTExLjEtMTQuNy0yNy42LTIzLjctNDUuNC0yMy43LTE0LjMsMC0yOC4xLDYuMi0zOC43LDE3LjMtOS43LDEwLjMtMTQuNywyMy4yLTE0LjcsMzcuOEE1Nyw1NywwLDAsMCwyMzAsMTQyLjZjMTAuOCwxMC44LDIzLjcsMTYuMSwzOS4zLDE2LjEsMjMuMiwwLDQxLjYtMTIuOSw1MC40LTM1LjdIMjkzLjRjLTUsOC41LTE0LjMsMTIuOS0yNC45LDEyLjktMTcuMS42LTI4LjItOC44LTI5LjQtMjMuNSIgc3R5bGU9ImZpbGw6ICM2YzFkNWYiLz4KICAgICAgPHBhdGggZD0iTTM2MC43LDEwNS4yYzAtMTcuOSwxMi45LTMxLjMsMjkuOS0zMS4zUzQyMSw4OC4yLDQyMSwxMDQuN2MwLDE3LjMtMTIuOSwzMC44LTMxLjcsMzAuOC0xNS4xLjEtMjguNi0xMy4zLTI4LjYtMzAuM20tLjktNDQuNlYxOC43aC0yNFYxNTdoMjR2LTguNWE1MC40NSw1MC40NSwwLDAsMCwzMi41LDExLjEsNTMuMzgsNTMuMzgsMCwwLDAsMzQuMy0xMiw1Niw1NiwwLDAsMCwxOS42LTQyLjhjMC0xNS4yLTYuMi0zMC40LTE3LjktNDAuNy05LjctOS40LTIyLjMtMTMuOC0zNi4xLTEzLjgtMTIuNy0uMy0yMywyLjctMzIuNCwxMC4zIiBzdHlsZT0iZmlsbDogIzZjMWQ1ZiIvPgogICAgICA8cGF0aCBkPSJNNDYyLjksNTIuN2gyMy4yVjE1N0g0NjIuOVptMC0zNGgyMy4yVjQxLjlINDYyLjlaIiBzdHlsZT0iZmlsbDogIzZjMWQ1ZiIvPgogICAgICA8cGF0aCBkPSJNNTI2LjgsMTAzLjRhMjkuNiwyOS42LDAsMCwxLDI5LjktMjkuOWMxNS4yLDAsMjkuNCwxMy40LDI5LjQsMzEuMywwLDE2LjEtMTMuOCwyOS45LTI5LDI5LjktMTYuNSwwLTMwLjMtMTIuOS0zMC4zLTMxLjNtNjIsNTMuNkg2MTJWNTIuN0g1ODguOFY2NS4yQzU4MS43LDU0LjksNTcwLjksNTAsNTU1LjcsNTBjLTE1LjYsMC0yOC4xLDUtMzguNywxNi4xLTkuNywxMC4zLTE0LjcsMjMuNy0xNC43LDM4LjQsMCwzMS4zLDIzLjIsNTQuOCw1My45LDU0LjgsMTYuMSwwLDI2LjctNC40LDMyLjUtMTUuMmwuMSwxMi45WiIgc3R5bGU9ImZpbGw6ICM2YzFkNWYiLz4KICAgIDwvZz4KICAgIDxwb2x5Z29uIHBvaW50cz0iMC45IDIwMi40IDY0LjUgMjAyLjQgMTMzLjMgMTMzLjggMjAxLjkgMjAyLjQgMjY2LjMgMjAyLjQgMTY1LjUgMTAxLjYgMjY3LjIgMCAyMDIuOCAwIDEzMy4zIDY5LjYgNjQuMiAwIDAgMCAxMDEuMSAxMDEuNiAwLjkgMjAyLjQiIHN0eWxlPSJmaWxsOiAjNmMxZDVmIi8+CiAgPC9nPgo8L3N2Zz4K" alt="Xebia"  name="Xebia" />

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.