Rule 9 misinterpreted about phpcs-calisthenics-rules HOT 5 CLOSED

Hi @mihaeu,

thanks for pointing that out. I see the missing "No", is that what you mean?

Personally I mostly agree with referenced article in the one you referenced - No setters allowed: http://whitewashing.de/2012/08/22/building_an_object_model__no_setters_allowed.html
I use that it practice already.

What changes you suggest? Step by step the best.

from phpcs-calisthenics-rules.

• public properties should not be allowed
• method definitions named setX should not be allowed
• method definitions named getX should not be allowed OPTIONAL
• I don't know how much information you have available, but if it's like an AST you can also check for setter logic (is method a one-liner? does it assign the provided value to an internal attribute)

from phpcs-calisthenics-rules.

Thanks for elaboration and clear points! It's very easy to read.

I would start with small steps.

1. Agree. It is already implemented
2. Agree. Could prepare PR for this? Would be happy to help you.

I would keep 3. and 4. to discuss after 2. is closed.

from phpcs-calisthenics-rules.

I think this can be closed, as 1. and 2. are implemented in #32

3. seems to strict and useless in practice.

from phpcs-calisthenics-rules.

Related to last comment, closing for now.

from phpcs-calisthenics-rules.