Only one level ? And what abouht try catch ? about phpcs-calisthenics-rules HOT 6 CLOSED

Hi @OXman, thanks for the feedback.

Your code could be refactored neatly to this:

public function addLinkBetweenOauthClientAndUserFromIds($oauthClientId, $userId)
{
    try {
        return $this->processOauthClientAndUser(...);
    } catch (Exception $exception) {
        $this->logger->error(...);
        return false;
    }
}

The goal if this rule is to keep code as much as readable, so making exception for nesting might allow to write more and more nested code.

On the other hand, do you imagine any other situation to make exception for?

Would you prepare a PR for this?

from phpcs-calisthenics-rules.

Ofc i can refactor like that. But this method will be very specialized and only used in this case. So i think we shouldn't do that.

from phpcs-calisthenics-rules.

I see. So...

On the other hand, do you imagine any other situation to make exception for?

Would you prepare a PR for this?

from phpcs-calisthenics-rules.

I said only one level exception for "try catch", nothing else.
So the max level will be 2 (instead of 1) and only if one of the both level is a try catch.

I don't want make a PR about this, for the moment i only want your opinion.

from phpcs-calisthenics-rules.

I agree.

from phpcs-calisthenics-rules.

Duplicate to #40, closing

from phpcs-calisthenics-rules.