oasisdex / eth2dai Goto Github PK

Not sure if I should create this issue here or in MetaMask's github repo, but I've noticed lately that many of my transactions (to send a "average/kill" order type) end up being dropped (https://etherscancom.freshdesk.com/support/solutions/articles/35000083267-transaction-dropped-). I assume it is because of low gas configured by default by Metamask.

When sending ETH or a Token, there's a new UI in metamask to choose between 3 types of network fees: low, medium, and high. However, this UI doesn't appear when doing contract interactions, such as when placing an order in eth2dai. And the "speed-up" option to increase the fee of an already-sent transaction is not working for me, because the button "Save" remains as disabled no matter what increase I choose.

Trading interface would not load. Opened dev tools in chrome. Screenshot and headers pasted below:

Request URL: https://eth2dai.com/exchange/WETH/DAI
Request Method: GET
Status Code: 404
Remote Address: [2606:4700:30::6812:271f]:443
Referrer Policy: no-referrer-when-downgrade
access-control-allow-origin: *
age: 1688
cf-ray: 4ba8bd495ba6b5d8-MEM
content-encoding: br
content-type: text/html; charset=utf-8
date: Wed, 20 Mar 2019 15:32:32 GMT
expect-ct: max-age=604800, report-uri="https://report-uri.cloudflare.com/cdn-cgi/beacon/expect-ct"
server: cloudflare
status: 404
vary: Accept-Encoding
via: 1.1 varnish
x-cache: HIT
x-cache-hits: 2
x-fastly-request-id: c1d84edc5b247446badbb8541bde8d74d061bc5a
x-github-request-id: F2B4:448A:2D8AAD:3BEACC:5C925678
x-served-by: cache-atl6235-ATL
x-timer: S1553095953.873921,VS0,VE0
:authority: eth2dai.com
:method: GET
:path: /exchange/WETH/DAI
:scheme: https
accept: text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,/;q=0.8
accept-encoding: gzip, deflate, br
accept-language: en-US,en;q=0.9,es;q=0.8,la;q=0.7
cache-control: max-age=0
cookie: __cfduid=d7a9c09ac3d7979cd1717031ad0ca734a1552335815
upgrade-insecure-requests: 1
user-agent: Mozilla/5.0 (Linux; Android 5.0; SM-G900P Build/LRX21T) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/72.0.3626.121 Mobile Safari/537.36

Hi guys,

I have an issue with a contract not paying out. DAI paid in, no WETH paid out.

The transaction is approved with 100's of block confirmations.

Is it possible for someone to take a look at the issue and get my account credited correctly? If so please can you give me a private channel to discuss in more detail.

Thanks in advance.

We are a wallet which wants to connect to this dapp. But the landing page only supports serveral wallets.
Could you please update the code to support all wallets?

See #80

@krzkaczor The chart needs to be fixed, it poorly communicates the action in the market. When the candle wick pops up it makes it look like all the orders were cleared up to that point... obviously this isn't a simple fix, but maybe there could be a way to not reflect low volume cherry picked trades on the chart, but leave them in the tx list?

Much love,
Griff

It is always ETH/DAI.

This project is really amazing.

I'd like to know how to add new tokens. I took a look in the file src\blockchain\config But I couldn't understand it well. Thanks a lot.

And btw

GREAT INTERFACE!! Super easy to use! And u love the "lock/unlock" idea.. it makes a lot more sense than "approve"

Great work as always guys ;-)

I'm not actually sure what "unlocking" does, except that the frontend tells me I must do it in order to trade. I have 0.5 WETH in my metamask wallet, and when I hit the "unlock" toggle I get a popup that looks like this:

Not totally sure where to go from here, am happy to provide any other debug info you need.

Hello, awesome project but

Plz add some FAQ pages,
For example:

• difference between locked and unlocked (dai/eth)
• weth vs eth

Hi, could you look into https://walletconnect.org/ and consider implementing it?

I'd like to use my mobile wallet (Trust) from my laptop, this gives me a more user friendly ui. Trust supports WalletConnect, but it needs to be supported as Wallet in the DApp.

Thanks in advance.

I'm a regular user of eth2dai.com and had never any problems with it, until today.
I was selling WETH for DAI, and the first transaction went well:

https://etherscan.io/tx/0x0ab8f8be20b698360f0d81384ffc0bfc2687977c8f02fffbcfc7ce13134b2089

(Using the "Average price fill or kill order type" with a slippage limit of 5%.)

However, I did a second trade to sell the rest of my WETH, and the DAI never came back! The transaction was:

https://etherscan.io/tx/0xf36b80d352a5cc8576a474d6a18e8a7bbf7eae78ae8a6bcda3317f86458398b4

At first I was scared that there was some bug regarding the "atomicity" of the smart contract, but in the end what had happened is that I had sent a limit order instead of an "average or kill" one (once I canceled the order, I got my WETH back). So then I'm sure there's a bug somewhere in the UI that changed the order type automatically back to the default.