oashour / nonlinearschrodinger.jl Goto Github PK

Helper functions and utilities/QoL changes should include:

1. A way to set the number of x nodes directly in Box, instead of being forced to set dx, which doesn't make too much sense for DT.

2. Extend the function compute_params to compute all the relevant parameters as currently done in the constructor of calc. This will add modularity and make life easier for other functions.

1. A function to calculate the maximal intensity family given lambda or m. It should return an array of eigenvalues, as well as the relevant shift arrays (maybe, just zeros basically).

2. Function to generate DT based initial condition for simulations

3. Function to generate DT based cosine-series initial condition for simulations

Similar to the save_at flag from DifferentialEquations.jl

Currently the code is poorly written in a way that uses Float64 or Complex{Float64}. This should be changed to use abstract types. This happens in both function arguments as well as when allocating arrays such as in init_sim.

compute_spectrum which computes the FFT and FFTshifts is very slow. For calculations with lower order integrators and small number of Fourier nodes, compute_spectrum often takes twice as long as the simulation itself. Enabling multi threading for FFTW before computing this FFT improves performance by a factor of 2, but I am not sure if there is much to be done about it. The best option might be to compete the FFT somehow during the main solver loop itself, this is likely a better option than doing the whole thing at once later on.

The documentation compiles fine and looks good locally, but is not deployed on github and no gh_pages branch is created.

Modules are currently a little messy, as well as the exports. This needs to be cleaned up before starting work on the Darboux section of the package.

This is likely due to the fact that they have very small differences in numbers which might be causing issues with either GR or Plots.jl. I am not sure what the fix is but this is worth looking into. There is some fuzziness in the lines themselves, indicating some numerical noise.

Switching to the plot in the VSCode plot pane is also extremely slow.

This issue is used to trigger TagBot; feel free to unsubscribe.

If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.

If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!