oakch / scheduler Goto Github PK

The page (/admin/calendar) should still load even if there are no units, so that controller code should be able to handle the case.

Rules logic prevents adding a day to the segment for nurse 1 (the nurse 1 after one runs: rake db:reset_and_seed). The error I get is: "Max day You have selected a day that has no more availability"

Need to remove hard coded year value and dates based around Time.now

from may -> april, for example

application.html.haml needs flash[:notice] and flash[:error] for use by the rest of the application.

For ordering purposes. rx recommended it?? idk if it's actually necessary at this stage.

sheel: It's a pretty easy fix with the code we have, just throw in a .sort before the .each and the ordering will always be the same.

The page crashes when params[:admin][:unit] is either nil or contains an id that does not correspond to an actual unit. Similarly, a check for the shift validity is also probably necessary to make sure that params[:admin][:shift] is one of Unit.shifts.

I think it's because at the beginning of upload, you initialize flash[:error] to an empty array. Basically, you are:

1. setting flash[:error] to an empty array
2. adding error messages to flash[:error]
3. redirecting
4. setting flash[:error] to an empty array upon redirect

so the flash[:error] is always an empty array.

a fix I did was getting rid of flash[:error] = [] and instead checking to see if flash[:error] existed every time you added an error message. I think this method isn't very DRY so you're probably better off thinking of another solution.

Steps: add in a new vacation. Try to edit either by using the list on the bottom or by clicking the event in the calendar. It would not let me edit, but I am still able to edit my first vacation segment

nurse_view_calendar.feature

Convert to SASS would be great too.

I think it's because %option{:value => u.id} #{u.name} needs a ":selected => s == @Unit" like we do in shift.

@christinelu to fix after finals

Risk 1

line 50 event = Event.new(params[:event]) because of mass assignment w/out attr accessible.

Risk 2

potentially malicious - not sure:
line 10 @event_strips = Event.event_strips_for_month(@shown_month, :include => :nurse, :conditions => "nurses.unit_id = #{@unit_id} and nurses.shift = '#{@shift}'")
UPDATE: rx says potentially malicious; change it to the '?' notation

Once we have a notion of time, we need to ensure that events are not scheduled in the past (say 1990) or on a date years down the road (say 2022). Right now, it is possible to do both those things.

Admin upload page needs instructions that include:

• Files can be xls or xlsx
• There must be a header row
• Which columns are required (found through Nurse.required_columns)
• Which columns can be optionally included (found through Nurse.optional_columns)
• Columns can be in any order
• Additional columns that are included will be ignored

Perhaps this could be a popup with a link for instructions as to not clutter the page? Or a link to another page? Or maybe just on the same page?

probably better if we did MM/DD/YYYY?

either all unit, then shift or shift, then unit

Upload instructions should include the fact that "years worked" is an optional column.

Or specify that admins should resubmit finalize for each new year

After deleting a vacation segment, the calendar controller will default back to the current month/year instead of the month/year that was being viewed. There are other examples of the same behavior such as when clicking edit vacation segment and then clicking back to calendar.

• a few others in calendar_controller.rb

User email has already been taken
Email has already been taken

can we consolidate?

If a nurse is logged in, only that nurse's name should up in the strips.

The roo gem currently only works on local machines, needs to be able to function on Heroku.

Cases such as when user input is invalid. These cases should probably go along with some RSpec tests.

Currently, an admin who clicks on a particular nurse or vacation has no link to get back to the admin calendar index that they start on. Links should be added on all the calendar pages an admin can reach to get back to start.

= form_tag "/nurse/#{@nurse_id}/calendar/#{@id}", :method => :put do

should use a form helper.