nzeemin / mk90btl Goto Github PK

https://github.com/nzeemin/mk90btl/blob/72a988ed6cea3d918a73e1ed3bddfbec2302b8fe/emulator/emubase/Board.cpp#L151C1-L155C6

Max. size of 10240 bytes for a volume image is wrong since MK90’s build-in BASIC system can read volumes up to 64 Kb, as it was reported here: link.

You can use my test images from the following repo to test this out: link. Actually I’ve build the emulator from the source code without this check and it worked just fine with the v.1.0 test volume.

Even more, cartridges with binary code (the ones that are not supposed to be compatible with the build-in BASIC) can be even larger. E.g. the official cartridge for the v.2.0 systems is 196 Kb. And the modern Bad Apple!! demo is 783 Kb!

So please consider to correct this value.

On a side note, the minimum size should be checked. I think a correct volume should be at least 512 bytes (which is the bootloader’s size).