nyngwang / neozoom.lua Goto Github PK

Hello @nyngwang . Hope you're doing well. Thank you for creating such a handy and awesome plugin.

This plugin works perfectly on normal buffers. However, I'm trying to zoom in on the pane created by nvim-pack/nvim-spectre and it doesn't work:

The left side is created by the cmd :Spectre.

To reproduce:

1. open a normal file buffer
2. :Spectre to start find and replace by Spectre
3. On the Spectre pane, trigger zoom-in (<C-w>m)
4. Nothing

Does it mean that NeoZoom only works on "normal file buffers"? I'm not asking to have NeoZoom support specfically for Spectre; just trying to understand if it's a bug or a limitation of NeoZoom. dhruvasagar/vim-zoom works on Spectre pane but it creates extra buffers when closing.

Config:

NeoZoom.lua:

neo_zoom.setup({
  left_ratio = 0.0,
  top_ratio = 0.0,
  width_ratio = 1.0,
  height_ratio = 1.0,
  border = "double",
})

local noref_noerr_trunc = { noremap = true, silent = true, nowait = true }
vim.keymap.set("n", "<C-w>m", function()
  vim.cmd("NeoZoomToggle")
end, noref_noerr_trunc)

OS: Linux
NVIM v0.7.0
Build type: Release
LuaJIT 2.1.0-beta3

Any input is much appreciated. Thank you:)

How to reproduce:

Open two splits (to enable zoom-in), zoom-in, open a buffer that's not already present, this is the only split (so zoom-out enable), zoom-out, error message shown.

Solution:

Should be easy to resolve: cycle through all windows again before restoring the cursor pos. that causes the bug.

If you have 2 tabs and activate NeoZoom in the 1st tab without any splits, then the 1st tab just closes and switches to the second tab.

The expected behavior would be to do nothing.

As the title says, :q gives an error when called in a zoom

Error detected while processing WinEnter Autocommands for "*":
Error executing lua callback: ...nvim/site/pack/packer/start/NeoZoom.lua/lua/neo-zoom.lua:92: Invalid window id: 1003
stack traceback:
        [C]: in function 'nvim_win_get_buf'
        ...nvim/site/pack/packer/start/NeoZoom.lua/lua/neo-zoom.lua:92: in function <...nvim/site/pack/packer/start/NeoZoom.lua/lua/neo-zoom.lua:87>

This might make sense, but the muscle memory of calling :q to close something is quite hard to get rid off.

So I can have a zoom-in window on each tab.

Then we don't need to create a keymap to do this. The UX of this is very good, too.

Ref: https://github.com/tamton-aquib/flirt.nvim

That is: be able to zoom-in those little windows easily.

Problem

When creating a new split the original one will be located on the right. The current behaviour is that NeoZoom will zoom-out on this split.

Expected

NeoZoom should zoom-out on the right split instead.

In #8 I create a map that uses window handles as its keys. This is not good: users may consider two windows with the same buffer (apparently) to be the same.

It would be helpful to have an indicator of a zoomed in pane, lest we forget. One way to integrate is like so:

https://github.com/nvim-lualine/lualine.nvim#lua-expressions-as-lualine-component

I've installed the plugin using packer and run :NeoZoomToggle

Adding filetypes to be excluded during setup doesn't work because

  M.exclude_filetypes = opt.exclude_filetypes ~= nil and
    _add_table(opt.exclude_filetypes, { 'fzf', 'qf', 'dashboard' }) or { 'fzf', 'qf', 'dashboard' }

_add_table has no return value meaning the left side of the OR always fails.

The video on the github page shows the capability of zooming the current buffer from a pane, and when the zoomed window is closed, you go back to the current buffer in the same pane.

I can't figure out how to set this up. I just use the defaults, and when I zoom a buffer, the buffer is closed in the pane I zoomed from. So, I zoom, do some editing, then close the zoom (:q) and now the pane I came from is empty.

How do I fix this?

Idea

Sometimes we might just want to use the plain-old :tabnew. But then it will not be traced by NeoZoom. So here is an idea: also detect these orphans when running : NeoZoomToggle on any window of that tab, and use the previous tab as its parent.

Some issues here

• How to define the previous tab?
• What if this orphan tab might have many windows already?

I have this error with de0e27a3e619ed3f79232ba8daf0ae1a8e92bfea changeset on Neovim version 0.7.2:

packer.nvim: Error running config for NeoZoom.lua: ...nvim/site/pack/packer/start/NeoZoom.lua/lua/neo-zoom.lua:29: attempt to index local 'opt' (a nil value)

I wounder if this is an error of my part or a ZeoZoom.lua bug 🤔

Based on the README and some quick testing. This plugin seems to be based around working with the tabline. But I found a niche problem if a user such as my self does not use the :tab feature but instead relies on some bufferline plugin.

If for some reason the bufferline is not loaded at startup but is instead lazy loaded on some module call or editor event. Then if one where to create splits with the NeoSplit or NeoVsplit commands. Then upon invoking NeoZoomToggle the bufferline breaks as the tabline appears. Not until the bufferline plugin gets loaded do things come back to normal

This does not happens if splits are created normally, and only use NeoZoomToggle or if the bufferline plugins is loaded before any call to NeoSplit or NeoVsplit

I know is a very edge case issue, but I thought it would be good to report it

When zooming in or out of any buffer I get the following error. After zooming back out once I only get the error when zooming in. Looks like getting the scrolloff isn't working right:

https://github.com/nyngwang/NeoZoom.lua/blob/main/lua/neo-zoom.lua#L9

E5108: Error executing lua vim/_meta.lua:170: Value for option 'scrolloff' is out of range
stack traceback:
        [C]: in function 'nvim_set_option'
        vim/_meta.lua:170: in function 'set_scoped_option'
        vim/_meta.lua:682: in function '_set'
        vim/_meta.lua:724: in function '__newindex'
        ...nvim/site/pack/packer/start/NeoZoom.lua/lua/neo-zoom.lua:12: in function 'pin_to_80_percent_height'
        ...nvim/site/pack/packer/start/NeoZoom.lua/lua/neo-zoom.lua:45: in function 'maximize_current_split'
        [string ":lua"]:1: in main chunk

My config:

vim.opt.scrolloff = 5

need to check that that buffer id is valid

Hi!
I have the following mapping to close floating windows with q but to toggle neozoom if the floating window is zoomed:

u.keymap('n', 'q', function()
    if vim.api.nvim_win_get_config(0).zindex then
        if require('neo-zoom').did_zoom() then
            vim.cmd('NeoZoomToggle')
        else
            vim.cmd('close')
        end
    end
end)

The problem with this is that if I get into a popupmenu (such as gitsigns) then did_zoom believes this a "zoomed" window and "NeoZoomToggle" gets called (instead of the expected close). Can get_zoom be changed so it works correctly for this case?

Is there a way to do this?

EDIT: And maybe also when splitting planes 'cos i'm having this behavior

In normal splits you can do something like:

• :above vsp: Create a split to the right
• :below vsp: Create a split to the left
• :above split: Create a split above
• :below split: Create a split below

Is this still possible with the NeoSplit and NeoVSplit commands?

How to reproduce:

1. Zoom-in on any buffer.
2. Switch back to the parent tab with :tabp.
3. Close all windows with :q on the parent tab.
4. Trigger NeoZoom on the child buffer.

Expected

In step 4: should be able to zoom-in on that was-child buffer with NeoZoom.

As title. A similar one can be referenced #15

Vim(lua):E5108: Error executing lua ...nvim/site/pack/packer/start/NeoZoom.lua/lua/neo-zoom.lua:23: Invalid tabpage id: 2
stack traceback:

Sometimes we need to compare. (I haven't thought about the details.)

Idea

When a user zoom-in, it will be really useful to setup a default layout for him, e.g. two equal-size vertical splits (simple = great).

But more details need to be considered:

• should i use no name buffer for extra-split(s)?
• how to choose from default layouts, given that more than 1 is provided?

Why

I just found that have to setup this every time I zoom-in.

As title. This will enhance UX because it let you close all splits rooted from this parent by simply holding your keycomb. for NeoZoom:

1. On parent: trigger NeoZoom, then goto the first child in the closest tab.
2. On the first child: trigger NeoZoom will close this split and go back to the parent. Now go back to 1.

See the pattern? So finally you will close all children.

Hello, thank you for this plugin, I love the idea!

I blindly copied the docs configuration, trusting that the upper case variables were just available globals, but it seems that they are, in fact, plugin locals. I'm talking about the mapping options ones, for example NOREF_NOERR_TRUNC

How to reproduce:

Open two splits (to enable zoom-in), zoom-in, open a buffer that's not already present, this is the only split (so zoom-out enable), zoom-out, no error message since #1 , while now the problem is that I still want to restore the cursor pos. of this buffer.

Solution:

Might be not easy to solve:

• should understand how maps work in Lua
• store cursor pos. for all buffers
• recover cursor pos. on zoom-out

I use <cr> to Toogle zoom. If I press enter in quickfix window to go to the corresponding location, I get the following error:

E5108: Error executing lua ...nvim/site/pack/packer/start/NeoZoom.lua/lua/neo-zoom.lua:25: Vim(tabedit):E499: Empty file name for '%' or '#', only works with ":p:h": tabedit %:p                                                                                                             
stack traceback:                                                                                                                                                                                                                                                                              
        [C]: in function 'cmd'                                                                                                                                                                                                                                                                
        ...nvim/site/pack/packer/start/NeoZoom.lua/lua/neo-zoom.lua:25: in function 'maximize_current_split'                                                                                                                                                                                  
        [string ":lua"]:1: in main chunk

What(TF) is NeoMode, exactly?

Take it easy, let's take a look at the classic scene in Matrix:

When NeoMode is enabled, and the behaviour of NeoZoomToggle will change:

• Instead of zoom(ing)-in the current buffer, it jumps through all the same buffers across all tabs.
• This might be very fucking hard but I think it's possible to provide and UI to let a user jump to the exact tab containing this buffer.

Some issues here

• There might be many same-buffer splits under a tab during the jumping.
• This will require adding a toggle which creates more burden for a user to memorize how(FUCK) many keybindings to do a simple work.

This should resolve future issues like #67.

Ref: https://github.com/s1n7ax/nvim-window-picker/blob/main/lua/window-picker/init.lua#L114-L116

As title. This happened when some floating window of LSP-related plugins didn't get closed on zoom-out.

The default behavior of omitting winopts.offset.left is that NeoZoom.lua should place the floating window at the center of your editor. Now this is not the case if the terminal emulator gets resized.

Using the normal toggle, the cursor is still the same line number when you zoom-out but using C-h/j/l/k (vim navigation) will zoom out the current buffer back to the first line.

Is this normal behavior? Shouldn't be go back to the current line also just like the normal toggling behavior?

NVIM Version: NVIM v0.9.0-dev-701+g34b973b1d

The first time running :NeoZoomToggle after installation, I got the following error:

E5108: Error executing lua /home/donie/.vim/plugged/NeoZoom.lua/lua/neo-zoom.lua:38: attempt to perform arithmetic on field 'top_ratio' (a nil value)                                                                                                                                                
stack traceback:
        /home/donie/.vim/plugged/NeoZoom.lua/lua/neo-zoom.lua:38: in function 'neo_zoom'
        [string ":lua"]:1: in main chunk

I liked it that way it was, how can I get the old defaults back?