Adding "http2 to http2" proxy functions for proxy servers is now much easier. about node-http2-proxy HOT 8 CLOSED

It doesn't work unless you add .end() to http2.request(...). Is this on purpose?

No. end() is called inside onProxyConnect. It might be that http2.request doesn't implement the flow:

req.'socket' => socket.'connect' => onProxyConnect.

from node-http2-proxy.

Oh, it doesn't emit the socket event because it waits for the first write / end.

The whole purpose here is that we don't read/write until we know we have successfully connected, so that we can safely retry requests that contain a stream body.

from node-http2-proxy.

fixed in e0b9324

from node-http2-proxy.

const http = require('http');
const proxy = require('http2-proxy');
const http2 = require('http2-wrapper');

const server = http.createServer();

const defaultWebHandler = (error, request, response) => {
	if (error) {
		console.error(error);

		response.statusCode = 500;
		response.end(error.stack);
	}
};

server.listen(8000, error => {
	if (error) {
		throw error;
	}

	server.on('request', (req, res) => {
		proxy.web(req, res, {
			hostname: 'example.com',
			port: 443,
			onReq: (request, options) => {
				return http2.request(options, response => {
					const {headers} = response;

					// `http2-proxy` doesn't automatically remove pseudo-headers
					for (const name in headers) {
						if (name.startsWith(':')) {
							delete headers[name];
						}
					}
				});
			}
		}, defaultWebHandler);
	});

	console.log(`Listening on port ${server.address().port}`);
});

It doesn't work unless you add .end() to http2.request(...). Is this on purpose?

from node-http2-proxy.

You're right. There's no connect event on the socket. I think I know how to fix this. Thanks for pointing out :)

from node-http2-proxy.

There's no connect event because it's already connected. I think that http2-proxy doesn't cover this edge-case. Hmm, it does.

from node-http2-proxy.

Wait... For some reason it doesn't emit the socket event at all. Welp.

from node-http2-proxy.

Oh, it doesn't emit the socket event because the wrapper waits for the first write / end.

from node-http2-proxy.