onReq with finalhandler = Error about node-http2-proxy HOT 5 CLOSED

If you want to use it you have to handle the proxyRes => res logic, i.e.

    res.statusCode = proxyRes.statusCode
    for (const [ key, value ] of Object.entries(proxyRes.headers)) {
      res.setHeader(key, value)
    }
    proxyRes.pipe(res)

You only need the callback if you want to finish before the usual life cycle of proxyRes and res.

from node-http2-proxy.

That works, but I think its kind of confusing and ugly for my use case. I only want to set some Headers and with the old version 1.3.2 its easy to accomplish. A function to add Headers to the response would be nice.

By the way: The proxyRes from onRes is not a real Http.ServerResponse | Http2.Http2ServerResponse object .. proxyRes.getHeaders() failed.

And thanks for your support and help

from node-http2-proxy.

Fixed in 4.2.14.

from node-http2-proxy.

Thanks for the fast response.
Now the error is gone, but the proxy sends no response to the Client (Pending) after calling the callback from onRes.

from node-http2-proxy.

@Muhaah: don't override the onRes handler. Now that I look at it, the semantics are weird and should be changed.

from node-http2-proxy.