Code Monkey home page Code Monkey logo

Comments (4)

karylchesman avatar karylchesman commented on May 27, 2024

Maybe, if we add recursive option to the cp function at line 50 in /src/bld/build.js, it should work.

Like this:

42    await cp(
43        file,
44        resolve(
45           outDir,
46           platform !== "osx"
47               ? "package.nw"
48               : "nwjs.app/Contents/Resources/app.nw",
49               filePath,
50        ),{ recursive: true }
51   );

I was testing locally and it works for me on Windows

from nw-builder.

sysrage avatar sysrage commented on May 27, 2024

Maybe, if we add recursive option to the cp function at line 50 in /src/bld/build.js, it should work.

This still only works for relative paths and would also fail in some glob cases (e.g. somedir/ would include all of the directory instead of just the empty directory).

I believe @tharatau is adding a --no-glob parameter (or something similar), which solves my use-case but somebody will need to spend a lot of time to get globbing to actually work properly.

from nw-builder.

sysrage avatar sysrage commented on May 27, 2024

I'm happy to close this, now that we have glob: false. I'll never use globbing, so my needs are met.

That said, I doubt files are copied correctly in all cases with globbing enabled. Somebody should verify before closing this issue (or open a new one).

from nw-builder.

ayushmanchhabra avatar ayushmanchhabra commented on May 27, 2024

Cool, tracking file glob issue in #836

from nw-builder.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.