Comments (4)
Maybe, if we add recursive option to the cp function at line 50 in /src/bld/build.js, it should work.
Like this:
42 await cp(
43 file,
44 resolve(
45 outDir,
46 platform !== "osx"
47 ? "package.nw"
48 : "nwjs.app/Contents/Resources/app.nw",
49 filePath,
50 ),{ recursive: true }
51 );
I was testing locally and it works for me on Windows
from nw-builder.
Maybe, if we add recursive option to the cp function at line 50 in /src/bld/build.js, it should work.
This still only works for relative paths and would also fail in some glob cases (e.g. somedir/
would include all of the directory instead of just the empty directory).
I believe @tharatau is adding a --no-glob
parameter (or something similar), which solves my use-case but somebody will need to spend a lot of time to get globbing to actually work properly.
from nw-builder.
I'm happy to close this, now that we have glob: false
. I'll never use globbing, so my needs are met.
That said, I doubt files are copied correctly in all cases with globbing enabled. Somebody should verify before closing this issue (or open a new one).
from nw-builder.
Cool, tracking file glob issue in #836
from nw-builder.
Related Issues (20)
- Windows builds fail with "resolve is not defined" HOT 1
- Error: package.json not found in srcDir file glob patterns. HOT 5
- File globbing is broken HOT 1
- Add Typescript support HOT 19
- FFMPEG: Connection Refused HOT 2
- Managed manifest
- Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/my-path/nw-app/node_modules/nw-builder/get/decompress.js' HOT 3
- Specify log level
- Glob Issue: cp EINVAL src and dest is same HOT 10
- Bug: building win64 produces undefined.exe. HOT 3
- Bug: osx64 build can't be signed - nwjs bundle format unrecognized HOT 4
- Win64 build icon not showing up HOT 25
- NSIS Installer HOT 1
- AppImage Installer HOT 1
- Compress `outDir` to `zip`, `tar`, `tgz` formats
- [osx64] Unable to set icon - results in blank icon HOT 4
- [osx64] Copyright is not configurable - always set to default nwjs HOT 10
- Windows Store compatible
- Build fails with "package.json not found in srcDir file glob patterns" error HOT 9
- Executable file if run on another machine fails HOT 15
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nw-builder.