[osx64] Copyright is not configurable - always set to default nwjs about nw-builder HOT 10 CLOSED

ah so upon further inspection it appears the copyright is in nwjs.app/Contents/Resources/en.lproj/InfoPlist.strings

NSHumanReadableCopyright = "Copyright 2023 The Chromium Authors, NW.js, Node.js. All rights reserved.";

its a plain key value file so you can just use sed to replace it

from nw-builder.

I'm pretty sure CFBundleGetInfoString is no longer supported/used in OSX 10 and above. Let me see what I can do about this.

from nw-builder.

5864c5b
Updating NSHumanReadableCopyright in Contents/Resources/en.lproj/InfoPlist.strings did not update the copyright.

8ccfddf
On the other hand, adding NSHumanReadableCopyright inside Info.plist as mentioned in Apple docs also does not work.

@rocketVibes let me know if you're able to find a solution for this. In the mean time, I'll keep trying.

from nw-builder.

@zkrige have you come across this issue before? how do you set the copyright in your apps?

from nw-builder.

@rocketVibes I looked into what other nw builders were doing. Found this interesting:
https://github.com/nwutils/nwjs-packager/blob/55f9d224ddea0301405508254303593d9ae266fd/bin/builder/BuilderOsx.js#L53

I a bit busy atm. If you're able to incorporate some changes from nwjs-packager and open a PR that would be great!

from nw-builder.

I run a manual plist tool just after build which sets plist values

from nw-builder.

Could you maybe paste some of the code here?

from nw-builder.

I'm traveling so I can't find the exact code but I had a quick look at build scripts on mobile

Here is a plistbuddy command that sets the display name in the renderer helper. You can do similar for any fields in plist

#/usr/libexec/PlistBuddy -c Set :CFBundleDisplayName $NAME Helper (RENDERER)" "${OUTDIRECTORY}/${NAME}.app/Contents/Frameworks/nwjs Framework.framework/Helpers/nwjs Helper (Renderer).app/Contents/Info.plist"

from nw-builder.

Ah cool, thanks!

from nw-builder.

@zkrige Whenever you get the time, could you post the code to update the NSHumanCopyright property?

from nw-builder.