Code Monkey home page Code Monkey logo

Comments (2)

edknv avatar edknv commented on June 11, 2024

T4Rec has T4RecTrainingArguments(data_loader_engine='nvtabular', ...). Is the goal to add an option for data_loader_engine='dataloader'? Should dataloader become the new default?

from dataloader.

sararb avatar sararb commented on June 11, 2024

The NVTabularDataloader class is defined here as an extension of the class TorchAsyncItr defined in NVTabular. This class was already updated to use the new data loader so I believe T4Rec is currently using the new data loader.

Two possible enhancements that I can think of are:

  • removing the explicit import of nvtabular and defining the T4Rec data loader directly from merlin.loader.torch.Loader ( taking into account the additional line of TorchAsyncItr)
  • renaming the option nvtabular in the data_loader registry to something like merlin-loader?

from dataloader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.