prj-rev-bwfs-dasmoto's People
prj-rev-bwfs-dasmoto's Issues
GREAT - organization
excellent job keeping your code organized and readable using consistent indentation throughout. make sure head and body are indented inside of html to indicate their nested relationship.
GREAT - local images
excellent job using relative file paths to link to your locally saved images throughout!
SUMMARY
GRADE: Exceeds Expectations
SUMMARY: Great work on this project! The site itself looks great and you did an excellent job keeping both the project folder and the code neat, organized, and readable. Excellent work keeping the styling clean and concise as well.
The only small area for improvement would be the class / id naming structure you've chosen. Use ids to target unique, specific elements. In this project, the unique elements are the h2 items that each get a different background color. Your code works fine here, but using the ids right on the h2 elements would be a bit more straight forward.
Consider organizing the html and css further by making use of some comments throughout. More info about html styling in general can be found here - https://www.w3schools.com/html/html5_syntax.asp
SUBTLETY - classes / ids
consider this alternative for your naming structure -
<div class="item">
<h2 id="brushes">Brushes</h2>
<img src="./resources/images/hacksaw.jpeg" alt="Hacksaw Brushes">
<h3>Hacksaw Brushes</h3>
<p>Made of the highest quality oak, Hacksaw brushes are known for their weight and ability to hold paint in large amounts. Available in different sizes. <span class="price">Starting at $3.00 / brush.</span></p>
</div>
this way, the unique element 'brushes' gets the unique id and the general class 'item' is used for the entire section which will be styled the same as the other two.
GREAT - dry css
excellent implementation of DRY principles in setting the font-family just once for the entire page!
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.