nvamsikrishna05 / prj-rev-bwfs-dasmoto Goto Github PK

excellent job keeping your code organized and readable using consistent indentation throughout. make sure head and body are indented inside of html to indicate their nested relationship.

excellent job using relative file paths to link to your locally saved images throughout!

GRADE: Exceeds Expectations

SUMMARY: Great work on this project! The site itself looks great and you did an excellent job keeping both the project folder and the code neat, organized, and readable. Excellent work keeping the styling clean and concise as well.

The only small area for improvement would be the class / id naming structure you've chosen. Use ids to target unique, specific elements. In this project, the unique elements are the h2 items that each get a different background color. Your code works fine here, but using the ids right on the h2 elements would be a bit more straight forward.

Consider organizing the html and css further by making use of some comments throughout. More info about html styling in general can be found here - https://www.w3schools.com/html/html5_syntax.asp

consider this alternative for your naming structure -

<div class="item">
        <h2 id="brushes">Brushes</h2>
        <img src="./resources/images/hacksaw.jpeg" alt="Hacksaw Brushes">
        <h3>Hacksaw Brushes</h3>
        <p>Made of the highest quality oak, Hacksaw brushes are known for their weight and ability to hold paint in large amounts. Available in different sizes. <span class="price">Starting at $3.00 / brush.</span></p>
</div>

this way, the unique element 'brushes' gets the unique id and the general class 'item' is used for the entire section which will be styled the same as the other two.

https://github.com/nvamsikrishna05/prj-rev-bwfs-dasmoto/blob/master/Dasmoto's%20Arts%20%26%20Crafts/resources/css/styles.css#L2

excellent implementation of DRY principles in setting the font-family just once for the entire page!