nuytemans-dieter / bettersleeping Goto Github PK

Hi, I have an issue where when the last person required to sleep enters their bed the server immediately jumps to day, ignoring the 'sleep_delay' in the config. I have set this to various numbers with no change. It's especially weird when there's only one person on the server (when I first tested the plugin) as you don't appear to even get in the bed.

Hoping this is something you can fix. Thanks.

Expand 'enough_sleeping' in lang.yml to include how long the players have to wait before the night/storm is skipped (dependent on 'sleep_delay' in config.yml).

Add a lang option in config.yml. This will load a default lang file.
Example, in config.yml:
lang: "EN" or lang "NL"
The next reload or /bs reload will replace lang.yml with the content of the chosen language file

Let the server know when a message won't be visible by a player!

A countdown timer that counts down to nighttime, when people will be able to sleep. This way, the players are prepared.

Edit: This should be an option (default: false). When set to false, there should be no impact on server performance.

This was overlooked in the previous update, but is scheduled for release in the next update.

I cant tell if anyone else is having this issue, when i set the buff level to 1 its giving the players the second level of that buff instead of the first, eg.
Makes the player run faster
speed:
time: 9600
level: 1
gives the player speed 2 for 8 minutes, this is happening to all of the buffs and i have no idea how to fix it

~Seymo5 on Spigot

Add the ability for players to disable a specific message (command for players, something like: /bs hide message_name). This will be player specific (player x disables a message but player y still receives that message).

How do I disable the cancelled message? I tried leaving it as blank and typing ignored but it didn't work

If a configuration option is not found, the default value will be used. But in an ideal scenario, the missing option should be written to the default file. Server owners/admins wouldn't have to delete YAML file(s) anymore when new options are added.
Alternatively, missing configuration options can be reported to the console upon startup.

A new command /bettersleeping reset. That will reset the configuration files.
By default only OPs can use this command. bettersleeping.reset will be the permission.

A tag that is replaced by the current amount of sleeping players

PlaceholderAPI, to bring lang customisation to a higher level.

To remain configurability and provide grammatical correct messages, this will be included in lang.yml.
Words can be tagged with a singular and plural version as follows: <singular.plural>
For example:
old: " players are needed!"
new: " <player.players> are needed!"

BetterSleeping will now automatically grab the correct word.

Upon /bs reload, the chat colors of pex and deluxechat break as stated by a user's bug report. A server restart or reload did fix the issues.
Presumably, it breaks configuration of all other plugins but no further data is available at this moment.

Not sure if anyone else is having this issue, but with I have BetterSleeping with multiworld support on, and the "cancelled" message is being sent after it already has turned to day. Not sure if this was always there or if it just appeared. Running 1.14.4 Paper Spigot. :)

~Zachrocks22 on Spigot

An option that will reduce the amount of messages sent by BetterSleeping.
Example: every x amount of people that go to bed, will be broadcast instead of after every person that goes to bed.

Players that have slept receive temporary buffs for (Healing, filling food bar, speed, etc...).

If a storm (not night) is skipped, there is a slightly longer delay before players are kicked out of their bed by the game. To fix this BetterSleeping should perform a check and if there is a storm during the day when players sleep and subtract the extra wait time from the sleep_delay. This way, the configured time will be maintained (unless it is set to a low wait time).

A tag that is replaced by the total amount of players that should be sleeping to skip the night or storm.

This tag will be replaced by the user that did an action, example: "user_x left their bed".

Only one message can be shown on screen but sometimes multiple messages are sent at once.
A workaround should be made!

Currently there are a lot of comments in the config files.
This is great to explain everything but they could and should be simplified a bit!

Allow BetterSleeping messages to appear on screen (but not in chat). This will prevent spam.

Add sound effects to notify players:
-You can sleep now
-Someone entered their bed
-Someone left their bed
-...

Notify the console when BetterSleeping is loading and an update has been found.

Players will receive a message if they receive a buff. The other players don't get notified. This way, they would also be encouraged to sleep.

Give players (configurable) temporary debuffs for not sleeping for a long period of time (Poison, mining fatigue, slowness, spawn monster...).

Management should be split into LangManagement, ConfigManagement and BuffManagement.
This will give a better overview.

I am using Ultra Permission https://www.spigotmc.org/resources/ultra-permissions.42678/

But ingame, no perms are visible. maybe, you will contact the author for making BetterSleeping beeing compatible with uPerms?

Here it is explained how to make it compatible: https://github.com/TechsCode/UltraPermissionsDatabase

When all online players have got bypass permissions, the night cannot be skipped. A solution should be found (ex: a command they can execute)

Just in case anyone is following the progress of this milestone: all should be finished but testing still needs to be done.
Adjustments may be made to improve the UX.
Bugs may still be found and fixed.

When counting the players needed, ignore the ones that are afk.

Add a check in SleepTracker.java -> If 0, return 1!

Jump and speed do not have a comment that explains their effect