nuxt-contrib / tib Goto Github PK

Document for staticServer option states this:

• folder (string, optional)
  
  The path used as the webroot for the webserver. If not provided the default folder browser config option is used

So I would assume that if config.folder is provided and staticServer is set to object like { port: 3333 } then it will use folder from root config. But it's not the case. It seems it's only using folder from root config if staticServer is set to true:

https://github.com/nuxt/tib/blob/5f3322bd2fe77041b256cfff60ef1fa067fad06c/src/commands/static-server.js#L19-L26

These escapes are invalid:
https://github.com/nuxt/tib/blob/e10c1827688d2888bb753bce60a538bf607366a0/src/utils/detectors/chrome.js#L49
as in, will prevent finding chrome's path.

"Same" code in nuxt.js doesn't have those and works.

We now have warning using tib:

waitFor is deprecated and will be removed in a future release. See https://github.com/puppeteer/puppeteer/issues/6214 for details and how to migrate your code.

Learn more on puppeteer/puppeteer#6214

I think detection is broken again:

The original command that detects Chrome:

https://github.com/nuxt/tib/blob/28ca90b16144a6619eca5e811a3eafce60d7d29d/src/utils/detectors/chrome.js#L49

doesn't return anything anymore in Catalina.

I've removed the end of line match character ($) and then I got those results:

/System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/LaunchServices.framework/Versions/A/Support/lsregister -dump  | grep -E -i '(google chrome( canary)?|chromium).app'
path:               /Applications/Google Chrome.app/Contents/Frameworks/Google Chrome Framework.framework/Versions/77.0.3865.90/Helpers/Google Chrome Helper (GPU).app (0xa8c)
path:               /Applications/Google Chrome.app (0xc54)
path:               /Applications/Google Chrome.app/Contents/Frameworks/Google Chrome Framework.framework/Versions/77.0.3865.120/Helpers/Google Chrome Helper (GPU).app (0xc94)
path:               /Applications/Google Chrome Canary.app (0xce8)
path:               /Applications/Google Chrome Canary.app/Contents/Frameworks/Google Chrome Framework.framework/Versions/79.0.3942.0/Helpers/Google Chrome Helper (GPU).app (0xd04)

Used this command in terminal:
/System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/LaunchServices.framework/Versions/A/Support/lsregister -dump | grep -E -i '(google chrome( canary)?|chromium)\.app\b'

So I think now the difference is the lines don't end with *.app but are followed by some code value (0xd04 etc).

Here is what could be done to fix this in non-backward compatible way (obviously not acceptable, but to give an idea).

        ' | grep -E -i \'(google chrome( canary)?|chromium)\\.app\\b\'' +
        ' | awk \'{$1=""; $NF=""; print $0}\''

• replace $ with \b (word boundary) maybe.
• escape dot as it wasn't before
• clear $NF (last component of the whole line splitted on space)

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Repository problems

These problems occurred while renovating this repository. View logs.

• WARN: Using npm packages for Renovate presets is now deprecated. Please migrate to repository-based presets instead.

Rate-Limited

These updates are currently rate-limited. Click on a checkbox below to force their creation now.

• chore(deps): replace devdependency rollup-plugin-json with @rollup/plugin-json ^4.0.0
• chore(deps): replace devdependency standard-version with commit-and-tag-version ^9.5.0
• chore(deps): update devdependency eslint to v9
• chore(deps): update devdependency eslint-plugin-jest to v28
• chore(deps): update devdependency eslint-plugin-vue to v9
• chore(deps): update devdependency rimraf to v5
• chore(deps): update devdependency rollup to v4
• chore(deps): update peerdependency chromedriver to v124
• chore(deps): update peerdependency geckodriver to v4
• chore(deps): update peerdependency jsdom to v24
• chore(deps): update peerdependency puppeteer to v22
• chore(deps): update peerdependency puppeteer-core to v22
• 🔐 Create all rate-limited PRs at once 🔐

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): replace devdependency babel-eslint with @babel/eslint-parser ^7.11.0
• chore(deps): replace devdependency eslint-plugin-node with eslint-plugin-n ^14.0.0
• chore(deps): replace devdependency rollup-plugin-node-resolve with @rollup/plugin-node-resolve ^6.0.0
• chore(deps): update all non-major dependencies (@babel/core, @babel/node, @babel/parser, @babel/preset-env, babel-loader, browserstack-local, chromedriver, codecov, eslint, eslint-config-standard, eslint-plugin-import, eslint-plugin-jest, eslint-plugin-promise, eslint-plugin-vue, finalhandler, geckodriver, glob, jsdom, rollup, selenium-webdriver, serve-static, signal-exit, vue-template-compiler, webpack, yarn)
• chore(deps): update dependency babel-loader to v9
• chore(deps): update dependency glob to v10
• chore(deps): update dependency signal-exit to v4
• chore(deps): update devdependency eslint-config-standard to v17
• chore(deps): update devdependency eslint-plugin-promise to v6
• chore(deps): update jest monorepo to v29 (major) (babel-jest, jest)
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

Having a hard time getting this to work. Using same babel settings as the src.