nurupo / ci-release-publisher Goto Github PK

Currently the Latest Release will be created only if the Travis-CI build we are currently running in is the latest build for the branch. This is done to:

1. Avoid the race condition of two builds modifying the same release at the same time.
2. Prevent someone restarting an ancient Travis-CI build and getting the Latest Release updated to that.

While this check works very well if we assume that a user sets up CIRP to run on every git push and makes only git push builds, it stars to fall apart when it's ran only in Travis-CI's cron builds. We can get in a situation when a cron build is started first, but then someone makes a git push into the repo, creating another build, so the cron build is no longer the latest build for the branch and it won't update the Latest Release, yielding the right to update to the newer build, but since CIRP is ran only on cron builds, the newer build that was caused by git push won't be updating Latest Release, resulting in Latest Release not getting updated at all. The behavior we want here is for Latest Release to check if the current build is the latest cron build.

Since we have no way to know which kinds of builds: git push, cron, api, etc. a user restricted Travis-CI to run CRIP on, there is no way for the script to detect which kinds of builds it should be checking for, so some kind of an option is required. For example, --latest-release-check {push, cron, api} [{push, cron, api} ...], which, if not provided, will default to checking the latest build without any restriction, making it consistent with the current behavior.

https://github.com/cloudius-systems/osv#osv uses the plugin in the 'Publishes to a different repo' mode