Code Monkey home page Code Monkey logo

yt-url's People

Contributors

claudiob avatar

Stargazers

 avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

yt-url's Issues

Refactoring to more closely adhere to Single Responsibility Principle

After viewing your recent Ruby Conf talk I was inspired to consider more refactoring of the yt-url project. This was done as an exercise over the holidays but thought you might be interested in the result. I forked the project into dpneumo/yt-url. Have used WebMock to avoid having to hit the YouTube API during testing. That approach makes the assumption that the mock accurately follows the API in both requests and responses. Two issues with the assumption. The mock accuracy is not tested. (Should not be hard to test but probably should be independent of the testing during development and can be done less frequently.) And at present WebMock cannot stub a response body containing JSON. There is a PR to WebMock to address that issue.

If you think this would be useful to you I would be happy to create a PR that meets your coding standards. My testing was done with minitest as I am much more comfortable with minitest than rspec. That can be switched to rspec. The specs in my fork are not ready for use at present.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.