Code Monkey home page Code Monkey logo

data-structures's People

Contributors

nsafai avatar

Watchers

avatar

data-structures's Issues

Feedback: First Challenge Submission

  • There was a bug that the tests caught for find_all_indexes, but I let it go because its a super quick fix for an edge case. Make sure everything you return from that function has a consistent type.
  • Your encode and decode functions are short and sweet, which I think is good. One thing I would like to nitpick is that you could have used the variables quotient and remainder for q and r, considering you already wrote it out twice in the comments. It's all good though because it isn't used in a large scope, and you mention it twice in the comments.
  • All your comments are great, and very helpful. One place that I thought could use a good explanation was for line 26 in bases.py. A couple things go on there, and people unfamiliar with decoding numbers might not understand.

Feedback: Second Challenge Submission

  • Nice work on your stack and queue methods. I don't think there is anything I would change, and your complexity annotations all seem to be correct.
  • For your set, I recommend moving the items argument ahead of the size argument when initializing each structure. I think people are more likely to initialize those structures with items then they are to initialize it with a size, and I think it's possible to initialize the structure with a good size based on the length of the input items.
  • Your set tests are fine the way they currently are, but you might consider varying the input to use integers or muli-character strings, as I have already seen this break someone's code. I would also like to see more testing of the size property.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.