nrk / predisserviceprovider Goto Github PK

I'm using PredisServiceProvider with latest version of Silex and Composer.
I got an error while trying to register the service, because in the register method there is a reference to the old Silex autoloader:

        if (isset($app["$prefix.class_path"])) {
            $app['autoloader']->registerNamespace('Predis', $app["$prefix.class_path"]);
        }

I think all the references to the old silex autoloader have to be removed, even in the README in favour of composer instructions.

Hello!

Can you please remove the silex requirement in your composer.json.
If I use your bundle, composer installs silex/silex and all symfony dependencies, but the come with the silex.phar.

So it would be great if you remove the requirement. Maybe you add silex as suggest, so it can be installed with the parameter --install-suggests in composer.

thank you very much und greetings from munich, sebastian

PredisServiceProvider must implement new ServiceProviderInterface::boot() method, introduced in silex source code

Hi,

I was wondering if you are planning on creating a release branch/tag with a stable version for Silex 2?
Master seems stable ATM for usage with Silex 2/Pimple, but I would like to set my projects composer config on release rather than master.

I'am using "predis/predis": "~0.8.3@stable", as defined in the master branch.

In register(Application $app), line 117 :

$app["$prefix.uri_parser"] = $app->protect(function ($uri) {
    return ConnectionParameters::parseURI($uri);
});

But, parseURI() seems to be a private method..

private function parseURI($uri) { /* ... */ }

Now that Predis v1.0 is available, this service provider should target this new major and API-stable release. As a side note, we should also take the chance to bump its version v1.0: the provider's code and design are fine, we just have to switch to PSR-4 and maybe use better naming for the classes (I've always hated MultiPredisServiceProvider).