novactive / novaezseobundle Goto Github PK

View Code? Open in Web Editor NEW

25.0 25.0 57.0 4.2 MB

Novactive eZ Publish and Platform SEO Bundle

License: MIT License

PHP 76.13% CSS 2.43% JavaScript 5.11% Twig 16.32%

novaezseobundle's People

Contributors

Stargazers

Watchers

Forkers

iherak ezpublishlegacy clash82 rihards declemo ychakroun gauthiergarnier kaliop-uk gmaissa alafon erdnaxelaweb ezecosystem oportier skrosoft balamung damianz5 nicogommen erik-bogdan mrkisha kamilmusial fabian-markaban maxbaldanza sgrichards bdunogier o7daniel alongosz gbiau21 kaliop kmadejski marioblazek steffikn bluetel jorgensolli benoitsauvagekaliop ahmed-bhs xama okante mkrogoll serheydolgushev janit rhidja bekiroeztuerk styleflasher tomaske maleprohon emodric elbformat mediatacom holzwegdev lenkiewiczgrzegorz gintron jlchassaing code-rhapsodie se7enxweb netgen pkamps arfaram

novaezseobundle's Issues

multiple sitemap_includes

It's not possible to use multiple sitemap_includes because they are LogicalAnd
For example:

            sitemap_includes:
                contentTypeIdentifiers: ['page', 'news_item']

Expected behavior: return all objects of type 'page' or 'news_item'

Possible solution: LogialOr over all sitemap_includes

Allow php >= 8

Please update the required php version to allow php >= 8.0
Thanks

content type view error - missing template block

Hello,

This issue is not critical.

When you save a content type that contains NovaeZSEO Field Type:

Using the Apply button it works
Using the OK button it gives an error

Despite getting this error, the content type is saved, because the error happens actually on the view template of the content type:

I mean, this following view doesn't work for content types that contains NovaeZSEOBundle Field Type:

The error in log file is:

[2017-02-08 13:24:09] request.CRITICAL: Uncaught PHP Exception Twig_Error_Runtime: "An exception has been thrown during the rendering of a template ("Cannot find 'novaseometas_settings' template block.")." at C:\PhpstormProjects\dbs-website\vendor\ezsystems\platform-ui-bundle\Resources\views\ContentType\view_content_type.html.twig line 125 {"exception":"[object] (Twig_Error_Runtime(code: 0): An exception has been thrown during the rendering of a template (\"Cannot find 'novaseometas_settings' template block.\"). at C:\\PhpstormProjects\\dbs-website\\vendor\\ezsystems\\platform-ui-bundle\\Resources\\views\\ContentType\\view_content_type.html.twig:125, eZ\\Publish\\Core\\MVC\\Symfony\\Templating\\Exception\\MissingFieldBlockException(code: 0): Cannot find 'novaseometas_settings' template block. at C:\\PhpstormProjects\\dbs-website\\vendor\\ezsystems\\ezpublish-kernel\\eZ\\Publish\\Core\\MVC\\Symfony\\Templating\\Twig\\FieldBlockRenderer.php:318)"} []

Calling http://127.0.0.1:8000/pjax/contenttype/view/[content-type-id]/eng-GB will give HTTP error 500.

Voilà ;)

Vincent

Improve UI in Admin UI

UI in eZ Platform Admin UI is not great.
It would require some CSS, style of the Label etc.

Wrong criterion generated when using sitemap_includes in the sitemap.xml config

Hi,
I wanted to report you an issue in your QueryFactory when using the "sitemap_includes" config. Here is an example :

nova_ezseo.default.sitemap_includes:
    locations: []
    subtrees: []
    contentTypeIdentifiers:
        - content_type_1
        - content_type_2
        - content_type_3

For this config, the result criterion should be :

Criterion\ContentTypeIdentifier(['content_type_1', 'content_type_2', 'content_type_3']); // implicit OR operator

instead the QueryFactory generates separate criterions with an "AND" operator between them, which makes the query to have always 0 results because a content cannot be multiple content types in the same time :

Criterion\LogicalAnd([
    Criterion\ContentTypeIdentifier(['content_type_1']),
    Criterion\ContentTypeIdentifier(['content_type_2']),
    Criterion\ContentTypeIdentifier(['content_type_3']),
]);

[eZ Platform] Preview when content isDraft

When a Location/Content is Draft, this bundle will crash the Preview.

It can easily be detected and bypassed by loading the template on condition:

    {% block seo_metas %}
        {% if location is not defined or (location is defined and not location.isDraft ) %}
            {% include "NovaeZSEOBundle::seometas_head.html.twig" %}
        {% endif %}
    {% endblock %}

As it is only for the preview.

But it will be better to make that test in the bundle directly.

Use the Default eZ Wildcard Router

Since 2.5: ezsystems/ezpublish-kernel#2609

eZ added the router that was missing before, so we can remove the one present in this bundle.

ping @amine-betari @florianalexandre @yhanini if you have time before me ;-)

Social Network min image size 200x200

Time for a release?

With this being included in ezplatform-demo now, would be good to tag 2.2.0 final soon.

Extension 'novaseo' does not have the subdirectory 'modules' allthough it reported it had modules.

I see this warning when eZDebug is enabled:

Extension 'novaseo' does not have the subdirectory 'modules' allthough it reported it had modules.
Looked for directory 'extension/novaseo/modules'
Check the setting ModuleSettings/ExtensionRepositories in module.ini for your extension.

After removing module.ini.append.php file warning disappears :)

PHP 7.1 swag

It would be great to clean up a bit a use cool stuff form PHP 7.1

return type
type hint

and so on.

fieldtype_metas fields not visible in admin panel for existing content objects

Issue description:

Newly added fields in fieldtype_metas are not displayed in edit form of novaseometas field type.

Steps to reproduce:

Create config for nova_ezseo (I used the one that was in the USAGE.md documentation)

nova_ezseo:
    system:
        default:
            fieldtype_metas_identifier: "metas"
            fieldtype_metas:
                title:
                    label: 'Title'
                    default_pattern: "<title|name>"
                description:
                    label: 'Description'
                    default_pattern: "<description|short_description|title|name>"

Add "novaseometas" content field definition to content type
Create new content using content type from point 2 (you will see both title and description in the form of novaseometas field)
Update nova_ezseo config with new fields

nova_ezseo:
    system:
        default:
            fieldtype_metas_identifier: "metas"
            fieldtype_metas:
                title:
                    label: 'Title'
                    default_pattern: "<title|name>"
                description:
                    label: 'Description'
                    default_pattern: "<description|short_description|title|name>"
                'og:title':
                    label: 'Facebook - Title'
                    default_pattern: "<title|name>"
                    icon: 'facebook-official'
                'og:description':
                    label: 'Facebook - Description'
                    default_pattern: "<short_description|description|title|name>"
                    icon: 'facebook-official'

Edit content that you created in step 2. You will only have field "title" and "description" in novaseometas field.

What I expect to see:

In step 5, I expect to have all fields: title, description, og:title and og:description

Worth mentioning:

After adding new fieldtype_metas fields, you can create new content and the novaseometas field will list all fields (even the ones that I just added to the config). So it seems like this is only issue for existing content.

I tried to debug it and I found this part of code in Novactive\Bundle\eZSEOBundle\Core\FieldType\Metas\FormMapper:85

        if (empty($data->value->metas)) {
            foreach ($metasConfig as $key => $meta) {
                $data->value->metas[$key] = new Meta($key, '');
            }
        }

and this is where the new meta config is loaded, but only when $data->value->metas is empty. When I remove that if (empty($data->value->metas)) condition, the form will list new fieldtype_metas in edit content form.
Is this a bug or it's on purpose? Can you please help me with this and tell me what can I do? I think that maybe I should do something after I updated fieldtype_metas configuration.
Thanks!

Change config have to provide complete settings

If you want to change one setting for a sitegroup under nova_ezseo you have to redefine all the settings, This makes it very tedious if you are trying to leverage any kind of setting inheritance.

problem deploying to platform.sh after installing this bundle

hello.
i've installed this bundle in a test site i'm working one. this site is hosted in a trial platform.sh install for now. thing is all deploys went well until i've added this bundle.

it looks problem is in the scripts part of the composer install process. more deeply, when trying to clear caches. For some reason, it tries to reach the database and the database does not seem to be up at that point.

here's the trace

platform push -f
Are you sure you want to push to the master (production) branch? [Y/n] Y
Pushing HEAD to the existing environment master
  Hello Carlos Revillo (UUID: f1cfcc54-c32b-4391-9e86-206088c5c251), you successfully connected, but the service g67zz6x5xejlg doesn't exist or you do not have access to it
  
  Validating submodules
  
  Validating configuration files
    W: The minimum interval between cron runs is 5 minutes, even if specified as less.
  
  Processing activity: the cocktail experience pushed to Master
      Found 1 new commit
  
      Building application 'app' (runtime type: php:7.3, tree: 09fc516)
        Generating runtime configuration.
        
        Installing build dependencies...
          Installing nodejs build dependencies: yarn
          /app/.global/bin/yarn -> /app/.global/lib/node_modules/yarn/bin/yarn.js
          /app/.global/bin/yarnpkg -> /app/.global/lib/node_modules/yarn/bin/yarn.js
          /app/.global/lib
          └── [email protected] 
          
        
        Executing build hook...
          W: Loading composer repositories with package information
          W: Installing dependencies from lock file
          W: Package operations: 113 installs, 0 updates, 0 removals
          W:   - Installing ocramius/package-versions (1.4.0): Loading from cache
          W:   - Installing symfony/thanks (v1.1.0): Loading from cache
          W:   - Installing crevillo/ezplatform-tinymce-html-fieldtype (v0.7.0): Loading from cache
          W:   - Installing symfony/polyfill-mbstring (v1.11.0): Loading from cache
          W:   - Installing symfony/polyfill-ctype (v1.11.0): Loading from cache
          W:   - Installing twig/twig (v2.11.3): Loading from cache
          W:   - Installing paragonie/random_compat (v9.99.99): Loading from cache
          W:   - Installing symfony/polyfill-php70 (v1.11.0): Loading from cache
          W:   - Installing symfony/polyfill-util (v1.11.0): Loading from cache
          W:   - Installing symfony/polyfill-php56 (v1.11.0): Loading from cache
          W:   - Installing symfony/symfony (v3.4.30): Loading from cache
          W:   - Installing symfony/polyfill-intl-icu (v1.11.0): Loading from cache
          W:   - Installing symfony/polyfill-apcu (v1.11.0): Loading from cache
          W:   - Installing psr/simple-cache (1.0.1): Loading from cache
          W:   - Installing psr/log (1.1.0): Loading from cache
          W:   - Installing psr/link (1.0.0): Loading from cache
          W:   - Installing psr/container (1.0.0): Loading from cache
          W:   - Installing psr/cache (1.0.1): Loading from cache
          W:   - Installing fig/link-util (1.0.0): Loading from cache
          W:   - Installing doctrine/lexer (1.0.2): Loading from cache
          W:   - Installing doctrine/annotations (v1.6.1): Loading from cache
          W:   - Installing doctrine/reflection (v1.0.0): Loading from cache
          W:   - Installing doctrine/event-manager (v1.0.0): Loading from cache
          W:   - Installing doctrine/collections (v1.6.2): Loading from cache
          W:   - Installing doctrine/cache (v1.8.0): Loading from cache
          W:   - Installing doctrine/persistence (1.1.1): Loading from cache
          W:   - Installing doctrine/inflector (v1.3.0): Loading from cache
          W:   - Installing doctrine/common (v2.10.0): Loading from cache
          W:   - Installing jdorn/sql-formatter (v1.2.17): Loading from cache
          W:   - Installing doctrine/doctrine-cache-bundle (1.3.5): Loading from cache
          W:   - Installing doctrine/dbal (v2.9.2): Loading from cache
          W:   - Installing doctrine/doctrine-bundle (1.11.2): Loading from cache
          W:   - Installing doctrine/instantiator (1.2.0): Loading from cache
          W:   - Installing doctrine/orm (v2.6.3): Loading from cache
          W:   - Installing egulias/email-validator (2.1.10): Loading from cache
          W:   - Installing ezsystems/doctrine-dbal-schema (v0.1.2): Loading from cache
          W:   - Installing zetacomponents/base (1.9.1): Loading from cache
          W:   - Installing zetacomponents/system-information (1.1.1): Loading from cache
          W:   - Installing zendframework/zend-eventmanager (3.2.1): Loading from cache
          W:   - Installing zendframework/zend-code (3.3.1): Loading from cache
          W:   - Installing ocramius/proxy-manager (2.1.1): Loading from cache
          W:   - Installing symfony-cmf/routing (2.1.0): Loading from cache
          W:   - Installing sensio/framework-extra-bundle (v5.4.1): Loading from cache
          W:   - Installing composer/ca-bundle (1.2.0): Loading from cache
          W:   - Installing sensiolabs/security-checker (v5.0.3): Loading from cache
          W:   - Installing sensio/distribution-bundle (v5.0.25): Loading from cache
          W:   - Installing pagerfanta/pagerfanta (v2.1.3): Loading from cache
          W:   - Installing league/flysystem (1.0.53): Loading from cache
          W:   - Installing oneup/flysystem-bundle (3.1.0): Loading from cache
          W:   - Installing nelmio/cors-bundle (1.5.6): Loading from cache
          W:   - Installing imagine/imagine (v0.7.1): Loading from cache
          W:   - Installing liip/imagine-bundle (2.1.0): Loading from cache
          W:   - Installing psr/http-message (1.0.1): Loading from cache
          W:   - Installing psr/http-factory (1.0.1): Loading from cache
          W:   - Installing psr/http-client (0.1.0): Loading from cache
          W:   - Installing php-http/promise (v1.0.0): Loading from cache
          W:   - Installing php-http/httplug (v1.1.0): Loading from cache
          W:   - Installing php-http/message-factory (v1.0.2): Loading from cache
          W:   - Installing nyholm/psr7 (1.1.0): Loading from cache
          W:   - Installing kriswallsmith/buzz (0.17.2): Loading from cache
          W:   - Installing nikic/php-parser (v4.2.2): Loading from cache
          W:   - Installing jms/translation-bundle (1.4.4): Loading from cache
          W:   - Installing hautelook/templated-uri-router (2.0.3): Loading from cache
          W:   - Installing hautelook/templated-uri-bundle (2.1.0): Loading from cache
          W:   - Installing guzzle/guzzle (v3.8.1): Loading from cache
          W:   - Installing friendsofsymfony/http-cache (1.4.5): Loading from cache
          W:   - Installing friendsofsymfony/http-cache-bundle (1.3.16): Loading from cache
          W:   - Installing ezsystems/ezpublish-kernel (v7.5.3): Loading from cache
          W:   - Installing willdurand/js-translation-bundle (2.6.6): Loading from cache
          W:   - Installing white-october/pagerfanta-bundle (v1.2.4): Loading from cache
          W:   - Installing mck89/peast (v1.9.2): Loading from cache
          W:   - Installing knplabs/knp-menu (2.4.0): Loading from cache
          W:   - Installing knplabs/knp-menu-bundle (2.2.2): Loading from cache
          W:   - Installing ezsystems/repository-forms (v2.5.2): Loading from cache
          W:   - Installing symfony/polyfill-php72 (v1.11.0): Loading from cache
          W:   - Installing symfony/polyfill-intl-idn (v1.11.0): Loading from cache
          W:   - Installing symfony/polyfill-iconv (v1.11.0): Loading from cache
          W:   - Installing swiftmailer/swiftmailer (v6.2.1): Loading from cache
          W:   - Installing symfony/swiftmailer-bundle (v3.2.8): Loading from cache
          W:   - Installing ezsystems/ezplatform-admin-ui (v1.5.4): Loading from cache
          W:   - Installing ezsystems/ezplatform-user (v1.0.3): Loading from cache
          W:   - Installing ezsystems/ezplatform-richtext (v1.1.3): Loading from cache
          W:   - Installing ezsystems/ezplatform-design-engine (v2.0.0): Loading from cache
          W:   - Installing ezsystems/ezplatform-admin-ui-modules (v1.5.4): Loading from cache
          W:   - Installing ezsystems/ez-support-tools (v1.0.3): Loading from cache
          W:   - Installing ezsystems/ezplatform-admin-ui-assets (v4.2.0): Loading from cache
          W:   - Installing ezsystems/ezplatform-core (v1.0.2): Loading from cache
          W:   - Installing cron/cron (1.4.1): Loading from cache
          W:   - Installing ezsystems/ezplatform-cron (v2.0.0): Loading from cache
          W:   - Installing webonyx/graphql-php (v0.13.5): Loading from cache
          W:   - Installing overblog/graphql-bundle (v0.11.14): Loading from cache
          W:   - Installing erusev/parsedown (1.7.3): Loading from cache
          W:   - Installing ezsystems/ezplatform-graphql (v1.0.2): Loading from cache
          W:   - Installing ezsystems/ezplatform-http-cache (v0.9.1): Loading from cache
          W:   - Installing ezsystems/ezplatform-matrix-fieldtype (v1.0.1): Loading from cache
          W:   - Installing netgen/query-translator (1.0.2): Loading from cache
          W:   - Installing ezsystems/ezplatform-solr-search-engine (v1.7.0): Loading from cache
          W:   - Installing ezsystems/ezplatform-standard-design (v0.2.1): Loading from cache
          W:   - Installing ezsystems/symfony-tools (v1.0.3): Loading from cache
          W:   - Installing willdurand/jsonp-callback-validator (v1.1.0): Loading from cache
          W:   - Installing friendsofsymfony/jsrouting-bundle (1.6.3): Loading from cache
          W:   - Installing incenteev/composer-parameter-handler (v2.1.3): Loading from cache
          W:   - Installing mtdowling/jmespath.php (2.4.0): Loading from cache
          W:   - Installing kaliop/ezmigrationbundle (5.10.1): Loading from cache
          W:   - Installing novactive/ezseobundle (4.1.2): Loading from cache
          W:   - Installing scssphp/scssphp (1.0.2): Loading from cache
          W:   - Installing kriswallsmith/assetic (v1.4.0): Loading from cache
          W:   - Installing symfony/assetic-bundle (v2.8.2): Loading from cache
          W:   - Installing monolog/monolog (1.24.0): Loading from cache
          W:   - Installing symfony/monolog-bundle (v3.4.0): Loading from cache
          W:   - Installing symfony/service-contracts (v1.1.5): Loading from cache
          W:   - Installing symfony/webpack-encore-bundle (v1.6.2): Loading from cache
          W:   - Installing twig/extensions (v1.5.4): Loading from cache
          W: Package guzzle/guzzle is abandoned, you should avoid using it. Use guzzlehttp/guzzle instead.
          W: Package symfony/assetic-bundle is abandoned, you should avoid using it. Use symfony/webpack-encore-pack instead.
          W: Generating optimized autoload files
          ocramius/package-versions:  Generating version class...
          ocramius/package-versions: ...done generating version class
          W: > Incenteev\ParameterHandler\ScriptHandler::buildParameters
          Creating the "app/config/parameters.yml" file
          W: > eZ\Bundle\EzPublishCoreBundle\Composer\ScriptHandler::clearCache
          
          In AbstractMySQLDriver.php line 93:
                                                                                         
            An exception occurred in driver: SQLSTATE[HY000] [2002] No such file or dir  
            ectory                                                                       
                                                                                         
          
          In PDOConnection.php line 31:
                                                              
            SQLSTATE[HY000] [2002] No such file or directory  
                                                              
          
          In PDOConnection.php line 27:
                                                              
            SQLSTATE[HY000] [2002] No such file or directory  
                                                              
          
          W: Script eZ\Bundle\EzPublishCoreBundle\Composer\ScriptHandler::clearCache handling the symfony-scripts event terminated with an exception
          W: 
          W:                                                                                    
          W:   [RuntimeException]                                                               
          W:   An error occurred when executing the "'cache:clear --no-warmup'" command:        
          W:                                                                                    
          W:                                                                                    
          W:                                                                                    
          W:                                                                                    
          W:   In AbstractMySQLDriver.php line 93:                                              
          W:                                                                                    
          W:     An exception occurred in driver: SQLSTATE[HY000] [2002] No such file or dir    
          W:     ectory                                                                         
          W:                                                                                    
          W:                                                                                    
          W:   In PDOConnection.php line 31:                                                    
          W:                                                                                    
          W:     SQLSTATE[HY000] [2002] No such file or directory                               
          W:                                                                                    
          W:                                                                                    
          W:   In PDOConnection.php line 27:                                                    
          W:                                                                                    
          W:     SQLSTATE[HY000] [2002] No such file or directory                               
          W:                                                                                    
          W: 
          W: install [--prefer-source] [--prefer-dist] [--dry-run] [--dev] [--no-dev] [--no-custom-installers] [--no-autoloader] [--no-scripts] [--no-progress] [--no-suggest] [-v|vv|vvv|--verbose] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--apcu-autoloader] [--ignore-platform-reqs] [--] [<packages>]...
          W: 
        
        E: Error building project: Step failed with status code 1.
  
      E: Error: Unable to build application, aborting.
  
  
  To git.de-2.platform.sh:g67zz6x5xejlg.git

Any idea on what could be caousing this? does this bundle add something related to the clear cache process?
thank you.

Is SEO data available for headless response?

I was wondering if I request some content type in headless mode, will Nova SEO data be available in JSON response?

Default links location from paramater

The ability to specify the href location id in a default_link as an parameter should be supported. This would help multi-site setup and being able to globally define the href to the default location id.

Implement autowiring

Master is now eZ 2.1+, then we have locked the kernel to ^7.1 and also php 7.1.

Then we have symfony 3.4, it would be great to remove some code and use autowiring.

Variable "nova_ezseo" does not exist.

The bundle works perfect in dev.
But in production I get this error.
Variable "nova_ezseo" does not exist.

500 Internal Server Error - Twig_Error_Runtime

Stack Trace

in vendor/novactive/ezseobundle/Resources/views/seometas_metaslinks.html.twig at line 2 -

<meta http-equiv="Content-Type" content="text/html; charset=utf-8"/>
{% for name, content in nova_ezseo.default_metas %}
    {% if content is not empty %}
        <meta name="{{ name }}" content="{{ content }}"/>
    {% endif %}
{% endfor %}

If I debug $this->get('ezpublish.config.resolver')->getParameter('fieldtype_metas', 'nova_ezseo') in test Controller I get expected output.

Asset should support package/ezdesign

Using default links and specify an asset as the href, should be able to specify package name to support packages and ezdesign.

Use consistent, fully-qualified URLs

Hello,

Sitemap is giving us a relative path when it should give absolute path
(ref: https://support.google.com/webmasters/answer/183668?hl=en)

It return:

<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">
    <url>
        <loc>/Alianzas/Ingram-Micro-Chile</loc>
        <lastmod>2017-02-08T19:16:13+00:00</lastmod>
    </url>
</urlset>

When it should return:

<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">
    <url>
        <loc>http://localhost:8000/Alianzas/Ingram-Micro-Chile</loc>
        <lastmod>2017-02-08T19:16:13+00:00</lastmod>
    </url>
</urlset>

In this file https://github.com/Novactive/NovaeZSEOBundle/blob/develop-ezplatform/Controller/SitemapController.php#L166

We should use:

$url = $this->generateUrl( $location, [ ], UrlGeneratorInterface::ABSOLUTE_URL );

Instead of

$url = $this->generateUrl( $location, [ ], true );

The same for the line https://github.com/Novactive/NovaeZSEOBundle/blob/develop-ezplatform/Controller/SitemapController.php#L190

I made a pull request.

Vincent

Remove the code related to eZ 1.x

Again we are using semver, we are locked kernel 7.1 we should remove the code related to eZ 1.x.

Images in Sitemap

After installing the bundle, I have no images in my sitemap.xml. I mean <image:loc> tags. Is it something missing in my configuration, or a feature in the bundle ?

Image url is broken

When the image url is too long, i get this url in the meta:

The service "novactive.fieldtype.novaseometas.indexable.unindexed" has a dependency on a non-existent parameter "ezpublish.fieldtype.indexable.unindexed.class".

The service "novactive.fieldtype.novaseometas.indexable.unindexed" has a dependency on a non-existent parameter "ezpublish.fieldtype.indexable.unindexed.class". Did you mean one of these: "ezpublish.fieldtype.ezdatetime.class", "ezpublish.fieldtype.ezinteger.class", "ezpublish.fieldtype.ezselection.class", "ezpublish.fieldtype.ezxmltext.class", "ezpublish.fieldtype.ezbinaryfile.converter.class", "ezpublish.fieldtype.ezdatetime.converter.class", "ezpublish.fieldtype.ezdate.converter.class", "ezpublish.fieldtype.eztime.converter.class", "ezpublish.fieldtype.ezemail.converter.class", "ezpublish.fieldtype.ezfloat.converter.class", "ezpublish.fieldtype.ezinteger.converter.class", "ezpublish.fieldtype.ezimage.converter.class", "ezpublish.fieldtype.ezisbn.converter.class", "ezpublish.fieldtype.ezkeyword.converter.class", "ezpublish.fieldtype.ezmedia.converter.class", "ezpublish.fieldtype.eztext.converter.class", "ezpublish.fieldtype.ezurl.converter.class", "ezpublish.fieldtype.ezuser.converter.class", "ezpublish.fieldtype.ezpage.converter.class", "ezpublish.fieldtype.eznull.converter.class", "ezpublish.fieldtype.ezpage.zone.class", "ezpublish.fieldtype.ezrichtext.renderer.class"?

Exception is thrown after merging with #18 on eZ Publish 5.4.5.

Metas aren't generated just after the attribute class is added

The ez_is_field_empty should be avoid and the loop inside the ezfield template should loop on the fallback configuration instead of the table rows which are empty.

Ignore invalid arguments to "sitemap_excludes" options

If you give an invalid content type identifier to "sitemap_excludes", the entire sitemap throws an error about a missing content type. This means that in prod mode, the sitemap returns 404. (It might be the same with "locations" and "subtrees", but I haven't tried).

Testing if the content type identifier is a valid content type before adding it to the search criterion would make the sitemap less fragile.

Error while installing on last eZ Platform

When I try to install the extension, I got the following error:

$ php ezpublish/console ezpublish:legacybundles:install_extensions

Fatal error: Class 'eZ\Publish\Core\Repository\NameSchemaService' not found in /home/dp/dev/NovaeZSEOBundle/Core/MetaNameSchema.php on line 28
[2015-11-06 17:03:16] php.CRITICAL: Fatal Error: Class 'eZ\Publish\Core\Repository\NameSchemaService' not found {"type":1,"file":"/home/dp/dev/NovaeZSEOBundle/Core/MetaNameSchema.php","line":28,"level":-1,"stack":[]} 

Fatal error: Cannot redeclare class eZ\Publish\Core\Repository\Helper\NameSchemaService in /home/dp/dev/PlatformUIBundle/vendor/ezsystems/ezpublish-kernel/eZ/Publish/Core/Repository/Helper/NameSchemaService.php on line 43

Error when 404 page

NovaeZSEOBundle/Resources/views/seometas_metaslinks.html.twig

Line 39 in 7d86e38

    
           <link rel="alternate" hreflang="{{ lang|getposixlocale_novaseometas }}" href="{{ url( route ) }}" />

I had a case where ez_route returned a null route and so it returns an error and it is in the case of an exception page 404

Exception is thrown when getting image variation for metas

I'm using NovaeZSEOBundle 2.1.1 with eZ 6.13.4.

In dev environment I get the following error when requesting a website:
An exception has been thrown during the rendering of a template ("Notice: Trying to get property 'id' of non-object") in "NovaeZSEOBundle:fields:novaseometas.html.twig".

In getVariation function (MetaNameSchema.php) the variation is fetched with "new VersionInfo()" as version info parameter. In getCacheKey function of AliasGeneratorDecorator class this leads to an error, as $versionInfo->getContentInfo()->id is called.

As solution a class variable could be added in constructor of MetaNameSchema ($this->versionInfo) which is then set in resolveMeta function ($this->versionInfo = $content->getVersionInfo();) and could be used in getVariation function.

What do you think?

exception adding facebook meta og:xxx

This the exception i get:

I add isset to the condition
if ( isset($configuration[$meta->getName()]) )

Editing an object relation or layout block causes the metadata field to lose its value

Steps

Have an object with properly filled metadata
Edit object
Try adding/removing any object relation field

Expected result
Metadata field data is kept in the process

Actual result
Metadata field data is lost

[Config Fixed it]Error when working with ezplatform v2.2.2

Hello, i've just upgraded to ezplatform v2.2.2 which adds the eZ EzPlatformStandardDesignBundle to the game.
I try to render de field from a custom template i have like this:

{% if content is defined and content.fields[nova_ezseo.fieldtype_metas_identifier] is defined %}    {{ ez_render_field( content, nova_ezseo.fieldtype_metas_identifier ) }}{% endif %}

but i get this error

An exception has been thrown during the rendering of a template ("Cannot find 'novaseometas_field' template block.").

If i comment out the bundle and the realted config in ezplatform.yml, then it works again. Any idea?

Preview of new translation leads to error

ezsystems/ezpublish-kernel v7.5.16
novactive/ezseobundle 4.2.0

When creating a new translation of content with seometas-field preview shows error.
When navigating back this message appears:

An exception has been thrown during the rendering of a template ("Could not find 'Content' with identifier 'array ( 'id' => 426, 'languages' => array ( 0 => 'eng-GB', ), 'versionNo' => NULL, )'") in "NovaeZSEOBundle:fields:novaseometas.html.twig". [in vendor/twig/twig/src/Template.php:196]

I think content can't be loaded in function computeMetas of bundle/Twig/NovaeZSEOExtension.php.

Could fix it by changing code to:

       try{
            $content      = $this->eZRepository->getContentService()->loadContentByContentInfo($contentInfo, $languages);
        } catch(NotFoundException | UnauthorizedException $e){
            return '';
        }

Error during installing

Hi,

I have the following error during instalation:

  [Symfony\Component\Config\Exception\FileLoaderLoadException]
  There is no extension able to load the configuration for "nova_ezseo" (in C:\PhpstormProjects\dbs-website\app/config\config.yml). Looked for namespace "nova_ezseo", found "frame
  work", "security", "twig", "monolog", "swiftmailer", "assetic", "doctrine", "sensio_framework_extra", "stash", "hautelook_templated_uri", "liip_imagine", "fos_http_cache", "ezpu
  blish", "ez_search_engine_legacy", "ez_io", "ez_publish_rest", "ez_platformui", "ez_systems_ez_support_tools", "nelmio_cors", "white_october_pagerfanta", "oneup_flysystem", "ez_
  systems_platform_installer", "ez_systems_repository_forms", "ez_search_engine_solr", "content_on_the_fly", "bazinga_js_translation", "jms_translation", "white_october_breadcrumb
  s", "sonata_intl", "hwi_oauth", "crevillo_ez_social_login", "novae_zseo" in C:\PhpstormProjects\dbs-website\app/config\config.yml (which is being imported from "C:\PhpstormProje
  cts\dbs-website\app/config/config_prod.yml").

If you look at this, at the final you see that the configuration should be "novae_zseo" (typing error in the project?)

So, I decided to use this:

novae_zseo:
    system:
        default:
            default_metas:
                author: "eZ Community Bundle Nova eZ SEO Bundle"
                copyright: ~
                generator: "eZ Platform"
                MSSmartTagsPreventParsing: "TRUE"

I pass the error but have another one:

  [Symfony\Component\Config\Definition\Exception\InvalidConfigurationException]
  The child node "fieldtype_metas" at path "nova_ezseo.system.default" must be configured.

Vincent

Missing Noindex option in Robots.txt

May there is an option that i didn't saw ?

eZ Platform 2 compatibility

Hi all,

There is a compatibility issue with the latest eZ Platform 2.

The template "novaseometas_admin.html.twig" try to access "nova_ezseo.fieldtype_metas" but this variable is an empty array and throw an exception. This is required to show the "label" of the meta field.

Any help please :'( @Plopix

Sitemap generation redirect to /login

Hi All,

My sitemap.xml works fine but when I configure the "sitemap_excludes", i'm redirected to /login/

nova_ezseo:
    system:
        default:
            sitemap_excludes:
                locations: [2]
                subtrees: [43, 87, 5, 48]
                contentTypeIdentifiers: ['image']

Is this a bug? Or I am doing something wrong?

Thanks,

Vincent

Disable alternate on Siteaccess not readable

Hi,

When you add a new siteaccess (work in progress) for a new language, it appears on alternate list but content is not accesible for anonymous users. Is it posible to disable this behaviour?

Thanks

Error while clearing caches after activating the bundle

Hello. i'm trying to use this bundle but i have a error when i try to clear caches.

Here's the thing. I install the bundle and i configure it like this

nova_ezseo:
    system:
        default:
            default_metas:
                author: "xxxxx"
                copyright: ~
                generator: "eZ Platform"
            fieldtype_metas_identifier: "metas"
            fieldtype_metas:
                title:
                    label: 'Title'
                    default_pattern: "<title|name>"
                description:
                    label: 'Description'
                    default_pattern: "<description|short_description|title|name>"
                keywords:
                    label: 'Keywords'
                    default_pattern: ~

now, when i try to clear caches or execute the command to add the fields to the db i get this error

./bin/console nova_ezseo:addnovaseometasfieldtype --identifier=folder

In ContentTypeDomainMapper.php line 64:
                                                                                                                                                                                                                  
  Type error: Argument 1 passed to eZ\Publish\Core\Repository\Helper\ContentTypeDomainMapper::__construct() must implement interface eZ\Publish\SPI\Persistence\Content\Type\Handler, instance of eZ\Publish\Cor  
  e\Persistence\Cache\ContentLanguageHandler given, called in /var/www/html/project/ezplatform/vendor/novactive/ezseobundle/Core/MetaNameSchema.php on line 121

Do i miss some config or anything?

Here are the relevant packages i'm using in my installation

composer show | grep ez
ezsystems/behatbundle                   v6.5.3             Behat bundle for help testing eZ Bundles and projects
ezsystems/ez-support-tools              v0.2.1             Providing information about the system eZ Platform/Studio is running on
ezsystems/ezplatform-admin-ui           v1.1.1             eZ Platform Admin v2
ezsystems/ezplatform-admin-ui-assets    v2.0.0             External assets dependencies for EzPlatform AdminUI
ezsystems/ezplatform-admin-ui-modules   v1.1.1             External assets dependencies for EzPlatform AdminUI
ezsystems/ezplatform-design-engine      v1.2.0             Design fallback mechanism for eZ Platform
ezsystems/ezplatform-http-cache         v0.6.1             HTTP cache handling for eZ Platform.
ezsystems/ezplatform-solr-search-engine v1.5.2             Solr search engine implementation for eZ Platform
ezsystems/ezpublish-kernel              v7.1.1             Kernel used by ezsystems/ezplatform and derivatives. Provides the Content Repository, its APIs, and the application's Symfony framework integration.
ezsystems/privacy-cookie-bundle         dev-master cf326a7 Privacy cookie banner integration bundle into regular Symfony 2.x application (supports eZ Publish/eZ Platform)
ezsystems/repository-forms              v2.1.1             Use Symfony forms with eZ Platform repository objects
kaliop/ezloremipsumbundle               1.4                Kaliop eZ-Lorem-Ipsum Bundle
kaliop/ezmigrationbundle                5.1.1              Kaliop eZ-Migration Bundle
novactive/ezseobundle                   2.2.0              Novactive eZ SEO Bundle is an eZPlatform/eZStudio bundle for SEO simplications. metas, sitemaps, robots.txt, etc.

Any idea?

Bundle not compatible with the 2.1-rc1 ez platform version

Hey !

Unfortunately the bundle is not compatible to the latest ez platform version (ezpublish-kernel version 7.1) and returns the following error:

  Type error: Argument 1 passed to eZ\Publish\Core\Repository\Helper\ContentTypeDomainMapper::__construct() must implement interface eZ\Publish\SPI\Persistence\Content\Type\Handler, instance of eZ\Publish\  
  Core\Persistence\Cache\ContentLanguageHandler given, called in /var/www/html/project/ezplatform/vendor/novactive/ezseobundle/Core/MetaNameSchema.php on line 121

2.2 having issues on 1.13

See: https://jira.ez.no/browse/DEMO-165

From issue:

Novactive eZ SEO causes exception when creating content item

Steps:

Log in to admin UI.

Go to Content / Content structure.

Click Create.

Choose e.g. Folder.

Issue: Exception occurs in browser console "No implementation of Y.eZ.FieldEditView for novaseometas". At the bottom the 'seo' section is empty.

If questions, ask on JIRA issue, I'm just passing the message here, on our side we "fixed" it by downgrading to 2.1: ezsystems/ezplatform-ee-demo@1e428b3

Add "sitemap_includes" param in config

"sitemap_excludes" is great, but if you only want to include a small subset of classes/trees in your sitemap, it can get extremely long.

It would be great if there were a "sitemap_includes" parameter, too.

novactive / novaezseobundle Goto Github PK

novaezseobundle's People

Contributors

Stargazers

Watchers

Forkers

novaezseobundle's Issues

Issue description:

Steps to reproduce:

What I expect to see:

Worth mentioning:

Recommend Projects

Recommend Topics

Recommend Org