Code Monkey home page Code Monkey logo

nouns-monorepo's People

Contributors

0xfloyd avatar 5oc avatar badublanc avatar bcjgit avatar brandonleboeuf avatar c6y avatar cdt-eth avatar cryptoseneca avatar davidbrai avatar defnullx avatar domhofmann avatar eladmallel avatar ericdevito avatar fiveoceans-dev avatar gitblamecarrot avatar gremplin avatar lastpunk9999 avatar modrovsky avatar pedropregueiro avatar pixelzpls avatar punk4156 avatar ragebrahimi avatar ripe0x avatar ryespresso avatar saw-mon-and-natalie avatar solimander avatar spennyp avatar vapeape4464 avatar volkyeth avatar yitongzhang avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

nouns-monorepo's Issues

Bid UX improvements

Key details are missing from the bidding experience:

  • clear bid after successful bid
  • require minimum bid amount
  • add signifier for min bid

General UX improvements

  • more descriptive copy for errors during bidding
  • add signifier nouns to success modals
  • add signifier to Documentation sections to signal ability to be opened
  • add pinched finger img to "insufficient bid amount" alert
  • When saving nouns.wtf as a home page icon on iPhone, react logo shows up as the icon. Update React to Nouns logo.

Optional Vote Reason & Bot Notification

Add an optional text field to the vote modal that enables Nouners to include a reason for the given vote. This reason should be surfaced via the Discord bot in the New Proposal Vote notification.

Implementation Details:

  • If a reason is provided, the castVoteWithReason function must be used, rather than castVote.
  • reason: String must be added to the subgraph's Vote entity.
  • The new reason property value should be consumed by the formatNewGovernanceVoteText function to expose the reason to Discord.

Governance UI

Build a Uniswap-esque Governance UI into nouns-webapp.

The initial implementation will:

  • Use default bootstrap styles
  • Match the functionality of Uniswap's governance UI
  • Be accessible at the route /vote

DAO Data

Add component to display DAO treasury balance and member count.

WSL2 on Win X 21H! yarn install fails - if this is not supported - delete issue

Cloned the repo in Ubuntu 20.04.2 (which is a WSL2 linux instance) and proceedd with the Yarn (install) ...

make: Entering directory '/home/comtechnet/nouns/node_modules/node-hid/build'
CC(target) Release/obj.target/hidapi-linux-hidraw/hidapi/linux/hid.o
AR(target) Release/obj.target/hidapi-linux-hidraw.a
COPY Release/hidapi-linux-hidraw.a
CXX(target) Release/obj.target/HID-hidraw/src/HID.o
../src/HID.cc:71:5: warning: dynamic exception specifications are deprecated in C++11 [-Wdeprecated]
71 | throw(JSException);
| ^~~~~
../src/HID.cc:74:5: warning: dynamic exception specifications are deprecated in C++11 [-Wdeprecated]
74 | throw(JSException);
| ^~~~~
../src/HID.cc:156:3: warning: dynamic exception specifications are deprecated in C++11 [-Wdeprecated]
156 | throw(JSException)
| ^~~~~
../src/HID.cc:167:3: warning: dynamic exception specifications are deprecated in C++11 [-Wdeprecated]
167 | throw(JSException)
| ^~~~~

IS THIS SUPPORTED or expected? If NOT - just close the issue and I'll move on - Thanks!

Redirect /auction/:id => /noun/:id

A user noted on Discord that to maintain backwards compatibility we should ensure that /auction/:id links automatically redirect to /noun/:id. Currently, they go to the 404 page.

Playground trait selectors do not work (bug)

Description

Generating nouns based on traits when selecting background, body, accessory, head, or glasses does not work

Expected result

When you choose a trait, it should reflect when generating nouns
Screen Shot 2022-02-19 at 11 52 37 PM

Replicate issue

  1. Go to https://nouns.wtf/playground on latest Google Chrome (OSX)
  2. Select a trait you want to generate
  3. Click generate and watch the trait not appear correctly

Bid History

Bidding activity is a key part of the bidding experience. Currently, no bidding history is available in the auction UI.

Warn user if rebidding themselves

Currently, if you're the lead bidder, you can create a new bid which doesn't seem like an optimal strategy. We should probably warn users if they are about to bid while they're the leader. They'd still be able to click through the warning but just in case.

The nouns-webapp is failed to compile

Failed to compile.

/nouns-monorepo/packages/nouns-webapp/src/components/Bid/index.tsx
TypeScript error in /nouns-monorepo/packages/nouns-webapp/src/components/Bid/index.tsx(73,5):
Argument of type 'NounsAuctionHouse' is not assignable to parameter of type 'Contract'.
  Types of property '_deployedPromise' are incompatible.
    Type 'Promise<import("/nouns-monorepo/node_modules/@ethersproject/contracts/lib/index").Contract>' is not assignable to type 'Promise<import("/nouns-monorepo/node_modules/@usedapp/core/node_modules/@ethersproject/contracts/lib/index").Contract>'.
      Type 'import("/nouns-monorepo/node_modules/@ethersproject/contracts/lib/index").Contract' is not assignable to type 'import("/nouns-monorepo/node_modules/@usedapp/core/node_modules/@ethersproject/contracts/lib/index").Contract'.
        Types of property '_runningEvents' are incompatible.
          Type '{ [eventTag: string]: RunningEvent; }' is not assignable to type '{ [eventTag: string]: RunningEvent; }'. Two different types with this name exist, but they are unrelated.
            'string' index signatures are incompatible.
              Type 'RunningEvent' is not assignable to type 'RunningEvent'. Two different types with this name exist, but they are unrelated.
                Types have separate declarations of a private property '_listeners'.  TS2345

    71 |
    72 |   const { send: placeBid, state: placeBidState } = useContractFunction(
  > 73 |     nounsAuctionHouseContract,
       |     ^
    74 |     AuctionHouseContractFunction.createBid,
    75 |   );
    76 |   const { send: settleAuction, state: settleAuctionState } = useContractFunction(

node: v16.13.0

Link to specific Noun

As a user I want to be able to link to nouns.wtf/noun/:id and have the specified Noun be shown.

Browse previous auctions

Add functionality to allow users to browse through previous auctions and see:

  • noun
  • winning bid
  • bid history

HistoryCollection component with few auctions

When there are less than 8 auctions completed the HistoryCollection doesn't work correctly. This ticket involves adjusting the component so that it renders the recent components but fills in any additional with "fake Nouns".

Optionally: A/B test with art to see if they want the phantom noun instead

Just settled Noun profile showing wrong data

Immediately after auction settlement a user found that it took a page reload for the noun profile of the most recently auctioned noun to show correct winner / bid history / activity info.

Design tweaks on proposals page

  1. Add 1px divider in border color on mobile above the treasury description (unless we choose to nix it) — where there is a yellow highlight

  2. A smaller font size (or using PT Root UI) on the USD value to create hierarchy (where the ETH value is the “parent”) — where there is a green highlight

  3. A period and traditional 1 or 2char space delimiter where there is the proposal numbering on cards, to read and look more natural (a la traditional

  4. ) — where there is a blue highlight

Fix dev's code smell comments in NavBar update

Address 2 non-blocking comments from dev on #337

  1. packages/nouns-webapp/src/components/NavBarTreasury/index.tsx

Smell here: effectively duplicate code translating a NavBarButtonStyle to classes with packages/nouns-webapp/src/components/NavBarButton/index.tsx. Should be addressable with a single helper and a common module.

Doesn't need to block promotion but should be addressed later.

  1. packages/nouns-webapp/src/components/NavWallet/index.tsx

Smell here: effectively duplicate code translating a NavBarButtonStyle to classes with packages/nouns-webapp/src/components/NavBarButton/index.tsx. Should be addressable with a single helper and a common module. Doesn't need to block promotion but should be addressed later.

Include stETH in treasury balance

The treasury balance in the nav bar currently only displays ETH held, but as of this date ~10% of the treasury is held in stETH.

Since stETH has a constant conversion to ETH, it might be good enough to convert stETH shares balance into ETH and combine that with the ETH balance to display a combined view of the treasury. The stETH shares balance includes validator fees so is an accurate representation of the ETH exposure of the DAO.

If additional assets are held by the treasury we can update our approach as needed.

Delegating to address(0) removes votes forever

@samczsun on Discord:

function delegate(address delegatee) public {
return _delegate(msg.sender, delegatee);
}

you can delegate to the zero address here, causing the votes to be burned and resulting in a self-dos because you won't be able to transfer your noun anymore. could happen if someone assumed that this behaved like comp delegate in the sense that to undelegate from someone, just set to zero

Increase arrow size on mobile auction page

Context

A user pinged us in the Discord mentioning that the arrows on the mobile auction page were too small to effectively page between Nouns. @cryptoseneca confirmed that the buttons are "a little small" on iPhone 12.

Deliverables

  • Experimental PR with increased button sizes for the mobile auction page

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.