Hi,

I have used this tool a number of times, and find it very useful. Thanks for taking the time to create this!

I recently decided to run this from my windows machine for a number of reasons and found that the set-nvram.sh scripts were unnusable due to the EOL characters.

I played around a bit and found a simple change to your code gets rid of the problem.

Simple change line 404 from:
with open(args.output, 'w') as outfile:
to:
with open(args.output, 'w', newline='\n') as outfile:

I don;t know if you wish to make this change in your official version, but it worked for me.

Thanks again!

Keith.

Hi,

I'm getting this error when trying to run tomato-nvram.py:

Traceback (most recent call last):
  File "./tomato-nvram.py", line 416, in <module>
    main(sys.argv[1:])
  File "./tomato-nvram.py", line 402, in main
    config = Config(args.config)
  File "./tomato-nvram.py", line 362, in __init__
    self.names, patterns = zip(*((name, section['pattern']) for name, section in parser.items() if 'pattern' in section))
ValueError: not enough values to unpack (expected 2, got 0)

I had it until I tried to run tomato-nvram.py. I’m not sure how or with what. I’ve tried power shell, cmd and terminal. Nothing works. I’m obviously new to this so please be aware. Please help.

Last line of the "Use" (should it be "Usage"?) section says

View/Edit output set-nvam.sh to choose which settings to reapply.

but there is no information about what should be done with the output file. I'm guessing it should be uploaded to some directory on the router file system and then you should open a shell console on the router and execute the file. It would be nice if the readme.md had at least an outline of what steps to take.

Also, since this script is likely to be use in connection with a firmware upgrade of the router, maybe that (optional) step could be included in the instructions.

I couldn't login using ssh while the old value for sshd_hostkey was being used. deleting and forcing it to regenerate fixed it .

dnsmasq_custom=address=/jb.domain.net/192.168.10.10
address=/weather.domain.net/192.168.10.10
address=/speedtest.domain.net/192.168.10.10
address=/phpmyadmin.domain.net/192.168.10.10
address=/mythweb.domain.net/192.168.10.10
address=/camera1.domain.net/192.168.10.41
address=/camera2.domain.net/192.168.10.42
address=/camera3.domain.net/192.168.11.117

Turned into a single line. It didn't see the lines after it.

nvram set address=/speedtest.domain.net/192.168.10.10

Open Putty
Connect to Tomato
nano nvram.sh
....paste output....
ctrl^x + y
chmod +x nvram.sh
./nvram.sh

I noticed that the generated output in the set-nvram.sh file was missing many lines of my dnsmasq custom configuration text.

For example, my nvram.txt (input):

dnsmasq_custom=
#whitelist example for dns rebinding
rebind-domain-ok=/example.direct/

#static dns entries
address=/my-router/192.168.1.1
address=/example-service1/192.168.1.2
address=/example-service2/192.168.1.2
address=/example-service3/192.168.1.2
address=/example-service4/192.168.1.2
address=/example-service5/192.168.1.2
address=/example-service6/192.168.1.2
address=/example-service7/192.168.1.2
address=/example-service8/192.168.1.2
address=/example-service9/192.168.1.2
address=/example-service10/192.168.1.2
address=/example-service11/192.168.1.2
address=/example-service12/192.168.1.2
address=/example-service13/192.168.1.2
address=/example-service14/192.168.1.2

#static dns entries as work around for modem lack of nat loopback support
#address=/example.example.net/99.99.999.99
#address=/example2.example.net/99.99.999.99
#address=/example3.example.net/99.99.999.99

For example, my defaults.txt (input):

dnsmasq_custom=

For example, my set-nvram.sh (output):

# DNS
nvram set dnsmasq_custom="
#whitelist example for dns rebinding
rebind-domain-ok=/example.direct/

#static dns entries"