nos / api-functions Goto Github PK

Expected Behavior

The method testInvoke should resolve the Promise what the Smart Contract (SC) returns.

Code which calls this method:

const bookmarks = await this.props.nos.testInvoke('0xe973b31b5d8cf928916f2a30a4611b2bed31af7e', 'GetBookmarks', [address])

The address is the CoZ wallet address (AK2nJJpJr6o664CWJKi1QRXjqeic2zRp8y).

Current Behavior

[DApp] Error: Invocation failed for operation "GetBookmarks" on "0xe973b31b5d8cf928916f2a30a4611b2bed31af7e"

Possible Solution

We tried multiple encodings for the arguments passed to testInvoke (no result):

# Code example from Discord (@DrPpr)
const addressToScriptHash = (address) => unhexlify(u.reverseHex(wallet.getScriptHashFromAddress(address)))

# Code example from dapp-neoblog
str2hexstring(address)

Steps to Reproduce (for bugs)

Details: https://github.com/Cryptopians/nos-bookmark-dapp/blob/master/README.md#setup

Smart contract: https://github.com/Cryptopians/nos-bookmark-dapp/blob/master/contracts/nos_bookmark.py
JavaScript: https://github.com/Cryptopians/nos-bookmark-dapp/blob/master/src/containers/Bookmarks.js#L25

We also tried to remove/uncomment the CheckWitness in the smart contract.

Context

• Running the dApp from the client
• TestInvoke via neo-python works as expected

Your Environment

• Version used: latest of all dependencies
• Environment name and version: node v8.11.1
• Operating System and version (desktop or mobile): Desktop macOS 10.12.6 (Sierra), Chrome

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper App’s white list on Github. You'll find this list on your repo or organization’s settings page, under Installed GitHub Apps.

Expected Behavior

Removing the lib folder without losing the ability to use the library

Current Behavior

The lib folder pollutes the repo and PR requests with generated code

Possible Solution

?? Refer to NeonJS?

Additional context

Your Environment

• nOS Client version used:
• Environment name and version
  • Node version:
  • NPM version:
  • Yarn version:
• Operating System and version (desktop or mobile):

Expected Behavior

You should only be able to supply numerical values to asset transfer amounts, which are smaller than what's available in your account.

Current Behavior

Expected Behavior

Greenkeeper needs a CI and tests to work

Current Behavior

There is no CI, there are no tests 🤷‍♂️

Steps to Reproduce

1. There's no travis/cici URL...

Possible Solution

Add jest, babel-jest, codecov, ... and a travis ci setup

Additional context

This fixes #2

Your Environment

• nOS Client version used:
• Environment name and version
  • Node version:
  • NPM version:
  • Yarn version:
• Operating System and version (desktop or mobile):

Describe the solution you'd like and the expected behavior

Rollup is the best bundler for NPM packages and should be used instead of vanilla Babel.
Typescript is a nice addition that can be quickly integrated at this point.

Is your feature request related to a problem? Please describe.

Possible implementation / References

Use rollup, typescript and rollup-plugin-typescript

Additional context

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Datasource	Name	Replacement PR?
npm	codecov
npm	tslint

Rate-Limited

These updates are currently rate-limited. Click on a checkbox below to force their creation now.

• chore(deps): update dependency @types/jest to v24.9.1
• chore(deps): update dependency prettier to v3
• chore(deps): update dependency rimraf to v5
• chore(deps): update dependency tslint to v6
• chore(deps): update dependency typescript to v5
• 🔐 Create all rate-limited PRs at once 🔐

Edited/Blocked

These updates have been manually edited so Renovate will no longer make changes. To discard all commits and start over, click on a checkbox.

• chore(deps): update dependency codecov to v3.7.1 [security]
• chore(deps): update dependency rimraf to v3.0.2
• chore(deps): update dependency prettier to v1.19.1
• chore(deps): update dependency ts-jest to v24.3.0
• chore(deps): update dependency tslint to v5.20.1
• chore(deps): update dependency tslint-plugin-prettier to v2.3.0
• chore(deps): update dependency typescript to v3.9.10
• fix(deps): update dependency prop-types to v15.8.1 (prop-types, @types/prop-types)

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): update enzyme (@types/enzyme, enzyme, enzyme-adapter-react-16, enzyme-to-json)
• chore(deps): update react monorepo (@types/react, react, react-dom)
• chore(deps): update jest monorepo to v29 (major) (@types/jest, jest, ts-jest)
• chore(deps): update react monorepo to v18 (major) (@types/react, react, react-dom)
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

Describe the solution you'd like and the expected behavior

• The possible values of each config are known
• This can be used to offer prop-types like validation

Is your feature request related to a problem? Please describe.

/

Possible implementation / References

• Extend executor to validate the config based on the key
• Type/value/prop definitions for autocomplete in IDE's

Additional context