northernwidget / ds3231_logger Goto Github PK

Issue:

Device alarm fails to account for leap year, so ends up missing one day of events. At rollover from 02/28 -> 02/29 the device instead sets the alarm from 02/28 -> 03/01 (since it is not accounting for the existence of 02/29 due to leap year), so device should trigger, but not until a day later.

Potential Solution:

Implement conditional testing for leap year (see conditions), use this condition to determine the number of days in February to prevent pre-mature rollover for leap years

Patch:

Include array of next 10 leap years, test year value against list, if year value is member of list, then take modulus so that February contains proper number of days.
Hopefully this will push the problem off until I am enjoying my cushy Fijian retirement...

Problem:

It has been reported that when using a logging interval other than 1 minute (software set), that the system fails to set a new alarm when the month rolls over (additional testing required)

Potential Solution:

Investigate the calculation and setting procedure and find why the month is not incremented (suspected cause)

Alarm seems not to get set/triggered when the time is set to year 2000, test and verify this is the issue, if so find a fix

Currently negative temperature calculation rolls over, example (real data):

Fix calculation to allow for negative outputs (first glance looks like a 2s complement to float issue?)