noother / nimda3 Goto Github PK

No clue about coding. How to fix this? What am I doing wrong?

PHP Fatal error: Uncaught Error: Call to undefined function mb_internal_encoding() in /home/luca/Schreibtisch/nimda/Nimda3/core/defaults.php:3 Stack trace: #0 /home/luca/Schreibtisch/nimda/Nimda3/core/Nimda.php(3): require_once() #1 /home/luca/Schreibtisch/nimda/Nimda3/nimda(3): require_once('/home/luca/Schr...') #2 {main} thrown in /home/luca/Schreibtisch/nimda/Nimda3/core/defaults.php on line 3 luca@laptop-luca:~/Schreibtisch/nimda/Nimda3$

Thy

I dont know why you decided to change from mysql to mysqli, Maybe it was because of the php warnings, maybe it was because you read up in why MySQL functions are being removed.

the fact is mysql and methods used to sanitize are not safe, PDO and MySQLi are safe if you use prepared statements.
example

$sql = "
    INSERT INTO
        `memory` (`name`, `type`, `target`, `value`, `created`, `modified`)
    VALUES (
        '".addslashes($name)."',
        '".addslashes($type)."',
        '".addslashes($target)."',
        '".addslashes($sql_value)."',
        NOW(),
        NOW()
)";

can be better sanitized with

$sql = "
    INSERT INTO `memory` (`name`, `type`, `target`, `value`, `created`, `modified`)
    VALUES (?,?,?,?,NOW(),NOW())
";
$this->MySQL->bind_param($name, $type, $target, $sql_value);// the variables can be assigned anytime after or before the prepare untill executed
// More code?
$this->MySQL->execute();

I would help you out but you state development is exclusive by you, BTW Im building a Twitch bot usiong you bot since nimda2 is outdated as off php 5.6 :P

Don't know if it was like that before but it doesn't work anymore.