nomifactory / extendedcrafting Goto Github PK

Place the funnel under the workbench
It is possible to manufacture items without damage

Description:
After updating from 1.6.0 to 1.6.1, existing recipes added in config/extendedcrafting under S:custom_singularities with a custom catalyst under S:default_catalyst do not work anymore. We tried the workarounds in this report (#7), but couldn't make it work.

Steps to reproduce:

1. Add some custom Singularities like
   100;clay;minecraft:clay_ball;AEBCCF
2. Add a custom catalyst (in Divine Journey 2, we have a custom item - not sure if this affects the outcome)
   S:default_catalyst=contenttweaker:singularification_catalyst:0
3. Launch the game.
4. Try to craft it - it doesn't consume the input item.

(We're not sure if updating from 1.6.0 to 1.6.1 caused this or not. It's possble that Singularities added in 1.6.0 do not work in 1.6.1 anymore.)

Pictures:

At least the recipe is beign recognized, because the Singularity icon does show up at the top:

Mod version: 1.6.1 (I'm aware that 1.7.0 is out, but the changelog doesn't mention anything like this)

Description: CraftTweaker adds some useful features called "Item Transformers" that can be applied in any regular 3x3 craft. (https://docs.blamejared.com/1.12/en/Vanilla/Items/Item_Transformers)

For example, .noReturn() makes it so items that have durability or Buckets that would otherwise stay in the crafting window get fully consumed.

I have also tried .reuse() and .transformDamage(), but neither seems to work.

Example script:
(This is from Divine Journey 2)

mods.extendedcrafting.TableCrafting.addShaped(<mysticalagriculture:master_infusion_crystal>,
[[null,null,null,null,<alchemistry:ingot:45>,null,null,null,null],
[null,null,null,<alchemistry:ingot:45>,<alchemistry:ingot:45>,<alchemistry:ingot:45>,null,null,null],
[null,null,<alchemistry:ingot:45>,<contenttweaker:zysc_baach_sheet>,<contenttweaker:zysc_baach_sheet>,<contenttweaker:zysc_baach_sheet>,<alchemistry:ingot:45>,null,null],
[null,<alchemistry:ingot:45>,<contenttweaker:zysc_baach_sheet>,<matc:supremiumcrystal>.noReturn(),<mysticalagradditions:insanium:2>,<matc:supremiumcrystal>.noReturn(),<contenttweaker:zysc_baach_sheet>,<alchemistry:ingot:45>,null],
[null,<alchemistry:ingot:45>,<contenttweaker:zysc_baach_sheet>,<alchemistry:atomizer>,<mysticalagradditions:storage:1>,<alchemistry:liquifier>,<contenttweaker:zysc_baach_sheet>,<alchemistry:ingot:45>,null],
[null,<alchemistry:ingot:45>,<contenttweaker:zysc_baach_sheet>,<matc:supremiumcrystal>.noReturn(),<mysticalagradditions:insanium:2>,<matc:supremiumcrystal>.noReturn(),<contenttweaker:zysc_baach_sheet>,<alchemistry:ingot:45>,null],
[null,null,<alchemistry:ingot:45>,<contenttweaker:zysc_baach_sheet>,<contenttweaker:zysc_baach_sheet>,<contenttweaker:zysc_baach_sheet>,<alchemistry:ingot:45>,null,null],
[null,null,null,<alchemistry:ingot:45>,<alchemistry:ingot:45>,<alchemistry:ingot:45>,null,null,null],
[null,null,null,null,<alchemistry:ingot:45>,null,null,null,null]]);

I would expect the <matc:supremiumcrystal> items to get used up due to .noReturn(), but they don't - they stay in the crafting table (or take 1 durability damage, if the config is set up so that they don't have infinite durability).

I recently installed AE2 fluid crafting rework 2.5.11 v for nomi 1.7.4a. Opening the ME crafting terminal no longer works and fails to bring up and GUI.

crash-2024-05-01_10.54.03-server.txt

The quantum compressor is currently able to accept items into it's input slot even when the cap is full while in limited input mode. Changing this behavior so that items can not be pushed into the input slot during that time would make parallelizing the quantum compressor easier.

Current and mockup behaviors

Also, while not completely necessary, changing the compressor to only be able to accept items of the type already contained within the compressor would also be a nice change to aid with parallelizing.

can you add translate name of sungularity like this i play with russian and cant transtate this
https://i.imgur.com/CZlITk7.png
this screen from original mod 1.16 idk what be on 1.12

Recipe was unchanged before i update from old Extended Crafting. Now <ore:blockAethium> is invisible as ingredient, but item still craftable if i put right items in empty slots:

I check and this item is OreDicted normally

Recipe

	var blockAethium = <ore:blockAethium>;
	recipes.remove(<environmentaltech:void_ore_miner_cont_6>);
	mods.extendedcrafting.TableCrafting.addShaped(0, <environmentaltech:void_ore_miner_cont_6>, 
	[[blockAethium, <ic2:iridium_reflector>, blockAethium], 
	[<ic2:nuclear:10>, <environmentaltech:void_ore_miner_cont_5>, <ic2:nuclear:10>], 
	[blockAethium, <ic2:iridium_reflector>, blockAethium]]);  

I also posted this to the official one, but it probably won't get fixed there because it's the 1.12.2 version.
Maybe someone here can help me.

Describe the bug

In a custom compression recipe, oredict entries are not accepted as ingredient or output.

To Reproduce
Steps to reproduce the behavior:

Try to set an oredict entry as ingredient and/or as output in a custom compression recipe

for example:
mods.extendedcrafting.CompressionCrafting.addRecipe(ore:singularityDraconium, ore:ingotDraconium, 10000, extendedcrafting:material:11, 1250000);

Expected behavior
A clear and concise description of what you expected to happen.

No errors when executing the script and the recipe working with all entries of the used oredict entry.

Screenshots / Scripts / Logs

https://pastebin.com/FprduTCZ

Versions:

Minecraft: 1.12.2
Forge: 14.23.5.2854
Cucumber: 1.12.2-1.1.3
Extended Crafting: version doesn't really matter, but have tried with official-1.5.6; omnifactory-1.6.0
and omnifactory-1.6.0.2 versions
CraftTweaker (if applicable): 4.1.20.607

I have several custom singularities. It seems like oredict ingredient stop working after one of recent updates.

This is my config:

    S:custom_singularities <
        100;quartz;minecraft:quartz_block;ffffff
        101;experience;ore:itemXP;b3f43b
        102;black_quartz;actuallyadditions:item_misc:5;202122
        103;hard_carbon_alloy;nuclearcraft:alloy:2;265e75
        104;magnesium_diboride_alloy;nuclearcraft:alloy:3;01030e
        105;thorium;nuclearcraft:ingot:3;2d2e32
        106;fluxed_electrum;redstonearsenal:material:32;f68d0e
        107;fluix;appliedenergistics2:material:7;630eb4
     >

Problem line is:

101;experience;ore:itemXP;b3f43b

This how Singularity looks like in game:

Proof that game actually have this oredicted items:

Problem that Experience Singularity doesnt have any recipes like all other custom ones do

This is a bug I've encountered on the normal mod version aswell, but if an item made with combination crafting requires a very large amount of energy in total to craft (i assume the limit is 2.147 billion), the item will never finish crafting, it will just forever keep using energy. Using Integrated Dynamics to read the nbt of the crafting core quickly, it is possible to see that the 'Progress' value constantly switches between negative and positive numbers, which I assume is because of the integer limit.

Reportedly, Packaged Ex Crafting can't encode the recipe, but it works fine when not using this fork.

This is likely caused by some changes we have made that leave PExC unable find the recipe.

If you add a combination crafting recipe with crafttweaker and you use only the core input JEI is not going to show the actual recipe but if you try the recipe it's going to work.

Maybe you could add functionality for the Extended Tables to hold Fluids and use them in crafting recipes?

Occasionally, it will just not craft anything (I only have recipes I added myself though, so that might be part of the issue?) until you break the block and replace it.

It's annoying since you lose all the RF stored (and in the early/mid-game I'm at, RF is somewhat hard to get)

No clue what's causing this bug though, but I hope you guys look into it.

Add oredict to ender/enhanced ender ingot/block/nugget

Due to the fix in #14, if the input slot is empty, the recipe will not be overwritten from its null state, thus making the Quantum Compressor only craft if there is an item (any item) in the input slot. This makes automating more than one singularity in a single Quantum Compressor impossible.

First reported: Divine-Journey-2/Divine-Journey-2#507

Ingredients to recipes for the Ender Crafter are added as if they are shapeless to JEI. This only impacts the appearance in JEI and its move items functionality. The recipe crafts as it should.

crafttweaker recipe:

mods.extendedcrafting.EnderCrafting.addShaped(<minecraft:clay>, [
        [<minecraft:gold_ingot>],
        [<minecraft:gold_ingot>], // this should make an L shape
        [<minecraft:gold_ingot>, <minecraft:gold_ingot>, <minecraft:gold_ingot>]
], 5);

JEI:

I have a problem with minecraft crashing in the crash report link here
crash-2023-10-07_03.03.10-client.txt

As the title says :D