nolanus / ngx-multi-window Goto Github PK

Hi, There are any way to set correctly a StrignUrl to the new window?
when i try to set the url i receive an error.

Thanks!

The devDependency @types/jasminewd2 was updated from 2.0.6 to 2.0.7.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@types/jasminewd2 is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Version 5.2.2 of @angular/router was just published.

This version is covered by your current version range and after updating it in your project the build failed.

@angular/router is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

getKnownWindows() is not working on version 0.1.2. I can not update to 0.1.3 since my application is on angular 5. Please support.

getKnownWindows() is suddenly stopped working it returning just the current window. Is there any particular reason behind this?

I've read something about other techniques to do cross-window communication. Something like this. Using a method like that would eliminate the need for polling, theoretically making the communication quicker. I have never used it though. Also, I don't know about browser support and I think 3/4 of the library would have to be rewritten.

This person had the same problem and they recommend using a BroadcastChannel. It's a simple API:

// Setup
var bc = new BroadcastChannel('test_channel');

// Broadcasting
bc.postMessage('This is a test message.');

// Receiving
bc.onmessage = function (ev) { console.log(ev); }

// Closing connection 
bc.close()

Problem is, Edge doesn't support it yet, so it's of no use for this issue. I did find a polyfill that could maybe work. It uses local storage though, so I don't know if that will work.

[edit] There's another BroadcastChannel 'polyfill' right here. This one chooses the best mode of communication based on the browser it's running on. Works on Edge, FireFox, Chrome, Opera, but it doesn't seem to work on IE11 (which I would abandon altogether). Maybe this would be a better method than pure localStorage? It's pretty damn quick.

The devDependency ng-packagr was updated from 4.6.0 to 4.7.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

ng-packagr is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

The devDependency @types/jasmine was updated from 2.8.9 to 2.8.10.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@types/jasmine is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

The devDependency karma was updated from 3.1.1 to 3.1.2.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

karma is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Hi, I have an issue when trying to run the demo app!

I cloned the git repository, then when I run the command 'npm run demo' in c:\gitrepos\ngx-multi-window

I get a lot of warnings and in the end a couple of errors before it goes back to the commandline.

not really sure what I'm doing wrong or what I'm missing here?!

kind regards

Hey, as stated in the title, I'm wondering why the message time out is set to 10 seconds and not longer. What would the drawbacks be if it were set to a longer frame?

Thanks

Hello,

We were wondering when the library will be updated with Angular 16 support?

Thanks

I was testing the project and it currently does not work with IE11, the send messages timeout.

Version 0.9.46 of @types/core-js was just published.

This version is covered by your current version range and after updating it in your project the build failed.

@types/core-js is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Update to support angular 6

The devDependency @types/jasmine was updated from 3.3.16 to 3.4.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@types/jasmine is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

I'm interested in using this for a project and was wondering if this is still maintained? If so, how to npm install?

How can I remove the message with status 'read', please let me know

How can I change the values of MultiWindowConfig inside my code?

I can't send message with Win 8 IE 11. When I call getKnownWindows() in sender window it only sees itself.
it works fine in Firefox and Chrome.

All dependencies should be updated to support Angular 8 / 9

Upgrading to the latest version resulted in an error in my unit tests. I'm adding the MultiWindowConfig module like this:

const multiWindowConfig = {
  heartbeat: 100,
  newWindowScan: 1000
};

@NgModule({
  imports: [
    MultiWindowModule.forRoot(multiWindowConfig)
  ],

My test:

import {NGXMW_CONFIG} from 'ngx-multi-window/lib/providers/config.provider';

const multiWindowConfig = {
  heartbeat: 100,
  newWindowScan: 1000
};

describe('DockerService', () => {
  let service: DockerService;
  let windowService: MultiWindowService;
  let subscription: Subscription;

  beforeEach(async(() => {
    TestBed.configureTestingModule({
      providers: [
        {provide: NGXMW_CONFIG, useValue: multiWindowConfig}
      ]
    });
 }));

Without the import line my tests results in the error NGXMW_CONFIG is not defined. After adding the import the error is Error: Can't resolve 'ngx-multi-window/lib/providers/config.provider'.

I think NGXMW_CONFIG should be exported in /projects/ngx-multi-window/src/index.ts.

hi, I'm struggeling with something...
when i create a newWindow and id is assigned... newWindowData.windowId.
after i open this with assigned url and I subscribe to the onWindow() observable... the window gets added to the knownwindow collections but it seems that the newWindowData.windowId is defferent then the created [window object].id in knowWindows?
Is this the correct behavior, if so, why? if not, I'm in trouble because it is different in my code... :)

kind regards!
R

It says application depends upon a library published using Angular version 14.0.1
Please help!

Update deps to support angular 7, once all peerDeps and helper modules are ready

Version 5.2.1 of @angular/platform-browser-dynamic was just published.

This version is covered by your current version range and after updating it in your project the build failed.

@angular/platform-browser-dynamic is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Use destruction and unload events as much as possible, but offer transparent way to library user to detect outdated information in list of "known windows".

It would be awesome if the name of a window persists on refreshing the page. Something like this:

// Called in some Angular component
const name = window.name;

if (!name || name.indexOf('AppWindow') === -1) {
  window.name = this.multiWindowService.name;
  console.log('Saving window ID to session: ' + this.multiWindowService.name);
} else {
  this.multiWindowService.name = name;
  console.log('Got window ID from session storage: ' + this.multiWindowService.name);
}

If you do this and you refresh the page, ngx-multi-window creates a new variable in the localStorage, but it keeps using the old one. If this would be done in the library itself, it would probably mean you can use the same key of the localStorage without creating a new one.

I also tried using the sessionStorage because I don't want to use window.name in case someone else uses it, but I got some security issues:

const key = 'dock-panels-window-id';
    const name = window.sessionStorage.getItem(key);

    if (!name || name.indexOf('AppWindow') === -1) {
      window.sessionStorage.setItem(key, this.multiWindowService.name);
      console.log('Saving window ID to session: ' + this.multiWindowService.name);
    } else {
      this.multiWindowService.name = name;
      console.log('Got window ID from session storage: ' + this.multiWindowService.name);
    }

The error:

ERROR DOMException: Failed to execute 'getItem' on 'Storage': access is denied for this document.
    at DockRootComponent.push../projects/dock-panels/src/lib/components/dock-root/dock-root.component.ts.DockRootComponent.initializeWindowName (http://localhost:4200/main.js:670:42)
    at DockRootComponent.push../projects/dock-panels/src/lib/components/dock-root/dock-root.component.ts.DockRootComponent.ngOnInit (http://localhost:4200/main.js:685:14)
    at checkAndUpdateDirectiveInline (http://localhost:4200/vendor.js:63483:19)
    at checkAndUpdateNodeInline (http://localhost:4200/vendor.js:64747:20)
    at checkAndUpdateNode (http://localhost:4200/vendor.js:64709:16)
    at debugCheckAndUpdateNode (http://localhost:4200/vendor.js:65342:38)
    at debugCheckDirectivesFn (http://localhost:4200/vendor.js:65302:13)
    at Object.eval [as updateDirectives] (ng:///AppModule/HomeComponent.ngfactory.js:14:5)
    at Object.debugUpdateDirectives [as updateDirectives] (http://localhost:4200/vendor.js:65294:21)
    at checkAndUpdateView (http://localhost:4200/vendor.js:64691:14)

I am opening a new window and as soon as the subscription fires I want to send a message. My heartbeat config is at 100, but receiving the OPEN_PANEL_EVENT message takes about 6 seconds every time. Shouldn't this be faster (~2x100ms)? Does this subscription fire at the same rate as the heartbeat? I couldn't really figure that out reading the source code yet.

newWindow.created.subscribe(
      () => {
        console.log('Its here!');
      },
      (error) => {
        console.log('Something went wrong opening ' + panel.name + ' in a new window. Please try again.');
      },
      () => {
        console.log('Try sending a message');
        this.sendMessage(newWindow.windowId, DockerService.OPEN_PANEL_EVENT, panel.name);
      }
    );

Oh, why is the third parameter of subscribe firing, not the first? (just read the comments of the subscribe method. I get it now)

The devDependency karma was updated from 4.2.0 to 4.3.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

karma is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴