Comments (5)
@nobiot, I've fixed the problem downstream with the following config.el
settings:
(use-package! org-remark
...
(map! :leader
(:prefix-map ("r" . "reading")
:desc "Make highlight annotation for EPUB or PDF" "h" #'my-reading-make-highlight-annotation)
...
)
(defun my-reading-make-highlight-annotation ()
"Highlight text and activate the annotation notes for input.
This single function can be called for both EPUBs and PDFs."
(interactive)
(cond ((eq major-mode 'nov-mode)
(apply 'org-remark-mark (org-remark-region-or-word))
(org-remark-view (- (point) 1))
(switch-to-buffer "*marginal notes*")
(evil-org-open-below 1))
((eq major-mode 'pdf-view-mode)
(pdf-annot-add-highlight-markup-annotation pdf-view-active-region)
(evil-insert 1)
)))
I'll leave it up to you to decide if it is necessary to add that filter upstream at source level.
from org-remark.
Thanks. I will think of a way upstream for dev/nov.el
branch.
from org-remark.
Fix 32149d5 is in the dev/nov.el
branch.
When you have some time, I'd appreciate it if you could test it on your end.
from org-remark.
When you have some time, I'd appreciate it if you could test it on your end.
Tested the fix.
It now exits with org-remark: Highlights not saved; buffer is not supported
when org-remark-mark
is called on a PDFView
buffer, which is what we want.
from org-remark.
Guess we can close this issue for now.
from org-remark.
Related Issues (20)
- Highlight text gets cut off in notes buffer if the highlight spans across two lines HOT 1
- source code edit buffer in org-mode HOT 5
- [EWW] Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p nil) HOT 1
- unable to load package on windows HOT 5
- marks not associated with a file in eww? HOT 1
- [Feature Request] Add icon / visual for highlights with annotation HOT 1
- WISHLIST: info-mode support HOT 3
- [Requst for Help] Please test dev/nov branch for backward compatibility before merge HOT 24
- org-remark-notes-display-buffer-action documentation could be more specific HOT 12
- BUG calling org-remark-mark open in shell script file HOT 14
- [doomemacs] Possible problem cloning nov.el [?] HOT 1
- org 9.6.7 breaks `org-remark-highlights-get` HOT 4
- [feature request] make org-remark-open open the associated marginalia file if pointer not inside a highlight HOT 6
- Wrong command name `org-remark-line-alt' in manual HOT 2
- Possible to turn on mode buffer-local? HOT 10
- Reducing the length of the headline HOT 2
- [feature request] org-remark-mark-strikethrough HOT 7
- Feature request/question: tufte side notes HOT 1
- error: (wrong-number-of-arguments mapconcat 2) HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from org-remark.