BUG calling org-remark-mark open in shell script file about org-remark HOT 14 CLOSED

from org-remark.

Thank you. I will look. Can I assume you are on the dev/nov.el branch?

from org-remark.

Thank you. I will look. Can I assume you are on the dev/nov.el branch?

yes definetly I just checked

from org-remark.

Trying to reproduce the error but I cannot. I am using “marginalia.org” with other highlights, as your error indicates that’s how you use it.

It is saying Org-remark is trying to narrow a headline before the first headline. What does your maeginalia.org look like before thr first headline?

from org-remark.

Trying to reproduce the error but I cannot. I am using “marginalia.org” with other highlights, as your error indicates that’s how you use it.

It is saying Org-remark is trying to narrow a headline before the first headline. What does your maeginalia.org look like before thr first headline?

there is no marginalina.org file generated in this case, this is the problem

from org-remark.

there is no marginalina.org file generated in this case, this is the problem

I see. What is the value of org-remark-notes-file-name? (It’s a user option).

Where is the .sh file in your file system? Perhaps it is in a remote server and Org-remark fails to find the directory?

from org-remark.

there is no marginalina.org file generated in this case, this is the problem

I see. What is the value of org-remark-notes-file-name? (It’s a user option).

Where is the .sh file in your file system? Perhaps it is in a remote server and Org-remark fails to find the directory?

marginalia.org
I think I have to run some more tests and will report later. something is very odd here.

from org-remark.

marginalia.org
I think I have to run some more tests and will report later. something is very odd here

That’s the default value. At the moment, I cannot reproduce the issue when I have a .sh file in my local directory.

I assume this is not a regression introduced by the recent refactoring…

from org-remark.

from org-remark.

Thank you for the detail steps. I’ll try to reproduce the issue.

from org-remark.

However when I created a new empty directory and repeated the steps 2-4 above, I obtained the error I mentioned.

I tried this with a new, empty directory. I cannot reproduce the problem. I have no error, marginalia.org gets created, and the highlight gets saved to it, as you normally expect.

Just in case we have different source (I might have pushed some commits after you have pulled the branch), I merged the dev/nov.el branch with main. It will be available via GNU-devel ELPA overnight.

How do you normally update your packags? Via package.el? Do you normally use Git to do so?

If you normally use package.el, my suggestion is:

• Wait until the GNU-devel gets updated with the new Org-remark commit
• Use packge.el to update Org-remark in your normal way
• Then test this issue again

Thank you for staying with me on this. It's a strange issue.

from org-remark.

from org-remark.

Looking at your error, I think the commit you use is slightly behind the latest. Could you please try the latest main and see if the problem persists please?

The reason why I think this is that the error should not happen i the current code. See this line. In your error stack, the function org-remark-new-headline is called with the first argument being number 1.

It is passed as the level variable in the function. In the line I quoted above, there is unless (= level 1). org-narrow-to-subtree() should never be called when level is 1, but that’s where your error occurs.

I added this unless conditional later than when I initially requested you to test the branch.

I think updating the codebaae to the latest main branch should resolve this issue for you.

from org-remark.

Mo problem! Thank you 🙏

from org-remark.