noahehall / nim Goto Github PK

• see comments (lol and commit history) for this PR: #29
• we should get this done before moving back to Boat

summary

• testament doesnt seem to catch errors when compiler switches are updated but code hasnt changed
  • or we're just totally clueless, but this surfaced between local runs & github
    • so this has to be an env issue, or it has to be something else ;) theres no third option
    • my intuition is there are some cached files somewhere locally that we cant locate and delete
      • in github it works as it should, but locally we have to execute the file for the errors to surface
      • in a perfect world there would be an option in testament for a clean run

• set these back to switch("warningAsError, "blah:on")
• issue: nim-lang/Nim#21713

switch("warning", "ProveInit:off") # even the doc examples throw
switch("warning", "Uninit:off") # 99% of fmt"{whatever=}" will fail
switch("warning", "BareExcept:off")

• see actions/cache#1152
• added hack to workaround this issue
  • the restore step still shows up as failure (thus the entire job)
  • but the next subsequent steps compensate for the restore failure

• lol see nim-lang/Nim#21786
• makes no sense to request it with Nim since they just moved all the extra native features to second-class citizens
• Thrift already supports C, C++ and Javascript, so we just need to create a nimble package that provides a Thrift client in one of those backends

#22

the github pages workflow occurs after the docs-commit workflow
    
- reduced the branch protection rules so we can commit directly to develop branch      
- this may not be an issue in production repos, as we could keep the deploy branch protection in place

• add new lines between doc comments (doesnt happen automatically)
• github pages testresults dont show results of tests after testing tests