Code Monkey home page Code Monkey logo

Comments (5)

jack-woollen avatar jack-woollen commented on July 17, 2024
  1. There's some issue here with nomenclature in comments concerning the distinction between a message type/subtype and a subset. A message type/subtype (lets say MTS for short) combination defines a subset template. For example the tag NC005064 is an MTS which will contain subsets defined by elements, operators and sequences found in bufr tables a, b, c, and d for that MTS . Each MTS file usually contains many subsets. The code here collates messages from a bufr file in its MTS components. Its mostly my fault and I should fix it.
  2. I wonder why the test failed. I can guess that maybe the exemplar might have slightly different fortran control words for unformatted files or something like that. Are the files being compared available somewhere I could llok at them?

from nceplibs-bufr.

aerorahul avatar aerorahul commented on July 17, 2024

@jack-woollen
re. 2 The split_by_subset.x test fails because we have not uploaded the test files to the ftp directory. Once it is uploaded, the test will pass.

My bufr is weak, so I don't fully understand the language. I think what you are suggesting here is that this program is actually; split_by_MTS rather than split_by_subset. subsets are still present in the split files. Thanks for the clarification. May be I should rename this to split_by_MTS or something else other than subset.

from nceplibs-bufr.

jack-woollen avatar jack-woollen commented on July 17, 2024

It could be split_by_subset_type. I'd like to change some of the comments as well.

from nceplibs-bufr.

aerorahul avatar aerorahul commented on July 17, 2024

@jack-woollen
Feel free to clone the branch and commit to it.

from nceplibs-bufr.

jack-woollen avatar jack-woollen commented on July 17, 2024

@aerorahul Will do.

from nceplibs-bufr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.