nnguy152 / 02-con-a-thon Goto Github PK

Delete dead code!

This is a really great idea:

You have CSS in a stylesheet, in the head and inline - as your application grows that will become difficult to manage. You should generally just keep all your CSS in a stylesheet anyway

I had a small panic attack when I first cloned your project! ☠️☠️☠️☠️

Once I realized you had multiple branches it went away. But still! Merge with master so it's up to date. Your instincts here to use multiple branches is 💯 spot on - we're going to have a lesson on branching strategies for big projects next week where we'll dig into why. You just also want to keep master up to date! 😀

This file is super well organized! Only thought is you may want to switch the order of these two:

Maybe throw your user stories and wireframe into a planning/ directory?

This is an alright way to do this, a better way is to use MongoDB $group Aggregation, which you can do through Mongoose Aggregate. Your query would look something like this:

 Con.find({}, [], { groupBy: '$genre' }).then(cons => {
   res.render('index', { cons }) 
 }) 

I'd suggest also adding a limit so you're not getting every convention in your database.

This is a great start to responsive!

Handlebars and most other templating languages have this thing called partials, which you can use to abstract out repetitive blocks of HTML. You could use a partial here and then render the partial inside each of these loops or create a partial that takes an array and loops through it.

You're using inline styles throughout your application - inline styles are bad! You want to put that styling in a CSS file.

We slacked out this self-guided lesson during project 2: Documentation

Give it a look through, specifically this section on documentation content (i.e. what to put in your readme. You have the first item (a description of your project) but you could use this as an outline to fill in the rest. You could also use this readme template, which gets you most of the way there!