nlueg / node-java-connector Goto Github PK

The API used to find the build has been deprecated and appears to be defunct.

60: let url = 'https://api.adoptopenjdk.net/v2/info/releases/openjdk' + version + '?'

The new API is version 3 and can be found here. https://api.adoptopenjdk.net/q/swagger-ui/

The endpoint for the AdoptOpenJDK API is hardcoded as follows:

const staticOpenJdkUrl = 'https://api.adoptopenjdk.net/v3/binary/latest/';

Visit https://api.adoptopenjdk.net/ and you're greeted with a message:

Please migrate to api.adoptium.net
AdoptOpenJDK has moved to the Eclipse Foundation.

Could we please at least have the URL updated, and perhaps ideally let it be configurable somehow (in case we run into similar problems in the future).

Hi,
Im using node-java-connector 0.2.1 trying to download a jre inside a electron app I get:

Error: ENOTDIR, not a directory
at createError (electron/js2c/asar_bundle.js:5:1382)
at Object.e.mkdir (electron/js2c/asar_bundle.js:5:11735)
at C:\Program Files\app\resources\app.asar\node_modules\node-java-connector\dist\index.js:310:20
at electron/js2c/asar_bundle.js:5:507
at processTicksAndRejections (internal/process/task_queues.js:75:11) {
code: 'ENOTDIR',
errno: -20
}

I assume it is because __dirname is within some kind of electron package.

If I assign __dirname to another tmp dir I can get it to work, but I would like to not have to assign __dirname to anything.

Feature request:
It would be nice if the tmp directory node-java-connector uses when running was possible to override with a parameter.
I can create a pull request if you think this is a good idea and dont want to implement it yourself.

Best regards,
Oskar