nlhkabu / connect Goto Github PK

null value in column "last_login" violates not-null constraint

Error occurs when attempting to manually create a user via the Django admin.

Presently, the app has been tested with Python3.4. If a user tries to install via Python2, he gets no immediate warnings. It'd be nice to warn users if installation is being performed via Python2.
This can be implemented with simple check in manage.py maybe?

import sys
if not sys.version_info > (3, 3):
    print("Hey! We support Python 3.4 or later.")
    exit(13)

cc @nlhkabu

┆Issue is synchronized with this Asana task

• Add django-pipeline
• Add a make sass and make statics in the Makefile

┆Issue is synchronized with this Asana task

'cos some people don't fit the "first name / last name" mold...

┆Issue is synchronized with this Asana task

https://github.com/mixxorz/behave-django

I was contacted by the maintainer, who said:

In terms of usage, behave-django has you invoke a custom management command, python manage.py behave, to run your BDD tests, instead of replacing the TEST_RUNNER. This has the advantage of separating BDD tests from regular unit tests. Aside from that difference in approach, behave-django has more features that can help people with their tests.

Database transactions per scenario
Use Django's testing client
Use unittest + Django assert library
Use behave's command line arguments
Use behave's configuration file
Fixture loading

You can skim through the docs to see how all of this works. https://pythonhosted.org/behave-django/

In my unbiased opinion ( :P), I think behave-django does a better job at integrating BDD tests with django. It's easier to use and a lot more flexible.

Given that we haven't been 100% happy with django-behave, it may be worth a look? Since it also uses behave, it should require too many (any?) changes to our actual test code?

┆Issue is synchronized with this Asana task

• Fix pep8 in the project
• Add a flake8 test in the travis and tox matrix.

We had some problems with Pillow on Fedora,

For this, we ran:

sudo dnf install zlib-devel libjpeg-turbo-devel freetype-devel

We should document this, or point to Pillow's documentation to address this.

┆Issue is synchronized with this Asana task

@hjwp - I'm thinking that Python Anywhere might do the trick 👯

Currently there is a Procfile and uwsgi.ini that are required for Heroku deployment - if we choose to move away from Heroku, these should (??) be able to be removed.

I'd also like to formally document the deployment process in a new deployment.rst

┆Issue is synchronized with this Asana task

Flake 8 is currently causing the CI tests to fail when the line is too long by one character. See: https://travis-ci.org/nlhkabu/connect/jobs/65816246

I would prefer to set this to a more flexible standard - for example, the Django team use a line limit of 119 for code and 79 for documentation, comments and docstrings.

There are a lot of places in the codebase that could benefit from better formatting made possible by a longer line length.

Hi @nlhkabu.

Trying to login as demo but it is not letting me in using the demo account you have specified.

Thanks

┆Issue is synchronized with this Asana task

If there are no skills registered in the database a management form error occurs when you try to save the user profile.

@ojh is currently working on a fix.

Mandrill will cease to support free accounts from April 27 2016.

Given this project is not yet in production, I'd prefer to continue to use a free account in the short term.

This requires looking into alternative providers.

┆Issue is synchronized with this Asana task

Currently many of the tests are using .decode() without specifying the format.
Update these to .decode(utf8)

┆Issue is synchronized with this Asana task

Currently I am hardcoding the server url here:
https://github.com/nlhkabu/connect/blob/master/bdd/features/environment.py#L31

I recently found out that this value is actually set by default as context.config.server_url.

So - this means we can replace any instances of context.server_url to context.config.server_url and remove the hardcoding

We could let people add a Firefox Hello link as well as their Skype contact.
It could also be phone number / irc and/or email.

┆Issue is synchronized with this Asana task

The end of the first sentence should say "registered at Connect"

┆Issue is synchronized with this Asana task

https://github.com/z4r/python-coveralls

For example - users who attended Djangocon Europe could specify this on their profile. This would mean that other users could filter the list by just this conference to find other attendees.

We could also do the same for local django user groups. This might be better than listing each individual meetup (as this might become a bit long).

Thoughts?

┆Issue is synchronized with this Asana task

Ideally configure the CI server to run the tests with a range of different browsers. This can be done with:

python manage.py test bdd --behave_browser <browser>

┆Issue is synchronized with this Asana task

Last commit 2years ago. 13pull requests pending. 💣

Maybe javascript could do the job. Any suggestions?

┆Issue is synchronized with this Asana task

It could be nice to short the ListView by mentor distance with regards to the current user location.

┆Issue is synchronized with this Asana task

Currently the FK to moderator is only a standard UserFactory:
https://github.com/nlhkabu/connect/blob/master/connect/accounts/factories.py#L87

We should really be using a ModeratorFactory here - but I have not been able to get this to work

┆Issue is synchronized with this Asana task

I see several BDD tests currently failing to find the correct "invalid email" error message.

Instead of seeing "Please enter a valid email address." they see "This value should be a valid email.". Not sure why as yet. Somehow the form's custom error message isn't getting through? Could be something to do with django versions, or internationalization maybe?

Python 3.4.3, Django 1.8.2.

┆Issue is synchronized with this Asana task

In the profile we want to let people to select their favorite language, timezone and location (on a map)

The language should defaut to the browser language and the timezone to the current user timezone.

┆Issue is synchronized with this Asana task

See https://docs.python.org/2/library/hmac.html

Example scenario:

Sam is a moderator and reports Alex for inappropriate behavior.
This abuse report is dismissed by another moderator.
When Sam views the moderation dashboard, Sam can see a log of the dismissal.

In the case above, Sam should not be able to see the moderation log. I am not sure this is possible with the current data structure as the moderation logs do not reference the user who reported the abuse - only the reported user (in this case Alex) and the moderator who made the decision.

We could introduce a FK relationship to AbuseReport for this case, or simply add another User field to ModerationLogMsg to account for this situation.

┆Issue is synchronized with this Asana task