nklerk / neeo_driver-onkyo Goto Github PK

Hi Niels, Just wanted to pass on my thanks for posting this Onkyo AVR driver. I've VERY new at this, and I'm not a developer by any stretch of the imagination but I have some feedback.

I discovered one bug in your code:

In controller_onkyo.js line 154 you have:

{ code: '!1OSDRIGHT', name: "CURSOR ENTER"},
This should be:

{ code: '!1OSDENTER', name: "CURSOR ENTER"},

Also just a general observation. I couldn't get the "Power On" command to work. After a few hours of head-scratching, it was because I hadn't configured the Onkyo's Network Stand-by feature to be enabled. It might be worth adding a comment in the code to prevent feedback from others who may report a fault with your code - when in-fact it's a system configuration issue.