nitramr / scribus-indigo Goto Github PK

I think it would be good for you to edit about.cpp so you identify this as a github work in progress, and update the date when you see fit.

http://www.qcad.org/en/

Used to work with qt 5.7.1
Here's the output

[ 13%] Linking CXX shared module libtxtim.so
[ 13%] Building CXX object scribus/plugins/gettext/textfilter/CMakeFiles/textfilterplugin.dir/moc_tffilter.cpp.o
[ 13%] Built target txtim
[ 14%] Generating ui_pathdialogbase.h
[ 14%] Generating moc_pathdialog.cpp
[ 14%] Generating moc_pathalongpath.cpp
[ 14%] Building CXX object scribus/plugins/gettext/textfilter/CMakeFiles/textfilterplugin.dir/moc_tfdia.cpp.o
[ 14%] Generating moc_meshdistortion.cpp
/tmp/yaourt-tmp-danym/aur-scribus-indigo-git/src/scribus-indigo/scribus/plugins/gettext/xtgim/xtgscanner.cpp: Dans la fonction membre ‘void XtgScanner::xtgParse()’:
/tmp/yaourt-tmp-danym/aur-scribus-indigo-git/src/scribus-indigo/scribus/plugins/gettext/xtgim/xtgscanner.cpp:1520:21: erreur : ambiguous overload for ‘operator!=’ (operand types are ‘QChar’ and ‘char’)
while (lookAhead() != '\0')
~~~~~~~~~~~~^~~~~~~
In file included from /usr/include/qt/QtCore/QString:1:0,
from /tmp/yaourt-tmp-danym/aur-scribus-indigo-git/src/scribus-indigo/scribus/styles/../style.h:21,
from /tmp/yaourt-tmp-danym/aur-scribus-indigo-git/src/scribus-indigo/scribus/styles/style.h:6,
from /tmp/yaourt-tmp-danym/aur-scribus-indigo-git/src/scribus-indigo/scribus/styles/charstyle.h:20,
from /tmp/yaourt-tmp-danym/aur-scribus-indigo-git/src/scribus-indigo/scribus/plugins/gettext/xtgim/xtgscanner.h:31,
from /tmp/yaourt-tmp-danym/aur-scribus-indigo-git/src/scribus-indigo/scribus/plugins/gettext/xtgim/xtgscanner.cpp:27:
/usr/include/qt/QtCore/qstring.h:1639:13: note : candidate: bool operator!=(QChar, const QStringRef&)
inline bool operator!=(QChar lhs, const QStringRef &rhs) Q_DECL_NOTHROW { return !(lhs == rhs); }
^~~~~~~~
/usr/include/qt/QtCore/qstring.h:1625:13: note : candidate: bool operator!=(const QString&, QChar)
inline bool operator!=(const QString &lhs, QChar rhs) Q_DECL_NOTHROW { return !(rhs == lhs); }
^~~~~~~~
/usr/include/qt/QtCore/qstring.h:1620:13: note : candidate: bool operator!=(QChar, const QString&)
inline bool operator!=(QChar lhs, const QString &rhs) Q_DECL_NOTHROW { return !(lhs == rhs); }
^~~~~~~~
/usr/include/qt/QtCore/qstring.h:1567:13: note : candidate: bool operator!=(const QString&, const QStringRef&)
inline bool operator!=(const QString &lhs, const QStringRef &rhs) Q_DECL_NOTHROW { return lhs.compare(rhs) != 0; }
^~~~~~~~
In file included from /usr/include/qt/QtCore/qstring.h:48:0,
from /usr/include/qt/QtCore/QString:1,
from /tmp/yaourt-tmp-danym/aur-scribus-indigo-git/src/scribus-indigo/scribus/styles/../style.h:21,
from /tmp/yaourt-tmp-danym/aur-scribus-indigo-git/src/scribus-indigo/scribus/styles/style.h:6,
from /tmp/yaourt-tmp-danym/aur-scribus-indigo-git/src/scribus-indigo/scribus/styles/charstyle.h:20,
from /tmp/yaourt-tmp-danym/aur-scribus-indigo-git/src/scribus-indigo/scribus/plugins/gettext/xtgim/xtgscanner.h:31,
from /tmp/yaourt-tmp-danym/aur-scribus-indigo-git/src/scribus-indigo/scribus/plugins/gettext/xtgim/xtgscanner.cpp:27:
/usr/include/qt/QtCore/qchar.h:576:30: note : candidate: constexpr bool operator!=(QChar, QChar)
Q_DECL_CONSTEXPR inline bool operator!=(QChar c1, QChar c2) Q_DECL_NOTHROW { return !operator==(c1, c2); }
^~~~~~~~
Scanning dependencies of target meshdistortion
[ 14%] Building CXX object scribus/plugins/tools/2geomtools/meshdistortion/CMakeFiles/meshdistortion.dir/meshdistortiondialog.cpp.o
[ 14%] Building CXX object scribus/plugins/tools/2geomtools/meshdistortion/CMakeFiles/meshdistortion.dir/meshdistortion.cpp.o
make[2]: *** [scribus/plugins/gettext/xtgim/CMakeFiles/xtgimplugin.dir/build.make:85: scribus/plugins/gettext/xtgim/CMakeFiles/xtgimplugin.dir/xtgscanner.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:3705: scribus/plugins/gettext/xtgim/CMakeFiles/xtgimplugin.dir/all] Error 2
make[1]: *** Attente des tâches non terminées....
[ 14%] Building CXX object scribus/plugins/tools/2geomtools/meshdistortion/CMakeFiles/meshdistortion.dir/moc_meshdistortiondialog.cpp.o
Scanning dependencies of target pathalongpath
[ 14%] Building CXX object scribus/plugins/tools/2geomtools/pathalongpath/CMakeFiles/pathalongpath.dir/pathdialog.cpp.o
[ 14%] Linking CXX shared module libtextfilterplugin.so
[ 14%] Built target textfilterplugin
[ 14%] Building CXX object scribus/plugins/tools/2geomtools/pathalongpath/CMakeFiles/pathalongpath.dir/pathalongpath.cpp.o
[ 14%] Building CXX object scribus/plugins/gettext/sxwim/CMakeFiles/sxwimplugin.dir/moc_sxwdia.cpp.o
[ 14%] Building CXX object scribus/plugins/saveastemplateplugin/CMakeFiles/saveastemplateplugin.dir/satemplate.cpp.o
[ 14%] Building CXX object scribus/plugins/saveastemplateplugin/CMakeFiles/saveastemplateplugin.dir/moc_satdialog.cpp.o
[ 14%] Linking CXX shared module libsxwimplugin.so
[ 14%] Building CXX object scribus/plugins/tools/2geomtools/pathalongpath/CMakeFiles/pathalongpath.dir/moc_pathdialog.cpp.o
[ 14%] Built target sxwimplugin
[ 14%] Building CXX object scribus/plugins/tools/2geomtools/pathalongpath/CMakeFiles/pathalongpath.dir/moc_pathalongpath.cpp.o
[ 14%] Building CXX object scribus/plugins/tools/2geomtools/meshdistortion/CMakeFiles/meshdistortion.dir/moc_meshdistortion.cpp.o
[ 14%] Building CXX object scribus/plugins/saveastemplateplugin/CMakeFiles/saveastemplateplugin.dir/moc_satemplate.cpp.o
[ 14%] Linking CXX shared module libmeshdistortion.so
[ 14%] Built target meshdistortion
[ 14%] Linking CXX shared module libsaveastemplateplugin.so
[ 14%] Built target saveastemplateplugin
[ 14%] Linking CXX shared module libpathalongpath.so
[ 14%] Built target pathalongpath
make: *** [Makefile:150: all] Error 2
==> ERREUR : Une erreur s’est produite dans build().
Abandon...

1. close a dock with visible panels inside
2. check Window menu
   → panels are marked as visible

Dear Scribus-Indigo devs,
When will things be updated for 2018? I'm a newb at linux and programming stuff, and scribus normally has a weird interface, so I wanted to try this version looking at the screenshots. At the moment, I'm not having any success getting it work.

Thanks for your work. If I can help (or learn to help) in any way with development, please let me know; no guarantees, just interested. :)

Manjaro 16.10 Qt5.7 Build 99d6f57
Testing via Appimage

How to reproduce:

1. open scribus-indigo
2. Cancel' Open New Document' window
3. Press F2
   Result: PP opens in dialog in the center of the screen
4. Double click dialog title
   Result: Expands the full length and width of the screen
5. Double click dialog title
   Result: returns to center of screen
6. move dialog box to sidebar
   Result: no sidebar is triggered

Diagnosis: When PP is open it opens in a separate window. I can see this because when I alt-tab to a different application I can still see the PP dialog visible outside of Scribus.

Hi,
this bug is specifically related to building Scribus on macOS with all the software installed through homebrew.

When running

cmake --debug-output ../scribus-indigo-master

from scribus/bin

I get the following error (tail)

CMake Error at CMakeLists.txt:604 (find_package):
  By not providing "FindQt5Core.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "Qt5Core", but
  CMake did not find one.

  Could not find a package configuration file provided by "Qt5Core"
  (requested version 5.5.0) with any of the following names:

    Qt5CoreConfig.cmake
    qt5core-config.cmake

  Add the installation prefix of "Qt5Core" to CMAKE_PREFIX_PATH or set
  "Qt5Core_DIR" to a directory containing one of the above files.  If
  "Qt5Core" provides a separate development package or SDK, be sure it has
  been installed.

I tried to follow some of the suggestions shared here Qt5 Cmake Files Incorrect #29938 but without luck.

How do you correctly build Scribus on macOS?

Thanks,
af

if an existing panel is missing in prefs it will add in an own floating window frame instead of additional to any dock.

IndigoDockManager.cpp line 499

@nitramr thanks for all the awesome work on Scribus-Indigo so far. I've opened a ticket on Mantis mentioning you in https://bugs.scribus.net/view.php?id=14498 this is a ticket requesting README.md needed for the Scribus Iconsets directory.

Icons: https://github.com/scribusproject/scribus/tree/master/resources/iconsets
Martin at Scribus-Indigo has made some progress in this area. Eventually we can
have it that people would easily be able to customize Scribus to their whims.
We need to document how they can do that.

Can we start to document how users could customize Scribus in a step-by-step fashion?

because it's exceeding the maximum compile time for travis. So I think we should remove OSG from both Linux and OSX because it's taking time to download it and both of the builds are throwing a lot of warnings. I'll open an PR soon to do this.

http://imhere-asia.com/blog/post/color-ramp-improvements-in-upcoming-qgis-30
Just an idea on how to present choosing gradients in the UI.

demonstrating how development is going.

I saw in the last commit that you're using Qt Creator 3.6.1
4f0e6ad#diff-780546f5e957f70a5e8165859dfbb404R3

I get these messages on Fedora 24:

Could not find platform independent libraries
Could not find platform dependent libraries <exec_prefix>
Consider setting $PYTHONHOME to [:<exec_prefix>]
ImportError: No module named site
Scribus Crash

Scribus crashes due to Signal #11
Segmentation fault (core dumped)

Add here all issues which you can find in the dark, darker or light theme.

See https://bugs.scribus.net/view.php?id=15236

The fix mentioned there is needed and works fine also for scribus' indigo.

Currently each commit gets built on Travis CI but then the build artefacts are thrown away.
What a waste ;-)

Lets bundle them up as an AppImage for Linux and provide them for download - thus, enabling a very easy way to get and test each build!

It should be relatively straightforward to apply this patch I had done earlier for HOST-Oman/scribus.

Then, each build from Travis CI will available for download as an AppImage for 64-bit Linux. You can find the download link in the Travis CI build log. Towards the end of the log file, look for a line with an URL that begins with with https://transfer.sh/. This is the download link. Download the AppImage, make it executable, and run. No root, no installation, does not touch any of the libaries on your system, can run alongside other versions you might already have.

Hi Tim

With your changes to the theme selector, the GUI is now missing the Mac style. We need to keep the ability to let people use the pure platform styles somehow. Therefore, we also need theming to work, eg in Mac style applied to the new dock and palettes. I'm also open to a pure "indigo style", akin to Qt Creator's own style.

thanks
Craig

#17 (comment)
Still not sure how to fix this...

1. dock is docked in vertical direction (left or right), panel height of visible panels is higher than screen height (scrollbar is visible)
2. bring dock in horizontal direction (top or bottom)
3. bring dock back in vertical direction (left or right)
   →panel height doesn't update right and space between panels is missing

click on any tab icon to get the right height.

Start scribus, click "Scripter" without opening a document. You will get an error message "You need a Document open", which cannot be closed. You have to kill scribus forcefully.

scribus is distributed under the gpl 2 license... i don't think that the team will be willing to integrate code under the gpl 3... since this would mean upgrading the license...

(as far as i understand it, the license says that you can redistribute scribus unter gpl 2 or later, but if they include code with gpl 3, the license has to be changed as gpl 3 or later... but i might be mistaking).

you should probably discuss this with somebody from the team.

Manjaro 16.10 Qt 5.7 Build 571247b (using the appimage to test)

1. open and place a sidebar menu like action-history
2. open new document
   Result: see lines
3. close document
   Result: see remnants of the lines

See gif

When I create e.g. a freehand curve, then its "Text" property fold is disabled. When I click once, it does not open; when I click twice, it opens and closes immediately; when I double-click, but hold the second click and drag inside the pane which just opened, it stays open. Not sure if that is intentional, but I find it a bit surprising. It is also not very clear to me visually that the fold is disabled, but it might be just getting used to it; the arrow on the left has different color (in the dark theme, it is actually lighter, so more prominent?), maybe the text should also be dimmed somewhat to make clear that that item is disabled.
I am using the https://transfer.sh/myk8l/scribus-git7a91d9e-glibc2.14-x86-64.appimage image on Ubuntu 16.04.

1. If more than 1 icon is visible in tab bar pull down any icon below the last one and release the mouse
   →pulled icon jumps on top of tab bar

Happens only if there are some hidden panels

Is it possible compile this in Manjaro ? I'm somewhat new to Linux. This project is amazing. T.I.A

Hey @nitramr
I was reading your style guide and remembered a ticket that @aoloe opened sometime ago: https://bugs.scribus.net/view.php?id=10162 "Find a common icon for the delete buttons"
I'm mentioning it here as a reference going forward.

Per e308a9e

/home/ghee/projects/scribus-indigo/scribus-indigo/scribus/ui/propertiespalette_xyzbase.ui: Warning: Z-order assignment: 'rotationSpin' is not a valid widget.

/home/ghee/projects/scribus-indigo/scribus-indigo/scribus/themefactory.h:0: Note: No relevant classes found. No output generated.

When I try to compile Scirbus-Indigo (from Arch's aur), build dies on building importpdf plugin with:

make[2]: *** [scribus/plugins/import/pdf/CMakeFiles/importpdf.dir/build.make:78: scribus/plugins/import/pdf/CMakeFiles/importpdf.dir/importpdf.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:1810: scribus/plugins/import/pdf/CMakeFiles/importpdf.dir/all] Error 2
make: *** [Makefile:152: all] Error 2

It is known issue with Scribus. Patch has been already added to upstream AFAIK. Is there any chance it could be solved in Scribus Indigo as well?

Not sure if these are triggered by scribus-indigo code. I posted them here anyway.

/home/ghee/projects/scribus-indigo/scribus-indigo/scribus/styles/style.cpp: In member function ‘bool Style::canInherit(const QString&) const’:
/home/ghee/projects/scribus-indigo/scribus-indigo/scribus/styles/style.cpp:82:8: warning: variable ‘loop’ set but not used [-Wunused-but-set-variable]
  bool  loop = false, parentLoop = false;
        ^~~~

/home/ghee/projects/scribus-indigo/scribus-indigo/scribus/scribusdoc.cpp: In member function ‘void ScribusDoc::addSection(int, const QString&, uint, uint, NumFormat, uint, bool, bool, QChar, int)’:
/home/ghee/projects/scribus-indigo/scribus-indigo/scribus/scribusdoc.cpp:6917:25: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
   if (newSection.toindex>docPageCount-1)
       ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~
/home/ghee/projects/scribus-indigo/scribus-indigo/scribus/scribusdoc.cpp: In member function ‘void ScribusDoc::itemSelection_ApplyArrowHead(int, int, Selection*)’:
/home/ghee/projects/scribus-indigo/scribus-indigo/scribus/scribusdoc.cpp:13726:24: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
  if (selectedItemCount > Um::ItemsInvolvedLimit)
      ~~~~~~~~~~~~~~~~~~^~~~
/home/ghee/projects/scribus-indigo/scribus-indigo/scribus/scribusdoc.cpp:13737:25: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
   if (selectedItemCount <= Um::ItemsInvolvedLimit)
       ~~~~~~~~~~~~~~~~~~^~~~~
/home/ghee/projects/scribus-indigo/scribus-indigo/scribus/scribusdoc.cpp: In member function ‘void ScribusDoc::itemSelection_ApplyArrowScale(int, int, Selection*)’:
/home/ghee/projects/scribus-indigo/scribus-indigo/scribus/scribusdoc.cpp:13773:20: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
  for (int i = 0; i < selectedItemCount; ++i)
                  ~~^~~~~~~~~~~~~~~~~~~

/home/ghee/projects/scribus-indigo/scribus-indigo/scribus/util_color.cpp: In function ‘void RGBTOHLS(uchar&, uchar&, uchar&)’:
/home/ghee/projects/scribus-indigo/scribus-indigo/scribus/util_color.cpp:451:5: warning: this ‘else’ clause does not guard... [-Wmisleading-indentation]
     else if ( var_G == var_Max )
     ^~~~
/home/ghee/projects/scribus-indigo/scribus-indigo/scribus/util_color.cpp:455:3: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘else’
   if ( H < 0 )
   ^~
/home/ghee/projects/scribus-indigo/scribus-indigo/scribus/util_color.cpp: In function ‘double getCurveYValue(FPointArray&, double, bool)’:
/home/ghee/projects/scribus-indigo/scribus-indigo/scribus/util_color.cpp:517:5: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
     if(x >= p.x())
     ^~
/home/ghee/projects/scribus-indigo/scribus-indigo/scribus/util_color.cpp:519:2: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘if’
  int cc = 0;
  ^~~

/home/ghee/projects/scribus-indigo/scribus-indigo/scribus/ui/proptree.cpp: In member function ‘virtual void PropTreeWidget::drawRow(QPainter*, const QStyleOptionViewItem&, const QModelIndex&) const’:
/home/ghee/projects/scribus-indigo/scribus-indigo/scribus/ui/proptree.cpp:478:25: warning: ‘QStyleOptionViewItemV3’ is deprecated [-Wdeprecated-declarations]
  QStyleOptionViewItemV3 opt = option;
                         ^~~
In file included from /usr/include/qt/QtWidgets/qabstractitemdelegate.h:44:0,
                 from /usr/include/qt/QtWidgets/qabstractitemview.h:46,
                 from /usr/include/qt/QtWidgets/qheaderview.h:43,
                 from /usr/include/qt/QtWidgets/QHeaderView:1,
                 from /home/ghee/projects/scribus-indigo/scribus-indigo/scribus/ui/proptree.cpp:27:
/usr/include/qt/QtWidgets/qstyleoption.h:440:48: note: declared here
 typedef Q_DECL_DEPRECATED QStyleOptionViewItem QStyleOptionViewItemV3;
                                                ^~~~~~~~~~~~~~~~~~~~~~

1. run Scribus;
2. drag toolbar to make it float;
3. close Scribus;
4. run Scribus - toolbars appear on their previous positions;
5. minimize Scribus window or switch to other app - floating toolbars float in front of all windows.

If you move toolbars after you run Scribus, they will start to hide/show together with Scribus window. But there is still some unpredictable behavior - randomly they won't pop up with Scribus.

Since SVN recently follows XDG standards...the new place for the Scribus preference files are in ~/.config/scribus instead of ~/.scribus
Invoking indigo-scribus with no flags will use the default scribus prefs and we don't want that. So ways around that, we can use some flags mentioned in https://wiki.scribus.net/canvas/CMake_Build_Options#1.5.x.svn.2B
like:
APPLICATION_CONFIG_DIR : PATH : specify the user configuration directory at compile time
for example:
cmake -DAPPLICATION_CONFIG_DIR=~/.config/scribus-indigo

We can mention this also in the README so people can test appropriately. Also they'll need to invoke scribus-indigo with a special flag:
scribus-indigo --prefs ~/.config/scribus-indigo

craig has extracted the text properties from the properties palette.

now it's a standalone palette.

it would be nice if that standalone window would be converted to a content palette that contains the

• group
• image
• line
• (and eventually table)

section of the property palette.

only one of the content palette can be shown at any time, depending on the selected item.

1. Drag out a panel and drop it in empty space
2. panel is docking in a new dock without tabbar (dock switch in single mode)
3. drag in a second panel
   → icon of first panel is missing

hide and show of first panel bring back the icon in tab bar.

running your latest AppImage, in the Preferences pane > User Interface > Font sizes - changing the font size for menus and palettes seems quirky and changes to a different ui theme altogether.

Panels which comes from a plugin like "Custom Shapes" won't support correct by loadWorkspace() function.

It is only affected to:

• dock
• panel order

It is not affected to visibility of the plugin panel

@nitramr this is awesome. Lets get TravisCI started for this: check out https://docs.travis-ci.com/user/getting-started/#To-get-started-with-Travis-CI%3A

It's simple and steps 3 and 4 are already done.

"Align and Distrib" and "Action Histo"
See gif

Manjaro 16.10
scribus-indigo 43554ee

The Indigo branch is an inofficial experimental

Unofficial