ninigi / plug_hmouse Goto Github PK

Firstly, thanks for releasing this repo, it's saved me a lot of work!

I'm working on a project that listens for GitHub webhooks and GitHub sends a HMAC digest with their requests. This HMAC is in a different form to what your library expects. From what I can see, plug_hmouse as it stands expects a HMAC to come in the form:

header: base64_encoded_digest

Whereas GitHub uses the form:

header: algorithm=hex_encoded_digest
eg. X-Hub-Signature: sha1=7d38cdd689735b008b3c702edd92eea23791c5f6

I am currently putting together code that adds in options to plug_hmouse to enable this and was wondering whether you'd like me to open a PR when I'm finished. My working branch is here.

The way I was tackling this was adding options for whether or not the header value needs to be split into algorithm and digest and for whether the digest is base 16 or base 64. I'm not sure this is the best way of going about it, and feedback would be welcome.

On my branch, I need to add tests for the new options and add them to the documentation, but after that I would be really happy to contribute back upstream. Let me know what you think!