nincraft / modpackdownloader Goto Github PK

Am I doing it wrong or is it broken?

21:24:32.285 [main] INFO  com.nincraft.modpackdownloader.ModPackDownloader:25 -
Starting ModPackDownloader with arguments: [-manifest, manifest.json, -folder, m
ods, -clearCache]
Exception in thread "main" java.lang.NullPointerException
        at java.io.File.<init>(Unknown Source)
        at com.nincraft.modpackdownloader.util.FileSystemHelper.clearCache(FileS
ystemHelper.java:82)
        at com.nincraft.modpackdownloader.ModPackDownloader.main(ModPackDownload
er.java:37)

If I am simply missing something, sorry to bother you. :p

Version is ModPackDownloader-0.3.3.225

Unless you write a script to delete the mods prior to Curse modpack updating, the old mods will still be there. They should be moved to a temp directory and deleted upon successful update. Otherwise moved back.

Adding a release type tag to an individual Curse mod to override the release type passed in via command line could be useful. For example, Psi has not been released and is still in beta so the updater won't update to the latest beta for it.

Add validation to directory and file parameters to make sure they are valid.

Help command needs to be added. Descriptions for each parameter needs to be added it so it shows up.

Should prompt the user to post logs and manifest

A json of modpack details can be accessed through the widget api like so.

https://widget.mcf.li/modpacks/minecraft/225550-agrarian-skies-2.json

This feature would store the slug, 225550-agrarian-skies-2, in a file in the minecraft folder. The application could then be run with a command line argument of the minecraft folder, or simply stored in that folder and run without location specific arguments, and update the pack to the current recommended version.

In theory this could be combined with MultiMC's ability to run programs before instance launch to update packs on the fly.

Our current setup can very easily break and hang forever. Switching over to some sort of thread manager on the main thread would hopefully cause less issues.

So far only applies to Tinkers' Construct v1.8.8-build991, but it just doesn't want to download the mod at all unless I use the CurseForge CDN URL instead of the "official" download link from the button itself.

For more information, see: UndeadZeratul/ThereWillBeBlood#110

Using http://files.minecraftforge.net/maven/net/minecraftforge/forge/promotions_slim.json

Also our current jsons in main resources should move to test resources.

So basically instead of one mod list manager handling downloads and updates to a single manifest, I'm thinking we can have processors for each, well, process. Updating can take in a list of manifest file locations, build out the manifests given the files at those locations, and update them. Downloading can take in its own list of manifest file locations, compile them to a singular list of mods to download, and download them to the output location provided in the arguments. Modpack Updating will eventually just be split out into its own processor (I personally am not planning on changing its logic, just where it happens with this feature). The new feature that will come with this is merging manifest files, which will take in a list of manifest file locations, convert them all into their own manifests, pull out all distinct curse mods found within them into a single mod list, then dump that back into a new manifest, which will be written to the output folder given in the arguments. This will allow us to pull in all of our individual manifests into one cohesive Curse Manifest for automatically deploying modpacks to CurseForge.

For some reason two mods that I have set up to download from GitHub in TWBB are resulting in 0KB jar files when using the downloader, but going and manually downloading them is fine.

For more information, see: UndeadZeratul/ThereWillBeBlood#110

App update command should download the jar to the current directory

https://gist.github.com/Nincodedo/150d37c450e9d6c030a5f3a50ec4d061

http://play.nincraft.com:8080/job/There%20Will%20Be%20Blood/231/console

16:39:11.368 [pool-2-thread-16] ERROR com.nincraft.modpackdownloader.util.DownloadHelper:53 - Could not download Chameleon Creepers.jar.
java.io.FileNotFoundException: http://minecraft.curseforge.com/projects/chameleon-creepers/files/2285921/download?cookieTest=1

This file is no longer on Curse, however it was in the cache. We shouldn't need a connection to Curse to pull something from the cache. We should change the Curse cache structure to include the name and file ID from the JSON. This way you can determine if the mod is the correct one in the cache without needing to go to Curse.

gj

FileSystemHelper, copyFromLocalRepo. Doesn't rename the file being downloaded. It renames the file in the local repo and does nothing with downloaded file.

This handler will have mod name, repo name, and release tag. This will only work with github repos that utilize the releases tab and actually tag their builds.

If a newer version of a mod is found while updating, the log is supposed to show the old and new version. However currently neither are being set so it just shows null.

A short log message at the end of updating/downloading just summarizing what happened. 5 updated out of 10 mods or 33 out of 35 downloaded successfully

The url/file changes between MCVersion-ForgeVersion and MCVersion-ForgeVersion-MCVersion. I'm not entirely sure why or how to determine which one it should be. Could just check both.

19:48:01.733 [Thread-10] INFO com.nincraft.modpackdownloader.ModPackDownloader - Downloading Buildcraft. Mod 2 of 32
Exception in thread "Thread-10" java.lang.NullPointerException
at com.nincraft.modpackdownloader.util.URLHelper.decodeSpaces(URLHelper.java:12)
at com.nincraft.modpackdownloader.ModPackDownloader.downloadFile(ModPackDownloader.java:238)
at com.nincraft.modpackdownloader.ModPackDownloader.lambda$downloadThirdPartyMod$2(ModPackDownloader.java:208)
at com.nincraft.modpackdownloader.ModPackDownloader$$Lambda$3/961419791.run(Unknown Source)
at java.lang.Thread.run(Thread.java:745)

http://play.nincraft.com:8080/job/NEB3/49/console

The ability to keep a Curse pack up to date and also add your own mods on top of it is something I've seen a few people in the community do. We should be able to add support for that fairly easily.

Log on pastebin

Valid URL would be
https://minecraft.curseforge.com/projects/storage-drawers/files/2350060/download?cookieTest=1
but Downloader tries to get
https://minecraft.curseforge.com/projects/223852-storage-drawers/files/2350060/download?cookieTest=1

Notice the missing project-id in the URL. I'm guessing this must be a recent change on their side.
I tried the manifest from In The Sea and SkyExchange.

Log an error saying the Forge version of the pack is different than the currently installed one for this instance when updating a modpack in MultiMC. Maybe also stop the pack from starting? @Watchful1

From #28

checkMCUpdate would check the mods in your listed manifest to see if they are available for the Minecraft version given with the parameter. At the end it would spit out a summary of how many mods are and aren't updated and list the ones that aren't.

When trying to download a modpack today from Curse, the downloader only saved one ".jar" file, minecraft.curseforge.com.jar

It appears that Curse may have changed how the files are accessed on their system.

https://www.reddit.com/r/feedthebeast/comments/4m2cpq/slug/d3s6egp

By default, CurseForge pack downloads have manifest.json next to an overrides folder. Inside overrides is a mods folder, containing all of the non-Curse mods.

If I place ModPackDownloader next to manifest.json and run it, it creates a separate mods folder outside of the overrides folder, and I have to manually merge MPD's mods folder with Curse's mods folder.

It would be nice if the default mods directory was overrides/mods, so all the mods end up in the same place.

Follow Curse manifest conventions

Matches Curse manifest and also is just less work overall in the long run.

https://gist.github.com/Nincodedo/f12fad7ee51f487e9a9c29e0b37cf436

Everything is under pool-2-thread-1

Only will work with repos that use the releases tab. Main issue will be lack of knowing which Minecraft version the releases are set for. Still need to work that out.

Having trouble downloading packs fully (Trying with Skyfactory3).

My internet connection isn't always wonderfull, but as you will notice from the logs the most of multiple threads timeout or loses connection to curse/nincraft. The result is that only 4-10 mods is being verified each run and I have to run the app many times.

Also, when running with the [-updateCurseModPack] parameter it fails to download the latest .zip file.
If I manually download and place it in the folder it works.

manifest.zip
modPackDownloader.zip

http://pastebin.com/XVgcAx6v

http://play.nincraft.com:8080/job/Undead_Zeratul%20Org/job/ThereWillBeBlood/branch/release%252Fv1.0.0/1/console

I've discussed this with @UndeadZeratul but just wanted to get this written down.

Downloading is currently a mess and not consistent. All downloaded files should go through the Download Helper and files should be downloaded directly to the local cache. If a file is already in the cache, then obviously this part will be skipped. After, the file should be copied from the local cache to the folder designated by the DownloadableFile. Renaming will take place after copying. This will hopefully resolve our cache and renaming issues.

Things to fix

34c8e4e#diff-3896c42b28c940f0a8f7659ce3ea9f98R28

a9a816c

When I run the program, it looks like it works, but produces a jar file named minecraft.curseforge.com.
What's going on?

Instead of a boolean, change it to String which would be the modpack slug. Therefore no need to look up a file. This would be a major parameter change so 1 release giving out a log message saying this will be changed in future releases is required.