Android plugin fails to resolve some of the discovered services about flutter_nsd HOT 6 CLOSED

1.2.0 is released to pub.dev

from flutter_nsd.

Oh, it seems this has been fixed? 7caf86a#diff-d522d7763ab9c2fbd638d00d7042d518aa2f9a15e0a7ae3da32a9ca782b5baf9

But flutter package repository has old code!? Could you publish newer version there, please?

from flutter_nsd.

I haven't had the chance yet to test the latest code in master so that's why I haven't published it. Have you tried cloning the repo and trying it locally to see if it fixes the issue? You can use a path instead of a version in pubspec.yaml to try it out.

dependencies:
  flutter_nsd: 
    path: /path/to/repo

from flutter_nsd.

Thanks, I tried it earlier quickly, but not comprehensively, just by replacing the plugin file locally in the flutter cache directory.
I didn't review the code properly but hopefully it works even when one of the resolving fails, so that the rest of the queue will be handled.

Great to know you can reference by repo, thanks!

from flutter_nsd.

I did a brief test of master branch yesterday evening and found out that the discovered service is emitted twice in my case. Prior to #6 the same test resulted in one emitted service. I'll have to take a deeper look either in the following evenings or in the weekend before I publish 1.2.0 to pub.dev.

Have you noticed the same issue on your end?

from flutter_nsd.

No, I just re-tested, and everything works, without duplicates.

Sure, you get duplicates if you press start / stop multiple times. e.g. If you press the start, and a little bit later again, you might see multiple values, but that's because the example code adds new values to the services.

In the listen callback, no duplicates, either.
Also if I register a new service after the app is already running, the listener finds it 👍🏼 .

I tested with Android Pixel 3a and also verified that iPhone works the same (both tested using usb-connection)
Of course, I have done this only a couple of times, so there could be some problem. Did you get a duplicate just by pressing start once and with a fresh build/run?

I ran flutter clean and build having this dependency definition for flutter_nsd:

flutter_nsd:
    git:
      url: git://github.com/Nimrodda/flutter_nsd.git

from flutter_nsd.