Code Monkey home page Code Monkey logo

Comments (4)

jnstahl avatar jnstahl commented on June 12, 2024

val hostname = this?.host?.canonicalHostName <==== canonicalHostName will return either IP address or hostname on the android implementation

from flutter_nsd.

Nimrodda avatar Nimrodda commented on June 12, 2024

the current Windows implementation returns hostnames, such as 'Android-5.local' when provided by the MDNS query results. However some windows hosts do not have the ability to resolve such a hostname and to establish a connection (apparently this ability relies on 3rd party packages such as Bonjour being installed).

Suggested fix:

  • short-term: Windows implementation will always return an IP address string for hostname

  • long-term: the NsdServiceInfo object can be expanded to include:

    • ipv4
    • ipv6
      in addition to hostname and port

Sounds like a plan 👍

val hostname = this?.host?.canonicalHostName <==== canonicalHostName will return either IP address or hostname on the android implementation

OK. That's good to know.
How about the iOS/MacOS implementation?

from flutter_nsd.

Nimrodda avatar Nimrodda commented on June 12, 2024

This comment is just for tracking what's done:
Short term solution introduced in PR #21

from flutter_nsd.

jnstahl avatar jnstahl commented on June 12, 2024

the current Windows implementation returns hostnames, such as 'Android-5.local' when provided by the MDNS query results. However some windows hosts do not have the ability to resolve such a hostname and to establish a connection (apparently this ability relies on 3rd party packages such as Bonjour being installed).
Suggested fix:

  • short-term: Windows implementation will always return an IP address string for hostname

  • long-term: the NsdServiceInfo object can be expanded to include:

    • ipv4
    • ipv6
      in addition to hostname and port

Sounds like a plan 👍

val hostname = this?.host?.canonicalHostName <==== canonicalHostName will return either IP address or hostname on the android implementation

OK. That's good to know. How about the iOS/MacOS implementation?

One would have to test. But on iOS presumably it won't matter as MDNS is native to iOS and the hostname will always be resolvable. this particular complication is specific to Windows. I found out even more - the hostname may be resolvable within the Flutter app but when opened in an external browser (Chrome) is still not resolvable. Or Flutter may resolve it to an ipv6 which cannot be loaded into chrome either. So now for the purpose of opening external browsers I force resolve it to an ipv4 inside my app before constructing the url. But that is independent from the plugin.

from flutter_nsd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.