Code Monkey home page Code Monkey logo

mas-piano-validator-cli's People

Contributors

dependabot[bot] avatar niktekusho avatar

Watchers

 avatar  avatar

mas-piano-validator-cli's Issues

Freeze mas-piano-validator dependency version

During this preliminary feature implementations stint, I set the version of the core library to latest. Once everything is stable enough, I need to fix/freeze the version in the package.json file.

Move features from this project to the core library

With the current setup, everyone would need to do a lot of the stuff which has been done here to use the library in a meaningful way:

  • Reading file content and parsing that content.
  • Reading directory content and validate found JSON files.
  • Better error handling.

This features move should allow for better-tested features and less copy-paste code around.

CLI should resolve env vars

This might be a Windows-only problem, but passing in a path contained in an env var is not currently working. It seems Powershell does not like variable expansion.

Command example:

maspv "$env:MAS\game\mod_assets\piano\songs"

Error:

Error: ENOENT: no such file or directory, stat '\game\mod_assets\piano\songs'
    at Object.statSync (fs.js:872:3)
    at main (C:\Users\blablabla\AppData\Roaming\npm\node_modules\mas-piano-validator-cli\index.js:57:19)
    at Object.<anonymous> (C:\Users\blablabla\AppData\Roaming\npm\node_modules\mas-piano-validator-cli\cli.js:19:1)
    at Module._compile (internal/modules/cjs/loader.js:721:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:732:10)
    at Module.load (internal/modules/cjs/loader.js:620:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:560:12)
    at Function.Module._load (internal/modules/cjs/loader.js:552:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:774:12)
    at executeUserCode (internal/bootstrap/node.js:499:15)

Handle multiple arguments

The title says everything. In the current implementation, only the first argument is passed down to the execution logic.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.