nikolakozina / j2534 Goto Github PK

Thanks for this project, as it seems to be one of those rare sources of information beyond using closed source drivers with the Tactrix OpenPort. From looking at the code it seems it is using a simple ASCII protocol. I'm not so much interested in J2534-API-compatibility and would rather like to use the Tactrix on Linux w/ SocketCAN and on macOS with MacCAN.

Do you have any more info about this serial USB protocol apart from your source?

Have you ever tested this on an android platform? I would be very curious setting it up on android to allow an android phone to be used as a flashing platform with the OpenPort 2.0 cable.

Would be nice to create a readme.md with a 3 or 5 line summary of what this is - target platform, included functionality etc :)

See Comer352L/FreeSSM#23.

There are at least two issues:

1.) If timeout=0 is passed to PassThruReadMsgs(), the function does not return immediately

Section 7.2.5.2. of the J2434 API specification says:
"If a value of 0 is specified the function retrieves up to pNumMsgs messages and returns immediately."

But the current implementation makes the function blocking forever, if no message is received.
The reason for this incorrect behavior seems to be, that the timeout value is passed to libusb_bulk_transfer(), which interprets value 0 as "infinite".

2.) If a short timeout is selected, the last received message from the ECU is returned

Looking into the code, it seems that the success of the USB transfer is not verified at all and hence timeouts are not recognized and handled properly.

I don't have access to an OpenPort 2.0 interface, but if there is something I can do to help, just let me know.

What's the license for this? MIT, GPL?