niklasgollenstede / re-style Goto Github PK

In my opinion, reStyle does not stand a chance in competing with current Stylus and Stylish in terms of in-site styles, these extensions are just way ahead in user experience. I think it could keep the option for using it for these sites - just like userContent.css in Firefox - but it would be used by users who prefer to install more UI styles and maybe just a few content styles.

However, where it does stand a chance is in user interface customization.
For example, the previously highly popular Classic Theme Restorer moved out of AMO and into GitHub because of "Mozilla's hostility" and other arguments against AMO and deprecating XUL.
Similar thing happened with the creation of r/firefoxcss due to the crappy userstyles.org redesign and overall matter of Stylish no longer having UI styles option.

That's where reStyle comes in. It is on AMO, it is semi-automated and it has active development.
I think we should do as much as possible to make using it effortless, including

• first setup (NativeExt could help more with it)
• discovering styles (list of repository links for example)
• integration (familiar look and feel - it seems to follow the old UI style of Firefox, not Quantum one)
• style management (online and offline styles to have same buttons - #16 )

What do you think?

Have you considered using a PageAction for installing styles and normal button for managing styles? That would reduce clicks and therefore improve usability.

to be exact the error reads "unsupported 16-Bit application"

Why do local styles not have a button Remove?
It would also make sense to add a button Add below them, so opening the popup would not be necessary if the user doesn't want to target a specific website with the new style.

Currently, when editing a style this disclaimer is shown:

Please note that changes made here are not permanent and will be overwritten on the next update of this style. To customize a style permanently, create a local copy of it.

What if you just added a way for users to disable auto-update for specific styles? In my opinion having to manually create a local copy breaks the convenience of a one-click install, especially since there isn't a one-click way to create a local copy either.

Hello. I wish we could have a keyboard shortcut for enabling / disabling all styles.

Thank you for this great extension, regards!

Assume that a user wants to have a "full theme" like MaterialFox while keeping the flexibility of reStyle.

What if reStyle had an option (automatic check would be harder) to be compatible with that, by keeping everything in chrome folder intact, appending any reStyle userstyles by adding an @include tag that references an external, user-defined file - like reStyle already does for development - and modifying that?

It sounds a bit confusing but overall I mean respecting the current contents of the file, instead of forcing the user to install everything through reStyle.

Hello,
First, thank you very much for this program, I like it very much.

I am writing this to see if you can help to solve a problem present on reStyle as well as on Stylish and his fork Stylus for Firefox.

I am using reStyle on Firefox version 57.0.1 (firefox quantum). The problem is that on some pages, like in google search or bing search, the styles are applied after the page is loaded. This cause that if you are using a dark style, it flashes with the default white background color for a second before becoming dark.

You can see the problem following this steps:

1. Apply one dark style to reStyle. For example, this one is a very good one: https://userstyles.org/styles/31267/global-dark-style-changes-everything-to-dark
2. Search something on www.bing.com
3. Click on "next page" on the bottom of bing's search page.
4. On the browser's panel, click back to go to the previous page.
5. On the browser's panel, click next to go to the following page.
6. On the browser's panel, click back and next in succession to see the flashes.

Notice that the problem does not happen every single time. Also, sometimes it doesn't apply the style at all.

I am pretty sure that this problem was not present on versions older than firefox quantum.
Also, using Stylish or Stylus on Chrome web browser the problem does not appear.

Thank you very much sir,
Regards.

I was thinking, why not make the reStyle ask for a restart after a style installation, just like Firefox used to do?

Since popups can be opened programmatically and you have NativeExt anyway to execute code in OS, I think it should be fairly easy to add that feature.

Edit: just noticed the notification, but that doesn't have an option to actually restart the browser, so the suggestion remains.

https://comfy.moe/dfxcpp.png

here is the issue

Can I suggest you add something to the extension? I use other extensions that use (different) messaging clients and each of those has a test button. It easily and quickly flags if the extension has a problem talking to the client.

As it happens the client for this extension fails to install on my Windows 10, Nightly v59.0a setup. It looks like some kind of bin folder gets installed in the client directory as a folder junction going nowhere. Anyway the two ain't talking.

I am thinking synchronizing browser extensions with messaging clients is not going to be easy. I have four different messaging clients registered for Firefox so far. That's four extensions I have to install then install a client (or is it the other way around, nobody is actually saying?) In this case I wasn't even aware that the extension needed a client until after I had installed it. So it goes.

It all generates a whole lot of traffic for GitHub though.

reStyle has a lot of permissions, and that could scare away new users. So why not use runtime permissions?

• storage - could ask on install because I assume reStyle doesn't have a fallback for styles on extension storage
• nativeMessaging - request when user wants to set up NativeExt
• notifications - opt-in or don't use at all
• tabs, webNavigation, <all_urls> - I don't quite get their difference, but if they achieve the same goal, they can be asked on install

It seems like the Shift+F2 bar will go away soon, it is gone already for me in 62 beta and 63 nightly.

Easiest way to restart now would be going to about:profiles and clicking Restart normally...

I was also thinking, maybe reStyle can automate some of it, with the help of NativeExt?
Opening the page automatically/with a button would be a good start.

Alternatively, as suggested in the link, user could press Ctrl+Shift+J and then Ctrl+Alt+R, but that is a lot of buttons to press and leaves a potentially confusing log-spamming window open.

I was trying to setup ff60 to see if I could switch from waterfox.

I cant get native-ext to run (unsupported 16-bit blah blah) and now the ff install cannot be used because the restyle option page in question immediately switches to itself if i change to another tab, and always reopens itself (and another 2-4 restyle option tabs) if i close it.

I mean, I'll restart with addons disabled and turn it off, but yeah that's a thing, you're being a little aggressive with grabbing focus here.

Could I use a development mode folder inside the Fx profile folder? It would keep things consistent and contained.

Right now I get a "That didn't work... / Error: Can't create file..." popup, followed by the typical restart prompt (and no new style after the restart).

To give more information:

• I created a folder called dev
• Used the full path in settings (not relative to anything)
• reStyle - DEV 0.4.1b20
• Nightly 63.0a1 (2018-08-04)

In order to make the process even smoother for the user, have you considered extracting the styles from popular sites?
By extracting I mean getting the raw CSS without requiring the user to navigate there (assuming they navigate to the preview page).

Sites it could support initially:

• userstyles.org
• github.com
• gitlab.com
• openusercss.org

It seems like reStyle uses a bit too many notifications, especially since it already communicates through the button/popup.

Perhaps you could make it so that the changes made in extension page are reflected within that page and changes made within any other site are reflected in button/popup (which could also pop up by itself if needed)?
That would reduce clutter by a lot and imiate the way Firefox itself does it.

In Firefox 69, toolkit.legacyUserProfileCustomizations.stylesheets must be set to true in about:config. The extension should either do it automatically, check for it (if possible) or simply instruct the users.
https://www.reddit.com/r/firefox/comments/brttne/psa_firefox_v69_users_will_have_to_set_a_pref_to/

This causes:

when installing one, I still get an error (even though it will get listed to my styles):
SyntaxError: JSON.parse: unexpected character at line 1 column 1 of the JSON data

NiklasGollenstede/native-ext#2 (comment)

When toggling the development mode, I get a notification with the text

That didn't work ...
TypeError: native is null

Using successful installs of NativeExt 0.1.0 for Linux x64, packaged script from reStyle 0.2.1b8, Firefox 58.0a1 (2017-11-03), Ubuntu 17.10.

I prefer white backgrounds on my browser, so would be nice if reStyle had an option to toggle the theme.