nikhilnamal17 / popular-movie-quotes Goto Github PK

Can i Contribute?

Some of the objects in the data set have missing attributes like 'type'. Need to fix that.

Implement a function which returns an array of quotes with given length.

• console.log(movieQuote.getSome(10)); // get an array of 10 quotes.
• console.log(movieQuote.getSomeRandom(10)); // get an array of 10 random quotes.

I will be making a pull request.

Do you know any popular movie quotes?
Add your quote to data.json inside the data/ folder and raise the PR.
Language: Only English

{  
      "quote": "Your new Quote",
      "movie": "movie name",
      "type": "movie/anime/tv",
      "year": 2012
}

Note:

Please avoid the repetition of quotes.
Add your quotes in between. Don't add at the bottom or at the top.
Follow the template.
Do not make any changes in other files.
Add me(@NikhilNamal17 ) as reviewer.
Thanks!

On line 2549, the year is 2012-2019, I think it should be inside string quotes

There is no property that defines if it is from a movie or TV show

Below are some items from the quotes currently
Proposed Types
tv, movie, anime,

  {
    "quote": "I used to think that my life was a tragedy. But now I realize, it’s a comedy.",
    "title": "Joker",
    "type": "movie",
    "year": 2019
  },
  {
    "quote": "Learn to embrace the fear of feeling about what it's like to contemplate what it is to know true pain. Because when I had nothing and no one - I always had pain.",
    "title": "Naruto Shippuden",
    "type": "anime",
    "year": null
  },

Add mocha unit tests to check if quotes have desired formats.

{  
      "quote": "String",
      "movie": "String",
      "type": "String",
      "year": Number
}

The test should check if the quote exists and is a type of String, same goes with each attribute with an associated data type.

Add tests to check the data to be uniform when the functions are called as some have the year as a property and other quotes have in the title of the movie/show

For instance

{
    "quote": "words here for a quote",
    "title": "that movie we saw one time",
     "year": "1964",
}

Hello, i just wanna know that are you still maintaining this repo by receiving some new quotes?