nikhilkumarrathi / cryptotrader-telegram Goto Github PK

python 3.8 is not supported because of using time_ns() in commands.py. I got 'time' has no attribute 'time_ns' but is ok on python 3.7

I was trying to run the bot and check it out. first there was an error in config file JSON formatting ( missing comma after "adminUserId": "--userid--" ). after that the following error was displayed when running the bot :

Traceback (most recent call last):
File "bot.py", line 6, in
import commands as cm
File "/root/cryptotrader-telegram/commands.py", line 11, in
import charts
File "/root/cryptotrader-telegram/charts.py", line 17, in
from lib import app
File "/root/cryptotrader-telegram/lib.py", line 16, in
from config import configData
File "/root/cryptotrader-telegram/config.py", line 11, in
configData = DotMap(json.load(open('config/config.json','r')))
File "/usr/lib/python3.6/json/init.py", line 299, in load
parse_constant=parse_constant, object_pairs_hook=object_pairs_hook, **kw)
File "/usr/lib/python3.6/json/init.py", line 354, in loads
return _default_decoder.decode(s)
File "/usr/lib/python3.6/json/decoder.py", line 339, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
File "/usr/lib/python3.6/json/decoder.py", line 357, in raw_decode
raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 14 column 5 (char 418)

any suggestion on this would be appreciated.

Hi, your project cryptotrader-telegram(commit id: 870f6ac) requires "schedule==0.6.0" in its dependency. After analyzing the source code, we found that the following versions of schedule can also be suitable, i.e., schedule 0.4.3, 0.5.0, since all functions that you directly (3 APIs: schedule.init.clear, schedule.init.every, schedule.init.run_pending) or indirectly (propagate to 4 schedule's internal APIs and 0 outsider APIs) used from the package have not been changed in these versions, thus not affecting your usage.

Therefore, we believe that it is quite safe to loose your dependency on schedule from "schedule==0.6.0" to "schedule>=0.4.3,<=0.6.0". This will improve the applicability of cryptotrader-telegram and reduce the possibility of any further dependency conflict with other projects.

May I pull a request to further loosen the dependency on schedule?

By the way, could you please tell us whether such an automatic tool for dependency analysis may be potentially helpful for maintaining dependencies easier during your development?

My config setting is below, do I doing wrong. Please help. Thanks before.
{
"telegramApiKey": "1684741671:AAEY________", > Telegram Bot
"binanceApiKey": "Zz______",
"binanceApiSecret": "",
"accessControl": {
"groups": {
"public": [
"Sot" > Channel ID
]
},
"adminUserId": "C______", > My User ID
"adminChatId": "6______" > MY CHAT ID
}
}

2021-05-02 23:21:55 task_1 ERROR <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: self signed certificate in certificate chain (_ssl.c:1123)>
Traceback (most recent call last):
File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/urllib/request.py", line 1346, in do_open
h.request(req.get_method(), req.selector, req.data, headers,
File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/http/client.py", line 1253, in request
self._send_request(method, url, body, headers, encode_chunked)
File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/http/client.py", line 1299, in _send_request
self.endheaders(body, encode_chunked=encode_chunked)
File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/http/client.py", line 1248, in endheaders
self._send_output(message_body, encode_chunked=encode_chunked)
File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/http/client.py", line 1008, in _send_output
self.send(msg)
File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/http/client.py", line 948, in send
self.connect()
File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/http/client.py", line 1422, in connect
self.sock = self._context.wrap_socket(self.sock,
File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/ssl.py", line 500, in wrap_socket
return self.sslsocket_class._create(
File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/ssl.py", line 1040, in _create
self.do_handshake()
File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/ssl.py", line 1309, in do_handshake
self._sslobj.do_handshake()
ssl.SSLCertVerificationError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: self signed certificate in certificate chain (_ssl.c:1123)

I got this error after running bot and receiving first message from any user, although scheduled task did not run ever for admin.